Remove support for document.createEvent("ProgressEvent") |
|||
Issue descriptionSpec discussion/change and tests: https://github.com/whatwg/dom/issues/289 https://github.com/whatwg/dom/pull/421 https://github.com/w3c/web-platform-tests/pull/5158 Gecko issue is https://bugzilla.mozilla.org/show_bug.cgi?id=843489 In Blink, this would mean removing the "ProgressEvent" entry from third_party/WebKit/Source/build/scripts/make_event_factory.py Use counter: https://www.chromestatus.com/metrics/feature/timeline/popularity/1177
,
Mar 24 2017
Hi tkent, Can I take this up ? or do I need to send an Intent to remove , I read that this is already removed in Mozilla and Webkit and as I understand same needs to be removed in blink as well . Starting point is third_party/WebKit/Source/build/scripts/make_event_factory.py and need to remove other dependent places as well. Plz correct me if I am wrong Or if you any other opinion please let me know then I can start working on it. Thanks, Nikhil
,
Mar 24 2017
You can probably just remove it, as the usage seems very low, if I chose the right metric - https://www.chromestatus.com/metrics/feature/timeline/popularity/1177
,
Mar 26 2017
ok,thanks will do that.
,
Apr 2 2017
Update : I was unable to work on this as my other bugs are taking more time then expected by me . I will address this once I finish my other issues which are under review. If there is any hurry or I am keeping anyone waiting then plz do let me know . Thanks for your understanding.
,
Apr 6 2017
Submitted https://codereview.chromium.org/2803603003/ for review.
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5d70ebb214f8d77c943c98f1e2908c91b3d62b7 commit a5d70ebb214f8d77c943c98f1e2908c91b3d62b7 Author: nikhil.sahni <nikhil.sahni@samsung.com> Date: Thu Apr 13 11:57:53 2017 Removing support for document.createEvent("ProgressEvent") BUG= 703559 Review-Url: https://codereview.chromium.org/2803603003 Cr-Commit-Position: refs/heads/master@{#464378} [modify] https://crrev.com/a5d70ebb214f8d77c943c98f1e2908c91b3d62b7/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createEvent-expected.txt [modify] https://crrev.com/a5d70ebb214f8d77c943c98f1e2908c91b3d62b7/third_party/WebKit/LayoutTests/fast/events/event-creation-expected.txt [modify] https://crrev.com/a5d70ebb214f8d77c943c98f1e2908c91b3d62b7/third_party/WebKit/LayoutTests/fast/events/event-creation.html [modify] https://crrev.com/a5d70ebb214f8d77c943c98f1e2908c91b3d62b7/third_party/WebKit/Source/build/scripts/make_event_factory.py [modify] https://crrev.com/a5d70ebb214f8d77c943c98f1e2908c91b3d62b7/third_party/WebKit/Source/core/frame/UseCounter.h
,
Apr 13 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tkent@chromium.org
, Mar 24 2017Labels: Hotlist-Interop Hotlist-GoodFirstBug
Status: Available (was: Untriaged)