New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703556 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Pressing Enter key doesn't work on ARC notifications.

Project Member Reported by yhanada@chromium.org, Mar 21 2017

Issue description

Repro steps:
1. Show some ARC notifications
2. Move the focus to one of the notifications by pressing Tab key
3. Pressing Enter key.

Expected result:
Open the notification

Actual result:
Nothing happens

 
I filed an internal bug b/36469565
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9b559687be78936e36e571768dee3cc377131a6

commit a9b559687be78936e36e571768dee3cc377131a6
Author: yhanada <yhanada@chromium.org>
Date: Wed Mar 22 07:37:03 2017

Implement ArcNotificationDelegate::Click() for ArcCustomNotificationItem.

This method will be called when pressing Enter key on an ARC
notification.

BUG= 703556 

Review-Url: https://codereview.chromium.org/2761283002
Cr-Commit-Position: refs/heads/master@{#458670}

[modify] https://crrev.com/a9b559687be78936e36e571768dee3cc377131a6/ui/arc/notification/arc_custom_notification_item.cc

Labels: Merge-Request-58
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 23 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 23 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82f873b0f88c753862afc678d0b8e0899095d24a

commit 82f873b0f88c753862afc678d0b8e0899095d24a
Author: yhanada <yhanada@chromium.org>
Date: Thu Mar 23 13:29:04 2017

Implement ArcNotificationDelegate::Click() for ArcCustomNotificationItem.

This method will be called when pressing Enter key on an ARC
notification.

BUG= 703556 

Review-Url: https://codereview.chromium.org/2761283002
Cr-Commit-Position: refs/heads/master@{#458670}
(cherry picked from commit a9b559687be78936e36e571768dee3cc377131a6)

Review-Url: https://codereview.chromium.org/2769183002 .
Cr-Commit-Position: refs/branch-heads/3029@{#383}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/82f873b0f88c753862afc678d0b8e0899095d24a/ui/arc/notification/arc_custom_notification_item.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
9334.23.0 / 58.0.3029.39

Sign in to add a comment