Regression: Spacing issue is observed for 'Add Search Engine' overlay in chrome://settings.
Reported by
aiman.an...@etouch.net,
Mar 21 2017
|
||||||||
Issue descriptionChrome Version: 59.0.3047.0 (Official Build) 15ae1e89e749d6443b6caffdbc78ad24f945aa67-refs/heads/master@{#458255}(32/64 Bit). OS: Windows(7,8,8.1,10), Mac(10.11.6, 10.12.1, 10.12), Linux(14.04 LTS) Steps to reproduce: 1.Launch Chrome, go to chrome://settings/appearance, change Font Size to 'Very Large'. 2.Go to chrome://settings/searchEngines and scroll down, in 'Other Search Engines' click on 'ADD' 3.On 'Add Search Engine' overlay for 'Search Engine' press 'Space Bar' and observe. Actual Result: Spacing issue is seen. Expected Result: Spacing issue should not be seen. This is regression issue broken in 'M 58' and will soon update the bisect info: Manual Bisect Info: Good Build 58.0.3026.0 Bad Build 58.0.3027.0.
,
Mar 21 2017
,
Mar 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29049fd00eb628cff76d2eda785e4e03e80be962 commit 29049fd00eb628cff76d2eda785e4e03e80be962 Author: scottchen <scottchen@chromium.org> Date: Wed Mar 22 22:21:50 2017 MD Settings: make input with error msg scale spacing with font-size. BUG= 703528 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2760393004 Cr-Commit-Position: refs/heads/master@{#458897} [modify] https://crrev.com/29049fd00eb628cff76d2eda785e4e03e80be962/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html
,
Mar 23 2017
,
Mar 28 2017
Verified on Mac os 10.12.3 , ubuntu 14.04 and windows 7 using chrome M59 #59.0.3053.3 and issue is still reproduced . Steps tried to reproduce : 1.Launched Chrome and navigated to chrome://settings/appearance, changed Font Size to 'Very Large'. 2.Navigated to chrome://settings/searchEngines and scrolled down, in 'Other Search Engines' clicked on 'ADD' 3.On 'Add Search Engine' overlay for 'Search Engine' pressed 'Space Bar' and observed still space issue . Attached screenshot for reference. @scottchen--COuld you please check attached screenshot and steps , and please let us know if we had missed any steps in verifying the issue. Thanks!
,
Mar 28 2017
,
Mar 28 2017
scottchen@, can you please take a look? Thank you!
,
Mar 31 2017
,
Apr 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc5ec856b729b019f0933b04baca929dcca60626 commit bc5ec856b729b019f0933b04baca929dcca60626 Author: scottchen <scottchen@chromium.org> Date: Mon Apr 03 19:28:30 2017 MD Settings: more consistently fix error message space for search engine I found a really weird behavior - <paper-input-container> has an "@apply(--paper-input-container)" rule, which generates a "padding: var(--paper-input-container_-_padding, 8px 0)" rule when I set "padding-bottom" in the mixin from my element. However, about 3 out of 10 times, the renderer doesn't seem to recognize that "padding-bottom" is part of "padding" and behaves like, "well the 'padding' rule isn't specified so I'm gonna render the fallback '8px 0'". So I explicitly specified a "padding" rule and the intermittent bug went away. BUG= 703528 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2788803003 Cr-Commit-Position: refs/heads/master@{#461502} [modify] https://crrev.com/bc5ec856b729b019f0933b04baca929dcca60626/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html
,
Apr 3 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by rbasuvula@chromium.org
, Mar 21 2017Labels: hasbisect-per-revision
Owner: scottchen@chromium.org
Status: Assigned (was: Unconfirmed)