Issue metadata
Sign in to add a comment
|
base_unittests(SysInfoTest.AmountOfAvailablePhysicalMemory) failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1) |
||||||||||||||||||
Issue descriptionbase_unittests failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1) Builders failed on: - Linux ChromiumOS Tests (dbg)(1): https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29 SysInfoTest.AmountOfAvailablePhysicalMemory (run #1): [ RUN ] SysInfoTest.AmountOfAvailablePhysicalMemory ../../base/sys_info_unittest.cc:56: Failure Expected: (amount) < (info.total * 1024), actual: 23450660864 vs 1561014272 [ FAILED ] SysInfoTest.AmountOfAvailablePhysicalMemory (2 ms) SysInfoTest.AmountOfAvailablePhysicalMemory (run #2): [ RUN ] SysInfoTest.AmountOfAvailablePhysicalMemory ../../base/sys_info_unittest.cc:56: Failure Expected: (amount) < (info.total * 1024), actual: 23478435840 vs 1561014272 [ FAILED ] SysInfoTest.AmountOfAvailablePhysicalMemory (2 ms) SysInfoTest.AmountOfAvailablePhysicalMemory (run #3): [ RUN ] SysInfoTest.AmountOfAvailablePhysicalMemory ../../base/sys_info_unittest.cc:56: Failure Expected: (amount) < (info.total * 1024), actual: 23478853632 vs 1561014272 [ FAILED ] SysInfoTest.AmountOfAvailablePhysicalMemory (2 ms) SysInfoTest.AmountOfAvailablePhysicalMemory (run #4): [ RUN ] SysInfoTest.AmountOfAvailablePhysicalMemory ../../base/sys_info_unittest.cc:56: Failure Expected: (amount) < (info.total * 1024), actual: 23478607872 vs 1561014272 [ FAILED ] SysInfoTest.AmountOfAvailablePhysicalMemory (1 ms) https://codereview.chromium.org/2558043007 introduced this.
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad039f65398a94f4a28751c303df388cff4bbca3 commit ad039f65398a94f4a28751c303df388cff4bbca3 Author: horo <horo@chromium.org> Date: Tue Mar 21 07:02:56 2017 Revert of Fix free memory calculation. (patchset #27 id:520001 of https://codereview.chromium.org/2558043007/ ) Reason for revert: SysInfoTest.AmountOfAvailablePhysicalMemory is failing BUG= 703522 Original issue's description: > Fix free memory calculation. > > The term "free memory" can mean different things: it can mean > 1) absolutely/pure free physical memory (not consumed by anything) or > 2) it can include the inactive part(s) of OS (file) cache(s) or > 3) it can mean the maximum amount of physical memory that can be > allocated quickly without swapping and thus can also include the > active part(s) of OS cache(s). > > This CL fixes base::AmountOfAvailablePhysicalMemory() to function > according to the 2nd meaning on all platforms where it is possible > because this is what everyone needs most of the time. (Win platform > has already had such implementation but others haven't). > > BUG= 672745 > > Review-Url: https://codereview.chromium.org/2558043007 > Cr-Commit-Position: refs/heads/master@{#458291} > Committed: https://chromium.googlesource.com/chromium/src/+/a4258cad75d8cc63170555cc74bd584b5bfca965 TBR=primiano@chromium.org,danakj@chromium.org,brucedawson@chromium.org,xiyuan@chromium.org,chrisha@chromium.org,haraken@chromium.org,mkolom@yandex-team.ru # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 672745 Review-Url: https://codereview.chromium.org/2766623002 Cr-Commit-Position: refs/heads/master@{#458333} [modify] https://crrev.com/ad039f65398a94f4a28751c303df388cff4bbca3/base/process/process_metrics.cc [modify] https://crrev.com/ad039f65398a94f4a28751c303df388cff4bbca3/base/process/process_metrics.h [modify] https://crrev.com/ad039f65398a94f4a28751c303df388cff4bbca3/base/process/process_metrics_ios.cc [modify] https://crrev.com/ad039f65398a94f4a28751c303df388cff4bbca3/base/process/process_metrics_linux.cc [modify] https://crrev.com/ad039f65398a94f4a28751c303df388cff4bbca3/base/process/process_metrics_mac.cc [modify] https://crrev.com/ad039f65398a94f4a28751c303df388cff4bbca3/base/process/process_metrics_unittest.cc [modify] https://crrev.com/ad039f65398a94f4a28751c303df388cff4bbca3/base/process/process_metrics_win.cc [modify] https://crrev.com/ad039f65398a94f4a28751c303df388cff4bbca3/base/sys_info.h [modify] https://crrev.com/ad039f65398a94f4a28751c303df388cff4bbca3/base/sys_info_ios.mm [modify] https://crrev.com/ad039f65398a94f4a28751c303df388cff4bbca3/base/sys_info_linux.cc [modify] https://crrev.com/ad039f65398a94f4a28751c303df388cff4bbca3/base/sys_info_mac.mm [modify] https://crrev.com/ad039f65398a94f4a28751c303df388cff4bbca3/base/sys_info_openbsd.cc [modify] https://crrev.com/ad039f65398a94f4a28751c303df388cff4bbca3/base/sys_info_unittest.cc [modify] https://crrev.com/ad039f65398a94f4a28751c303df388cff4bbca3/base/sys_info_win.cc [modify] https://crrev.com/ad039f65398a94f4a28751c303df388cff4bbca3/chrome/browser/ui/webui/about_ui.cc [modify] https://crrev.com/ad039f65398a94f4a28751c303df388cff4bbca3/components/memory_pressure/direct_memory_pressure_calculator_win.cc [modify] https://crrev.com/ad039f65398a94f4a28751c303df388cff4bbca3/components/memory_pressure/direct_memory_pressure_calculator_win_unittest.cc [modify] https://crrev.com/ad039f65398a94f4a28751c303df388cff4bbca3/content/browser/memory/memory_monitor_win.cc [modify] https://crrev.com/ad039f65398a94f4a28751c303df388cff4bbca3/content/browser/memory/memory_monitor_win_unittest.cc
,
Mar 21 2017
,
Mar 21 2017
It was better to disable the test. |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by mko...@yandex-team.ru
, Mar 21 2017