New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703505 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

"mountinfo" in chrome://system doesn't indicate if ecryptfs is used

Project Member Reported by hashimoto@chromium.org, Mar 21 2017

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Log in as a user whose home dir is using eCryptfs
(2) Open chrome://system

What is the expected result?
It displays lines with "ecryptfs" as the fs type.

What happens instead?
No "ecryptfs" included.

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
"mountinfo" was added inhttps://chromium-review.googlesource.com/c/446144/.
@uekawa, do you happen to know why this is happening?

Comment 2 by uekawa@chromium.org, Mar 21 2017

sorry about that, seems like `/proc/$(pgrep debugd)/mountinfo` doesn't contain the user mounts.

Cc: uekawa@chromium.org
Owner: hashimoto@chromium.org
I'll handle this.

Comment 4 by uekawa@chromium.org, Apr 10 2017

after Nth time of being bitten by this I put together 
https://chromium-review.googlesource.com/472311

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/710cb4b6b6ee2e9c750db6ce96255f211107704c

commit 710cb4b6b6ee2e9c750db6ce96255f211107704c
Author: Junichi Uekawa <uekawa@google.com>
Date: Thu Apr 13 03:22:31 2017

debugd: Look at mountpoints from init instead of debugd.

Debugd runs inside a mount namespace but not inside a pid namespace,
so this gives a view of what is mounted.

TEST=manually observe ext4 crypto system.
BUG= chromium:703505 

Change-Id: I1b53d37fcca1e6a887f6ed0137e58d6c797db1d2
Reviewed-on: https://chromium-review.googlesource.com/472311
Commit-Ready: Junichi Uekawa <uekawa@chromium.org>
Tested-by: Junichi Uekawa <uekawa@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>

[modify] https://crrev.com/710cb4b6b6ee2e9c750db6ce96255f211107704c/debugd/src/log_tool.cc

Comment 6 by uekawa@chromium.org, Apr 13 2017

Owner: uekawa@chromium.org
Status: Started (was: Assigned)

Comment 7 by uekawa@chromium.org, Apr 14 2017

Labels: Merge-Request-58
 I'd like to have this merged in M58 because we're trying to roll out this new file system in a subset of devices and knowing this in feedback reports is useful.

Comment 8 by uekawa@chromium.org, Apr 14 2017

(verified on caroline and kevin canary).

Project Member

Comment 9 by sheriffbot@chromium.org, Apr 14 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: We are only 10 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-58 Merge-Approved-58
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 15 2017

Labels: merge-merged-release-R58-9334.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8b72b83f89845d9c09600e18e61fe897602bc4d9

commit 8b72b83f89845d9c09600e18e61fe897602bc4d9
Author: Junichi Uekawa <uekawa@google.com>
Date: Sat Apr 15 02:03:21 2017

debugd: Look at mountpoints from init instead of debugd.

Debugd runs inside a mount namespace but not inside a pid namespace,
so this gives a view of what is mounted.

TEST=manually observe ext4 crypto system.
BUG= chromium:703505 

Change-Id: I1b53d37fcca1e6a887f6ed0137e58d6c797db1d2
Reviewed-on: https://chromium-review.googlesource.com/472311
Commit-Ready: Junichi Uekawa <uekawa@chromium.org>
Tested-by: Junichi Uekawa <uekawa@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
(cherry picked from commit 710cb4b6b6ee2e9c750db6ce96255f211107704c)
Reviewed-on: https://chromium-review.googlesource.com/476371
Reviewed-by: Junichi Uekawa <uekawa@chromium.org>
Commit-Queue: Junichi Uekawa <uekawa@chromium.org>
Trybot-Ready: Junichi Uekawa <uekawa@chromium.org>

[modify] https://crrev.com/8b72b83f89845d9c09600e18e61fe897602bc4d9/debugd/src/log_tool.cc

Status: Fixed (was: Started)
to verify, chrome://system contains mountinfo with /home/.shadow/ ecryptfs mount points on ecryptfs systems and lots (63 for me) of mount points.

It used to contain 26 mount points before.



Project Member

Comment 14 by sheriffbot@chromium.org, Apr 18 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 15 by uekawa@google.com, Apr 19 2017

Labels: -Merge-Approved-58

Comment 16 by son...@google.com, Apr 27 2017

Status: Verified (was: Fixed)
Verified on build 9334.58.0

Sign in to add a comment