New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703502 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 700627



Sign in to add a comment

NotImplementedError: DatetimeProperty sheriff_action_time can only support UTC. Please derive a new Property to support alternative timezones.

Project Member Reported by st...@chromium.org, Mar 21 2017

Issue description

The cron job for "/waterfall/check-reverted-cls" failed to the this error.

You could manually trigger a run by visiting the url directly.
 

Comment 1 by st...@chromium.org, Mar 21 2017

Blocking: 700627
Jeff: please work with Roberto to fix the problem. The root cause seems to be in the code to deal with Rietveld.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c343591bfae64af558178eaffdb64a8a79022f00

commit c343591bfae64af558178eaffdb64a8a79022f00
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Tue Mar 21 20:10:59 2017

[Findit] Fixing Revert.timestamp not to use timezone

BUG= 703502 

It seems the timestamp returned from time_util.UTCDatetimeFromNaiveString is in the format datetime.datetime(2017, 3, 19, 1, 28, 20, 351410, tzinfo=<UTC>), with "tzinfo=<UTC>" throwing the exception when calling .put().
It appears the timestamps in Rietveld are already in UTC, making this unnecessary and just DatetimeFromString suffices and is in a format that can be written to the datastore.

Change-Id: I8e7e797109bb709afd9d5325bdc2648cc2228470
Reviewed-on: https://chromium-review.googlesource.com/457294
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/c343591bfae64af558178eaffdb64a8a79022f00/appengine/findit/infra_api_clients/codereview/rietveld.py
[modify] https://crrev.com/c343591bfae64af558178eaffdb64a8a79022f00/appengine/findit/infra_api_clients/codereview/test/rietveld_test.py

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment