Issue metadata
Sign in to add a comment
|
Log metrics for LSD |
||||||||||||||||||||||||
Issue descriptionWe should figure out the metrics we are interested in, and log them separately for both the DSE and for other sites. Things we're probably interested in: - how many times the LSD is shown - how many times LSD is suppressed due to backoff - backoff state when the LSD is shown or suppressed (i.e. not in any backoff, 1 week backoff, 1 month backoff etc.) - LSD result (ideally including 'back' as a separate value, if possible). Anything else to log?
,
Mar 21 2017
All of those sgtm. It might be interesting to log a metric that would be useful when deciding "how much backoff is appropriate". Maybe we can log LSD result together with backoff state -- so result when it's not in backoff, result when its in 1wk backoff, result when it's in 1mo backoff. Then if we experiment with a different backoff, we can compare results.
,
Mar 21 2017
Yep, that makes sense.
,
Mar 22 2017
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc48af3732f96f60c30396ed10b158314bc0b8c9 commit dc48af3732f96f60c30396ed10b158314bc0b8c9 Author: benwells <benwells@chromium.org> Date: Thu Apr 06 13:15:45 2017 Log metrics for the Location Settings Dialog prompt for geolocation. This prompt is shown when the user has turned off location and a web site asks for geolocation access. There are various controls to prevent spamminess (a gesture requirement for non-default search engine sites, and a backoff system). This change adds metrics for number of times the dialog was shown, suppressed (for backoff), accepted or denied. Each metric has two versions, one for the default search engine and one for other sites. The value logged for each metric is the current back off level. This change also cleans up some code for the backoff, using an enum instead of an int to represent it. It also caches some calculations done on whether an origin is the default search engine to prevent it happening quite as much as it was. BUG= 703493 Review-Url: https://codereview.chromium.org/2791193002 Cr-Commit-Position: refs/heads/master@{#462446} [modify] https://crrev.com/dc48af3732f96f60c30396ed10b158314bc0b8c9/chrome/browser/geolocation/geolocation_permission_context_android.cc [modify] https://crrev.com/dc48af3732f96f60c30396ed10b158314bc0b8c9/chrome/browser/geolocation/geolocation_permission_context_android.h [modify] https://crrev.com/dc48af3732f96f60c30396ed10b158314bc0b8c9/chrome/browser/geolocation/geolocation_permission_context_unittest.cc [modify] https://crrev.com/dc48af3732f96f60c30396ed10b158314bc0b8c9/tools/metrics/histograms/histograms.xml
,
Apr 7 2017
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/482fc385c00db8e1486189590840a3e4ddb7a68e commit 482fc385c00db8e1486189590840a3e4ddb7a68e Author: benwells <benwells@chromium.org> Date: Tue Apr 18 20:51:49 2017 Fix histograms suffix separator for Location Settings Dialog metrics. BUG= 703493 Review-Url: https://codereview.chromium.org/2828473002 Cr-Commit-Position: refs/heads/master@{#465360} [modify] https://crrev.com/482fc385c00db8e1486189590840a3e4ddb7a68e/tools/metrics/histograms/histograms.xml
,
May 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b19c6575a331d41e4fcc6dc742d2abcfebc0430e commit b19c6575a331d41e4fcc6dc742d2abcfebc0430e Author: benwells <benwells@chromium.org> Date: Mon May 08 09:03:39 2017 Fix GeolocationSettingsDialogBackOff histograms enum The enum is out of sync with the code, which has an extra value. BUG= 703493 Review-Url: https://codereview.chromium.org/2865793003 Cr-Commit-Position: refs/heads/master@{#469928} [modify] https://crrev.com/b19c6575a331d41e4fcc6dc742d2abcfebc0430e/tools/metrics/histograms/enums.xml |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by benwells@chromium.org
, Mar 21 2017