New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703489 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Refactor mojo::MessageReceiver*::AcceptWithResponder to take a unique_ptr to the responder

Project Member Reported by w...@chromium.org, Mar 21 2017

Issue description

This is a TODO left by yzshen@.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25f0f5f955e5d61d055dbe69a791db80541ef8ee

commit 25f0f5f955e5d61d055dbe69a791db80541ef8ee
Author: watk <watk@chromium.org>
Date: Wed Mar 22 08:26:52 2017

mojo: MessageReceiver*::AcceptWithResponder() now take a unique_ptr to the responder

Previously these functions took raw pointers to MessageReceivers and
took ownership on success or left ownership with the caller if they
failed. Now they take unique_ptrs (always assuming ownership) to make
the interface clearer and safer.

BUG= 703489 

Review-Url: https://codereview.chromium.org/2766523002
Cr-Commit-Position: refs/heads/master@{#458684}

[modify] https://crrev.com/25f0f5f955e5d61d055dbe69a791db80541ef8ee/mojo/public/cpp/bindings/interface_endpoint_client.h
[modify] https://crrev.com/25f0f5f955e5d61d055dbe69a791db80541ef8ee/mojo/public/cpp/bindings/lib/associated_interface_ptr_state.h
[modify] https://crrev.com/25f0f5f955e5d61d055dbe69a791db80541ef8ee/mojo/public/cpp/bindings/lib/control_message_handler.cc
[modify] https://crrev.com/25f0f5f955e5d61d055dbe69a791db80541ef8ee/mojo/public/cpp/bindings/lib/control_message_handler.h
[modify] https://crrev.com/25f0f5f955e5d61d055dbe69a791db80541ef8ee/mojo/public/cpp/bindings/lib/control_message_proxy.cc
[modify] https://crrev.com/25f0f5f955e5d61d055dbe69a791db80541ef8ee/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc
[modify] https://crrev.com/25f0f5f955e5d61d055dbe69a791db80541ef8ee/mojo/public/cpp/bindings/lib/interface_ptr_state.h
[modify] https://crrev.com/25f0f5f955e5d61d055dbe69a791db80541ef8ee/mojo/public/cpp/bindings/lib/pipe_control_message_proxy.cc
[modify] https://crrev.com/25f0f5f955e5d61d055dbe69a791db80541ef8ee/mojo/public/cpp/bindings/message.h
[modify] https://crrev.com/25f0f5f955e5d61d055dbe69a791db80541ef8ee/mojo/public/cpp/bindings/tests/bindings_perftest.cc
[modify] https://crrev.com/25f0f5f955e5d61d055dbe69a791db80541ef8ee/mojo/public/cpp/bindings/tests/multiplex_router_unittest.cc
[modify] https://crrev.com/25f0f5f955e5d61d055dbe69a791db80541ef8ee/mojo/public/cpp/bindings/tests/router_test_util.cc
[modify] https://crrev.com/25f0f5f955e5d61d055dbe69a791db80541ef8ee/mojo/public/cpp/bindings/tests/router_test_util.h
[modify] https://crrev.com/25f0f5f955e5d61d055dbe69a791db80541ef8ee/mojo/public/cpp/bindings/tests/sample_service_unittest.cc
[modify] https://crrev.com/25f0f5f955e5d61d055dbe69a791db80541ef8ee/mojo/public/cpp/bindings/thread_safe_interface_ptr.h
[modify] https://crrev.com/25f0f5f955e5d61d055dbe69a791db80541ef8ee/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl
[modify] https://crrev.com/25f0f5f955e5d61d055dbe69a791db80541ef8ee/mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl
[modify] https://crrev.com/25f0f5f955e5d61d055dbe69a791db80541ef8ee/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl

Comment 2 by w...@chromium.org, Mar 31 2017

Status: Fixed (was: Started)

Sign in to add a comment