New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 703476 link

Starred by 2 users
Status: Fixed
Owner:
█ mgiuca@chromium.org
Long OOO (go/where-is-mgiuca)
Closed: Apr 2017
Cc:
█ owe...@chromium.org
timloh@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 587623



Sign in to add a comment

getInstalledRelatedApps: Implement as Origin Trial with killswitch

Project Member Reported by mgiuca@chromium.org, Mar 21 2017 
Chrome Version: 59
OS: Android

Roll out the getInstalledRelatedApps Web API as an Origin Trial experiment.

This includes the implementation of the trial token check, and the remote killswitch.

Comment 1 by mgiuca@chromium.org, Apr 7 2017

Status: Started (was: Assigned)
This landed (without a browser-side killswitch), with the wrong bug ID:

commit 1970247d68492c3fa208468e34aab2d7803c192b
Author: mgiuca <mgiuca@chromium.org>
Date:   Sun Apr 2 19:10:44 2017 -0700

    Add an Origin Trial for Navigator.getInstalledRelatedApps.
    
    BUG=587623
    
    Review-Url: https://codereview.chromium.org/2785913003
    Cr-Commit-Position: refs/heads/master@{#461360}
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d9a196e23ef92fd8a270e31da6b2bf06d9609b6

commit 3d9a196e23ef92fd8a270e31da6b2bf06d9609b6
Author: mgiuca <mgiuca@chromium.org>
Date: Fri Apr 07 05:25:44 2017

Add a browser-side kill switch to getInstalledRelatedApps.

If the Origin Trial is disabled from a server config, the Mojo service
will no longer be created. This prevents a compromised renderer from
using the service, even after the API is shut down in the event of a
security problem being discovered.

BUG= 703476 

Review-Url: https://codereview.chromium.org/2799393003
Cr-Commit-Position: refs/heads/master@{#462768}

[modify] https://crrev.com/3d9a196e23ef92fd8a270e31da6b2bf06d9609b6/chrome/browser/chrome_content_browser_client.cc

Comment 3 by mgiuca@chromium.org, Apr 7 2017

Status: Fixed (was: Started)
►

Sign in to add a comment