webkit_tests request-body-blob-crash.html of virtual/mojo-loading failing |
|||||
Issue descriptionwebkit_tests failing on 9 builders Builders failed on: - WebKit Win7 (dbg): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29 https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7__dbg_/9302/layout-test-results/results.html https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7__dbg_/9302/layout-test-results/virtual/mojo-loading/http/tests/serviceworker/chromium/request-body-blob-crash-crash-log.txt 18b5e540 0134b3e2 base!base::debug::BreakDebugger+0x17 18b5eab0 0454df14 base!logging::LogMessage::~LogMessage+0x2e2 18b5eb74 0454e526 net!net::URLRequest::OnCallToDelegateComplete+0x84 18b5ecf4 11b49c84 net!net::URLRequest::Read+0x86 18b5eeb4 11b444aa content!content::ResourceLoader::ReadMore+0x134 18b5eec4 11b448b6 content!base::internal::FunctorTraits<void (__thiscall content::ResourceLoader::*)(bool),void>::Invoke<base::WeakPtr<content::ResourceLoader> const &,bool const &>+0x2a 18b5eedc 11b44a83 content!base::internal::InvokeHelper<1,void>::MakeItSo<void (__thiscall content::ResourceLoader::*const &)(bool),base::WeakPtr<content::ResourceLoader> const &,bool const &>+0x46 18b5eef0 11b4b2d4 content!base::internal::Invoker<base::internal::BindState<void (__thiscall content::ResourceLoader::*)(bool),base::WeakPtr<content::ResourceLoader>,bool>,void __cdecl(void)>::RunImpl<void (__thiscall content::ResourceLoader::*const &)(bool),std::tuple<base::WeakPtr<content::ResourceLoader>,bool> const &,0,1>+0x53 18b5ef0c 013041b4 content!base::internal::Invoker<base::internal::BindState<void (__thiscall content::ResourceLoader::*)(bool),base::WeakPtr<content::ResourceLoader>,bool>,void __cdecl(void)>::Run+0x24 18b5ef28 013043bf base!base::internal::RunMixin<base::Callback<void __cdecl(void),0,0> >::Run+0x44 18b5eff8 0137af02 base!base::debug::TaskAnnotator::RunTask+0x1df 18b5f200 01378f9c base!base::MessageLoop::RunTask+0x272 18b5f214 01379572 base!base::MessageLoop::DeferOrRunPendingTask+0x2c 18b5f2b4 01382cc1 base!base::MessageLoop::DoWork+0xf2 18b5f2c8 01383dab base!base::MessagePumpForIO::DoRunLoop+0x21 18b5f2fc 0137ac1e base!base::MessagePumpWin::Run+0x7b 18b5f53c 0142ecd6 base!base::MessageLoop::RunHandler+0x18e 18b5f61c 014ca211 base!base::RunLoop::Run+0xa6 18b5f7a0 114c2190 base!base::Thread::Run+0x111 18b5f86c 114c3bf9 content!content::BrowserThreadImpl::IOThreadRun+0x20 18b5fb54 014cb2af content!content::BrowserThreadImpl::Run+0x179 18b5ff64 014a63bc base!base::Thread::ThreadMain+0x35f 18b5ff88 775e338a base!base::PlatformThread::Sleep+0x17c WARNING: Stack unwind information not available. Following frames may be wrong. 18b5ff94 77e99902 kernel32!BaseThreadInitThunk+0x12 18b5ffd4 77e998d5 ntdll!RtlInitializeExceptionChain+0x63 18b5ffec 00000000 ntdll!RtlInitializeExceptionChain+0x36 quit:
,
Mar 21 2017
Bisecting.
,
Mar 21 2017
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4fede0f13bb7bd62971e98b966548953b56059aa commit 4fede0f13bb7bd62971e98b966548953b56059aa Author: yhirano <yhirano@chromium.org> Date: Tue Mar 21 03:37:45 2017 Revert of Allow MojoAsyncResourceHandler::OnWillRead to complete asyncronously (patchset #5 id:80001 of https://codereview.chromium.org/2738973002/ ) Reason for revert: This CL leads to a layout test crash. virtual/mojo-loading/http/tests/serviceworker/chromium/request-body-blob-crash.html Original issue's description: > when a Mojo buffer can't be allocated synchronously. > > The class still needs to create its own intermediary buffer > when the Mojo buffer is too small to meet the > MimeSniffingResourceHandler's needs, but once that's fixed, > the class can be made significantly simpler. > > BUG= 687240 > > Review-Url: https://codereview.chromium.org/2738973002 > Cr-Commit-Position: refs/heads/master@{#458093} > Committed: https://chromium.googlesource.com/chromium/src/+/2ba831790eccdf8fa9178eef72b8479a12a2f8aa TBR=rdsmith@chromium.org,mmenke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 687240 , 703471 Review-Url: https://codereview.chromium.org/2760223002 Cr-Commit-Position: refs/heads/master@{#458297} [modify] https://crrev.com/4fede0f13bb7bd62971e98b966548953b56059aa/content/browser/loader/mock_resource_loader.cc [modify] https://crrev.com/4fede0f13bb7bd62971e98b966548953b56059aa/content/browser/loader/mojo_async_resource_handler.cc [modify] https://crrev.com/4fede0f13bb7bd62971e98b966548953b56059aa/content/browser/loader/mojo_async_resource_handler.h [modify] https://crrev.com/4fede0f13bb7bd62971e98b966548953b56059aa/content/browser/loader/mojo_async_resource_handler_unittest.cc
,
Mar 21 2017
Thanks for the revert!
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6add17253a0318bb3360c33de735f1f0ab3b8cd2 commit 6add17253a0318bb3360c33de735f1f0ab3b8cd2 Author: mmenke <mmenke@chromium.org> Date: Tue Mar 21 21:31:17 2017 Reland of https://codereview.chromium.org/2738973002. It failed to mark a request as unblocked before resuming it. Unittests didn't catch this because they don't actually drive a URLRequest, which is where the failing DCHECK was. Reason for revert: This CL leads to a layout test crash. virtual/mojo-loading/http/tests/serviceworker/chromium/request-body-blob-crash.html Original issue's description: > Allow MojoAsyncResourceHandler::OnWillRead to complete asyncronously > when a Mojo buffer can't be allocated synchronously. > > The class still needs to create its own intermediary buffer > when the Mojo buffer is too small to meet the > MimeSniffingResourceHandler's needs, but once that's fixed, > the class can be made significantly simpler. > > BUG= 687240 > > Review-Url: https://codereview.chromium.org/2738973002 > Cr-Commit-Position: refs/heads/master@{#458093} > Committed: https://chromium.googlesource.com/chromium/src/+/2ba831790eccdf8fa9178eef72b8479a12a2f8aa TBR=rdsmith@chromium.org,mmenke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 687240 , 703471 Review-Url: https://codereview.chromium.org/2760223002 Cr-Commit-Position: refs/heads/master@{#458297} Committed: https://chromium.googlesource.com/chromium/src/+/4fede0f13bb7bd62971e98b966548953b56059aa Review-Url: https://codereview.chromium.org/2766733002 Cr-Commit-Position: refs/heads/master@{#458554} [modify] https://crrev.com/6add17253a0318bb3360c33de735f1f0ab3b8cd2/content/browser/loader/mock_resource_loader.cc [modify] https://crrev.com/6add17253a0318bb3360c33de735f1f0ab3b8cd2/content/browser/loader/mojo_async_resource_handler.cc [modify] https://crrev.com/6add17253a0318bb3360c33de735f1f0ab3b8cd2/content/browser/loader/mojo_async_resource_handler.h [modify] https://crrev.com/6add17253a0318bb3360c33de735f1f0ab3b8cd2/content/browser/loader/mojo_async_resource_handler_unittest.cc
,
Mar 22 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by horo@chromium.org
, Mar 21 2017