New issue
Advanced search Search tips

Issue 703467 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Expose timestamp metadata via selection/hover in viewer

Project Member Reported by iannucci@chromium.org, Mar 21 2017

Issue description

It would be really cool to add the following to the viewer:

  * selecting some text will show (maybe on a popup at the bottom of the screen) the timestamp of the line
  * selecting multiple lines will show the time delta between them

This could be done in the 'block mode' renderer by placing hidden elements in the output html block which map lines to their originating stream/index. Then when the selection changes a javascript event handler would parse the current beginning and ending selection, scan backwards in the dom to find the hidden index blocks, look up that info in the underlying stream data and display the relevant timestamp information.

It would be also handy to allow hover to show the timestamp too.
 

Comment 1 by estaab@chromium.org, Jun 21 2017

Status: Available (was: Untriaged)
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 21 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
Cc: -d...@chromium.org
Owner: hinoka@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/dcd50e3be5c4dcb95ed4d59804d2eb40d48f1eea

commit dcd50e3be5c4dcb95ed4d59804d2eb40d48f1eea
Author: Ryan Tseng <hinoka@google.com>
Date: Wed Sep 26 18:18:40 2018

[logdog] Add timestamps to log viewer

These are timestamps relative to the start of the log stream.

Also:
* Hover shows timestamp in the user's local time zone.
* Color highlights show up for lines that take more than 1s.
* Most JS/CSS files broken out into separate files (in the static service).

Bug:  703467 
Change-Id: I0857d757319b9f26fdafc5858f6365bf821c2fb4
Reviewed-on: https://chromium-review.googlesource.com/1238565
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/dcd50e3be5c4dcb95ed4d59804d2eb40d48f1eea/logdog/appengine/cmd/coordinator/default/dispatch.yaml
[modify] https://crrev.com/dcd50e3be5c4dcb95ed4d59804d2eb40d48f1eea/logdog/appengine/cmd/coordinator/static/module-static.yaml
[add] https://crrev.com/dcd50e3be5c4dcb95ed4d59804d2eb40d48f1eea/logdog/appengine/cmd/coordinator/static/static/css/viewer.css
[add] https://crrev.com/dcd50e3be5c4dcb95ed4d59804d2eb40d48f1eea/logdog/appengine/cmd/coordinator/static/static/js/time.js
[add] https://crrev.com/dcd50e3be5c4dcb95ed4d59804d2eb40d48f1eea/logdog/appengine/cmd/coordinator/static/static/js/viewer.js
[add] https://crrev.com/dcd50e3be5c4dcb95ed4d59804d2eb40d48f1eea/logdog/appengine/cmd/coordinator/static/static/third_party
[modify] https://crrev.com/dcd50e3be5c4dcb95ed4d59804d2eb40d48f1eea/logdog/appengine/coordinator/flex/logs/http.go
[add] https://crrev.com/dcd50e3be5c4dcb95ed4d59804d2eb40d48f1eea/logdog/appengine/coordinator/flex/logs/static

Status: Fixed (was: Started)
We now have this.

Sign in to add a comment