After the switch to WfSuspectedCL, waterfall/culprit list more than one build cycles for the same builder |
||
Issue descriptionUrl to the build Failure: https://luci-milo.appspot.com/buildbot/chromium.linux/Linux Builder (dbg)(32)/64735 What is the bug or feature: For the same failures on the same builder, we should only list the first failed cycle. Unrelated to this bug, only those with try-job analysis could be listed. If the result is just from Heuristic, we should not show them because it is the confirmed by try-job yet.
,
Mar 21 2017
This should be fixed as it impacts user-UI. If it is not clear yet, check the findit link in this code review. https://codereview.chromium.org/2751253002
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/99cac59e97d126f38c5c537091728b06483ef1ed commit 99cac59e97d126f38c5c537091728b06483ef1ed Author: Chan <chanli@chromium.org> Date: Tue Mar 21 23:10:09 2017 [Findit] When display failed builds in culprit page, only display the first failed build. And only display builds where Findit found culprit from try-job approach. Demo: https://chanli-dot-findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I0MzI1YTIwODcwOTQ2ZWRhZWNiZTE4ZDJhYjBlMmU5YzAxOTExYWEM BUG= 703464 Change-Id: I60f96802019e9f6640e2a9b2c4975e69f7a6b14f Reviewed-on: https://chromium-review.googlesource.com/457432 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/99cac59e97d126f38c5c537091728b06483ef1ed/appengine/findit/handlers/culprit.py [modify] https://crrev.com/99cac59e97d126f38c5c537091728b06483ef1ed/appengine/findit/handlers/test/culprit_test.py
,
Mar 21 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by st...@chromium.org
, Mar 21 2017