New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703446 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

webkit_tests http/tests/inspector/network/resource-priority.html is failing

Project Member Reported by horo@chromium.org, Mar 21 2017

Issue description

webkit_tests http/tests/inspector/network/resource-priority.html is failing

Builders failed on: 
- WebKit Win7 (dbg): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29


https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/9300
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7__dbg_/9300/layout-test-results/results.html

--- E:\b\rr\tmpbwr7kg\w\layout-test-results\http/tests/inspector/network/resource-priority-expected.txt
+++ E:\b\rr\tmpbwr7kg\w\layout-test-results\http/tests/inspector/network/resource-priority-actual.txt
@@ -1,4 +1,5 @@
 CONSOLE WARNING: line 22: Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.
+CONSOLE WARNING: The resource http://127.0.0.1:8000/inspector/network/resources/abe.png?precedingPreload was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it wasn't preloaded for nothing.
 Tests resource priorities.
 
 

 

Comment 1 by horo@chromium.org, Mar 21 2017

Labels: Pri-1

Comment 2 by horo@chromium.org, Mar 21 2017

Owner: pfeldman@chromium.org
pfeldman@
Could you please handle this?

Comment 3 by horo@chromium.org, Mar 21 2017

Owner: y...@yoav.ws
Status: Assigned (was: Available)
unusedPreloadsTimer is making the layouttests flaky.

yoav@
Could you please handle this?

Comment 4 by horo@chromium.org, Mar 21 2017

https://codereview.chromium.org/2753053004 introduced this falling test case.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9ba3360aa141410e5bbcaaf391cfe42f32819e6

commit c9ba3360aa141410e5bbcaaf391cfe42f32819e6
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Tue Mar 21 06:38:55 2017

Add resource-priority.html to TestExpectations

BUG= 703446 
TBR=csharrison@chromium.org

Review-Url: https://codereview.chromium.org/2768463002 .
Cr-Commit-Position: refs/heads/master@{#458329}

[modify] https://crrev.com/c9ba3360aa141410e5bbcaaf391cfe42f32819e6/third_party/WebKit/LayoutTests/TestExpectations

Comment 6 by y...@yoav.ws, Mar 21 2017

I'll take a look
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d8fbe34e1a68d526fda3b736ce006c42c30e21c

commit 6d8fbe34e1a68d526fda3b736ce006c42c30e21c
Author: yoav <yoav@yoav.ws>
Date: Tue Mar 21 09:10:36 2017

Fix priority test flakiness

A recently added priority test (added in https://codereview.chromium.org/2753053004 )
was preloading a resource but not using it,
which flakily triggered unused preload warnings.
This CL fixes that by using that preloaded resource.

BUG= 703446 

Review-Url: https://codereview.chromium.org/2767553002
Cr-Commit-Position: refs/heads/master@{#458355}

[modify] https://crrev.com/6d8fbe34e1a68d526fda3b736ce006c42c30e21c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6d8fbe34e1a68d526fda3b736ce006c42c30e21c/third_party/WebKit/LayoutTests/http/tests/inspector/network/resource-priority.html

Comment 8 by y...@yoav.ws, Mar 21 2017

Status: Fixed (was: Assigned)

Comment 9 by horo@chromium.org, Mar 22 2017

Labels: -Sheriff-Chromium

Sign in to add a comment