New issue
Advanced search Search tips

Issue 703441 link

Starred by 1 user
Status: Archived
Owner:
davidri...@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
som



Sign in to add a comment

som_alerts_dispatcher fails to dispatch logs if logdog annotation is missing stdoutStream.

Project Member Reported by davidri...@chromium.org, Mar 21 2017 
From https://luci-logdog.appspot.com/v/?s=chromeos%2Fbb%2Fchromeos%2Fmaster-paladin%2F14019%2F%2B%2Frecipes%2Fsteps%2FReport%2F0%2Fstdout 
17:40:27: INFO:   glados-cheets-android-pfq:2543 (id 1395840) fail
17:40:27: INFO:     stage SetupBoard (id 40610654): fail
som_alerts_dispatcher: Unhandled exception:
Traceback (most recent call last):
  File "/b/cbuild/internal_master/chromite/scripts/som_alerts_dispatcher", line 102, in <module>
    main()
  File "/b/cbuild/internal_master/chromite/scripts/som_alerts_dispatcher", line 40, in main
    wrapper.DoMain()
  File "/b/cbuild/internal_master/chromite/scripts/wrapper.py", line 164, in DoMain
    commandline.ScriptWrapperMain(FindTarget)
  File "/b/cbuild/internal_master/chromite/lib/commandline.py", line 834, in ScriptWrapperMain
    ret = target(argv[1:])
  File "/b/cbuild/internal_master/chromite/scripts/som_alerts_dispatcher.py", line 368, in main
    milo_client=milo_client)
  File "/b/cbuild/internal_master/chromite/scripts/som_alerts_dispatcher.py", line 329, in GenerateAlertsSummary
    logdog_client, milo_client)
  File "/b/cbuild/internal_master/chromite/scripts/som_alerts_dispatcher.py", line 250, in GenerateBuildAlert
    logdog_client)
  File "/b/cbuild/internal_master/chromite/scripts/som_alerts_dispatcher.py", line 141, in GenerateAlertStage
    if annotation['stdoutStream'] and annotation['stdoutStream']['name']:
KeyError: 'stdoutStream'
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/1cbf3ab6d62a07cc841542de62154100a03c586a

commit 1cbf3ab6d62a07cc841542de62154100a03c586a
Author: David Riley <davidriley@chromium.org>
Date: Tue Mar 21 06:12:03 2017

som_alerts_dispatcher: Handle builds missing stdoutStream.

If a build is aborted at the right time, the logdog annotations
might be missing the stdout stream and would cause Sheriff-o-Matic
to fail.

BUG= chromium:703441 
TEST=som_alerts_dispatcher CREDS 1395834,1000

Change-Id: Ib10845bae058d038b15eefca322caa866cd38400
Reviewed-on: https://chromium-review.googlesource.com/457174
Commit-Ready: David Riley <davidriley@chromium.org>
Tested-by: David Riley <davidriley@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/1cbf3ab6d62a07cc841542de62154100a03c586a/scripts/som_alerts_dispatcher.py

Comment 2 by davidri...@chromium.org, Mar 21 2017

Status: Fixed (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/734e5ee3426a4a4f1f5f0e1fb0a893c97202380d

commit 734e5ee3426a4a4f1f5f0e1fb0a893c97202380d
Author: avayvod <avayvod@chromium.org>
Date: Wed Apr 19 19:46:47 2017

Added Stable studies to BackgroundVideoOptimizations experiment

BUG=678663, 703441 

Review-Url: https://codereview.chromium.org/2819273005
Cr-Commit-Position: refs/heads/master@{#465714}

[modify] https://crrev.com/734e5ee3426a4a4f1f5f0e1fb0a893c97202380d/testing/variations/fieldtrial_testing_config.json
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd8a42eb0b92d101bd2ac1d7889fdb8500b8474c

commit cd8a42eb0b92d101bd2ac1d7889fdb8500b8474c
Author: avayvod <avayvod@chromium.org>
Date: Mon Apr 24 22:07:40 2017

Update the background video optimization studies according to the new Finch config.

BUG=678663, 703441 

Review-Url: https://codereview.chromium.org/2835723002
Cr-Commit-Position: refs/heads/master@{#466788}

[modify] https://crrev.com/cd8a42eb0b92d101bd2ac1d7889fdb8500b8474c/testing/variations/fieldtrial_testing_config.json

Comment 5 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment