New issue
Advanced search Search tips

Issue 703439 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

content_browsertests (ServiceWorkerNavigationPreloadTest.NetworkError) is failing

Project Member Reported by horo@chromium.org, Mar 21 2017

Issue description

content_browsertests failing on chromium.win/Win7 Tests (dbg)(1)

Builders failed on: 
- Win7 Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29



ServiceWorkerNavigationPreloadTest.NetworkError (run #1):
[ RUN      ] ServiceWorkerNavigationPreloadTest.NetworkError
[3848:2816:0320/173443.616:11314736:INFO:media_foundation_video_encode_accelerator_win.cc(329)] Windows versions earlier than 8 are not supported.
[3848:2816:0320/173443.617:11314736:INFO:media_foundation_video_encode_accelerator_win.cc(329)] Windows versions earlier than 8 are not supported.
[4044:4944:0320/173446.090:11317217:FATAL:resource_dispatcher_host_impl.cc(586)] Check failed: loader->GetRequestInfo()->IsDownload() || loader->GetRequestInfo()->is_stream() || (loader->GetRequestInfo()->detachable_handler() && loader->GetRequestInfo()->detachable_handler()->is_detached()) || loader->GetRequestInfo()->requester_info()->IsBrowserSideNavigation() || loader->is_transferring().
Backtrace:
	base::debug::StackTrace::StackTrace [0x023BD937+55]
	base::debug::StackTrace::StackTrace [0x023BD4D1+17]
	logging::LogMessage::~LogMessage [0x0240B0FB+59]
	content::ResourceDispatcherHostImpl::CancelRequestsForContext [0x0B645E5C+1564]
	content::ResourceContext::~ResourceContext [0x0BA37E09+41]
	content::ShellBrowserContext::ShellResourceContext::~ShellResourceContext [0x014F40F9+25]
	content::ShellBrowserContext::ShellResourceContext::`scalar deleting destructor' [0x014F43CF+15]
	base::DeleteHelper<content::ShellBrowserContext::ShellResourceContext>::DoDelete [0x014F47A6+38]
	base::internal::FunctorTraits<void (__cdecl*)(void const *),void>::Invoke<void const * const &> [0x024F0935+21]
	base::internal::InvokeHelper<0,void>::MakeItSo<void (__cdecl*const &)(void const *),void const * const &> [0x024F0994+36]
	base::internal::Invoker<base::internal::BindState<void (__cdecl*)(void const *),void const *>,void __cdecl(void)>::RunImpl<void (__cdecl*const &)(void const *),std::tuple<void const *> const &,0> [0x024F09E4+52]
	base::internal::Invoker<base::internal::BindState<void (__cdecl*)(void const *),void const *>,void __cdecl(void)>::Run [0x024F0CC4+36]
	base::internal::RunMixin<base::Callback<void __cdecl(void),0,0> >::Run [0x023C4174+68]
	base::debug::TaskAnnotator::RunTask [0x023C437F+479]
	base::MessageLoop::RunTask [0x0243AEC2+626]
	base::MessageLoop::DeferOrRunPendingTask [0x02438F5C+44]
	base::MessageLoop::DoWork [0x02439532+242]
	base::MessagePumpForIO::DoRunLoop [0x02442C81+33]
	base::MessagePumpWin::Run [0x02443D6B+123]
	base::MessageLoop::RunHandler [0x0243ABDE+398]
	base::RunLoop::Run [0x024EEC96+166]
	base::Thread::Run [0x0258A2D1+273]
	content::BrowserThreadImpl::IOThreadRun [0x0AFE7080+32]
	content::BrowserThreadImpl::Run [0x0AFE8AE9+377]
	base::Thread::ThreadMain [0x0258B36F+863]
	base::PlatformThread::Sleep [0x0256647C+380]
	BaseThreadInitThunk [0x76E2337A+18]
	RtlInitializeExceptionChain [0x77809882+99]
	RtlInitializeExceptionChain [0x77809855+54]



 

Comment 1 by horo@chromium.org, Mar 21 2017

Labels: Pri-1

Comment 2 by horo@chromium.org, Mar 21 2017

Owner: horo@chromium.org
Status: Assigned (was: Available)

Comment 4 by jam@chromium.org, Mar 21 2017

looking
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a787e3a33d497008aab7661b3adab4fc4feed7b

commit 6a787e3a33d497008aab7661b3adab4fc4feed7b
Author: horo <horo@chromium.org>
Date: Tue Mar 21 04:01:52 2017

Revert of Fix race condition in content_shell which could lead to an assert on shutdown with PlzNavigate. (patchset #1 id:1 of https://codereview.chromium.org/2764613002/ )

Reason for revert:
Introduced ServiceWorkerNavigationPreloadTest.NetworkError crashes on Debug build.

BUG= 703439 

Original issue's description:
> Fix race condition in content_shell which could lead to an assert on shutdown with PlzNavigate.
>
> The problem is that URLRequestContext's destructor checks that there are no more outstanding requests, while ResourceContext's destructor is what removes outstanding requests. In Chrome's profile implementation, the order is correct, but content_shell had a bug. This only mattered with PlzNavigate because renderer requests are deleted earlier through other codepaths.
>
> This should fix the flakiness seen on the Marshmallow 64 bit Tester with PlzNavigate.
>
> BUG= 673806 
>
> Review-Url: https://codereview.chromium.org/2764613002
> Cr-Commit-Position: refs/heads/master@{#458216}
> Committed: https://chromium.googlesource.com/chromium/src/+/18bf53b4ccb6351759ca4a0bdc30a814aeb61137

TBR=avi@chromium.org,jam@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 673806 

Review-Url: https://codereview.chromium.org/2761223002
Cr-Commit-Position: refs/heads/master@{#458307}

[modify] https://crrev.com/6a787e3a33d497008aab7661b3adab4fc4feed7b/content/shell/browser/shell_browser_context.cc

Comment 6 by horo@chromium.org, Mar 21 2017

Status: Fixed (was: Assigned)

Sign in to add a comment