Eliminate falco from the PFQ |
|||||||
Issue descriptionFalco and peppy are both amd64 / slippy / Haswell devices Falco HWTests have been super flaky recently to the point where they are being (at least temporarily) disabled: https://chromium-review.googlesource.com/c/457438/ Peppy does not run HWTests We should get rid of one and address the HWTest issues for the other. I assume that since we actually have falco hardware in the lab we should keep falco, try to address the HW test issues, and deprecate peppy? Alternately we could deprecate both and bring up another slippy board.
,
Mar 21 2017
Yup, there's already sufficient allocation for testing peppy in the Chrome PFQ. So, it should be sufficient just to turn on the testing in the builder.
,
Mar 21 2017
If there is some goofy need that we've missed, binhost test should tell us.
,
Mar 21 2017
Can someone point me to where / how we configure which builders run HW tests? I thought we did that explicitly but it looks like maybe we are determining that based on available DUTs? Is there a pool allocation we need to adjust somewhere?
,
Mar 21 2017
Which tests to run on which builder is explicitly controlled in chromeos_config.py. The exception is that we disable hwtests on tryjobs unless the --hwtests argument is used when requesting the tryjob. However, we manually try to make sure there are enough DUTs are available, and manually adjust pool sizes as needed.
,
Mar 21 2017
> However, we manually try to make sure there are enough > DUTs are available, and manually adjust pool sizes as needed. Note that in this case, we've already determined that there are enough peppy DUTs; it's noted in c#2. So, all that's needed at this point is a Chromite CL to move testing from falco to peppy. Once that's done, we can also reduce the falco pool size.
,
Mar 21 2017
Ah, I figured it out. I was confused because we just recently eliminated HWTests for falco since they have been failing so frequently.
This is the code I was looking for:
'peppy-chrome-pfq': {
'hw_tests': hw_test_list.SharedPoolPFQ(),
},
,
Mar 21 2017
,
Mar 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/882b21342ccb8bdf899b6f41c3f760b06c452360 commit 882b21342ccb8bdf899b6f41c3f760b06c452360 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Mar 22 16:26:45 2017 chromeos_config.py: Remove falco from pfq_important Also adds hw_tests for peppy. BUG= chromium:703435 TEST=cbuildbot/chromeos_config_unittest,cbuildbot/binhost_test Change-Id: I1b11474c7c81a867eaa86b4fa401828f96bfffc6 Reviewed-on: https://chromium-review.googlesource.com/457623 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Tested-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/882b21342ccb8bdf899b6f41c3f760b06c452360/cbuildbot/config_dump.json [modify] https://crrev.com/882b21342ccb8bdf899b6f41c3f760b06c452360/cbuildbot/waterfall_layout_dump.txt [modify] https://crrev.com/882b21342ccb8bdf899b6f41c3f760b06c452360/cbuildbot/prebuilts_unittest.py [modify] https://crrev.com/882b21342ccb8bdf899b6f41c3f760b06c452360/cbuildbot/chromeos_config.py
,
Mar 22 2017
,
Mar 22 2017
,
May 30 2017
,
Aug 1 2017
,
Aug 3 2017
Closing. Please reopen it if its not fixed. Thanks! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ihf@chromium.org
, Mar 21 2017