New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703432 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Label wrapping in the Chrome context menu

Project Member Reported by sbirch@chromium.org, Mar 21 2017

Issue description

In adding some new items to the context menu in CCT, Lei (cc'd) found that we can use a maximum of ~29 characters on one line. We currently have some items in the menu which are longer than that, which would be truncated with an ellipsis today (e.g. "Open in incognito tab" is 36 chars in French.)

Shimi (cc'd) suggested that we simply wrap them to a second line if needed rather than truncating. (Of course we should also strive to make our menu items short, but it's much more sensible in the worst case.) Seemed like we might want to consider that for the new context menu.
 

Comment 1 by jwanda@chromium.org, Mar 21 2017

We already have c: In fact here is a screenshot of it with logn strings.
superLongStrings.png
445 KB View Download

Comment 2 by jwanda@chromium.org, Mar 21 2017

Status: Fixed (was: Available)
Also make sure you patch recently. We just got rid of chrome_context_menu.xml and probably would mess up anything for the moment. If you need more info on methodology and how we can possibly improve it please do! But in short we've moved everything to ContextMenuItem.java & ids.xml

Comment 3 by sbirch@chromium.org, Mar 21 2017

Oh awesome, thanks!

Sign in to add a comment