New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 703431 link

Starred by 1 user
Status: Archived
Owner:
█ chingcodes@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
akes...@chromium.org
█ pho...@chromium.org
█ jinjingl@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

emerge datastore entities should be more consistent

Project Member Reported by davidri...@chromium.org, Mar 21 2017 
There's a lack of consistency between the EmergePackage and suite details.

package -> name
end_time -> finish_time
status = pass|fail
try = 1|2|...

Also, I think we should make all of the entities have the same Kind.  It allows a single query to get all the results and be cleanly rendered on a single timeline, with entries sharing the same name being rendered on the same line.  task_name might be a good choice that we're using for HQEs already to distinguish between building or download or whatever the different types of steps are.

Also, let's enable this for all the other build stages.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/583e25be2662fb8247fffbdbb319879c9d01bf41

commit 583e25be2662fb8247fffbdbb319879c9d01bf41
Author: Chris Ching <chingcodes@chromium.org>
Date: Tue Mar 28 10:47:44 2017

change Event entities to be consistent with CIDB

"package" -> "name"
"end_time" -> "finish_time"
"status" = "pass"|"fail"

BUG= chromium:703431 
TEST=cros_event_unittest

Change-Id: I6e5bf843b88c1feb9406fbe2b309087e6d21beab
Reviewed-on: https://chromium-review.googlesource.com/459678
Commit-Ready: Chris Ching <chingcodes@chromium.org>
Tested-by: Chris Ching <chingcodes@chromium.org>
Reviewed-by: David Riley <davidriley@chromium.org>

[modify] https://crrev.com/583e25be2662fb8247fffbdbb319879c9d01bf41/lib/cros_event.py
[modify] https://crrev.com/583e25be2662fb8247fffbdbb319879c9d01bf41/scripts/parallel_emerge.py
[modify] https://crrev.com/583e25be2662fb8247fffbdbb319879c9d01bf41/lib/cros_event_unittest.py

Comment 2 by davidri...@chromium.org, Mar 29 2017 

This still is missing try and should be differentiating between the different potential steps for the package.
Project Member

Comment 3 by bugdroid1@chromium.org, May 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/4a2ebd6d3e54689c2c27bda7e12a72d7bb04440d

commit 4a2ebd6d3e54689c2c27bda7e12a72d7bb04440d
Author: Chris Ching <chingcodes@chromium.org>
Date: Wed May 03 17:38:26 2017

parallel_emerge: events use single kind

All events use 'ParallelEmerge' for their kind. Previously used kinds
are now stored as 'task_name'

BUG= chromium:703431 
TEST=none

Change-Id: I23141c270d157bea42a37f72b026b5cb33881ba3
Reviewed-on: https://chromium-review.googlesource.com/487911
Commit-Ready: Chris Ching <chingcodes@chromium.org>
Tested-by: Chris Ching <chingcodes@chromium.org>
Reviewed-by: David Riley <davidriley@chromium.org>

[modify] https://crrev.com/4a2ebd6d3e54689c2c27bda7e12a72d7bb04440d/scripts/parallel_emerge.py
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b8eba81c5b5def521fe2b5496e4869cb5b9ea819

commit b8eba81c5b5def521fe2b5496e4869cb5b9ea819
Author: Chris Ching <chingcodes@chromium.org>
Date: Fri Jun 23 00:03:56 2017

parallel_emerge: Package names now split on catagory/package/version

BUG= chromium:703431 
TEST=importing parallel_emerge

Change-Id: Idb312775957c5e3852ff6d9b1acdaa4b0b0076c9
Reviewed-on: https://chromium-review.googlesource.com/462063
Commit-Ready: Chris Ching <chingcodes@chromium.org>
Tested-by: Chris Ching <chingcodes@chromium.org>
Reviewed-by: David Riley <davidriley@chromium.org>

[modify] https://crrev.com/b8eba81c5b5def521fe2b5496e4869cb5b9ea819/scripts/parallel_emerge.py
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/73486ab16d6cc533224e69bdaad95da05b853b94

commit 73486ab16d6cc533224e69bdaad95da05b853b94
Author: Chris Ching <chingcodes@chromium.org>
Date: Tue Jun 27 17:55:48 2017

parallel_emerge: add try_count field to emerge events

BUG= chromium:703431 
TEST=none

Change-Id: Ied20176a6c294b430d29c6aa8df42c8a6726f995
Reviewed-on: https://chromium-review.googlesource.com/487872
Commit-Ready: Chris Ching <chingcodes@chromium.org>
Tested-by: Chris Ching <chingcodes@chromium.org>
Reviewed-by: David Riley <davidriley@chromium.org>

[modify] https://crrev.com/73486ab16d6cc533224e69bdaad95da05b853b94/scripts/parallel_emerge.py

Comment 6 by chingcodes@chromium.org, Jun 29 2017

Status: Fixed (was: Untriaged)

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment