New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703426 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Add MobileContextMenu user actions to CCT context menu

Project Member Reported by sbirch@chromium.org, Mar 21 2017

Issue description

The existing actions we should replicate are:
1) MobileContextMenuOpenLinkInNewTab
2) MobileContextMenuOpenLinkInIncognito

After thinking about it a little more I don't think it's really worth distinguishing "Open in $browser" from "Open in Chrome." I think we can just log MobileContextMenuOpenLinkInNewTab in both cases.
 

Comment 1 by sbirch@chromium.org, Mar 21 2017

One addition: we should probably also increment the appropriate histogram buckets in ContextMenu.SelectedOption.Link --

1) "Open in new tab"
2) "Open in incognito tab"

Comment 2 by sbirch@chromium.org, Mar 21 2017

Turns out MobileContextMenuOpenLinkInNewTab was deprecated in https://chromium.googlesource.com/chromium/src/+/a4cb4af3543c3fdd6a6bcc4803c2d1a44ce79acb%5E%21/tools/metrics/actions/actions.xml

Lei is adding new buckets for each new case to ContextMenu.SelectedOption.Link.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8860857f5aa2a2a358c31c1122eccca7188faf9

commit d8860857f5aa2a2a358c31c1122eccca7188faf9
Author: ltian <ltian@chromium.org>
Date: Thu Mar 23 19:29:51 2017

[Android] Record user actions of new context menus for CCT

Add the logic to record user actions for the newly added context
menus ("Open in new Chrome tab", "Open in Chrome incognito tab",
"Open in browser") for CCT. Also record the user action of "Open in
Chrome" for Fullscreen mode.

Change the title from "Open in Chrome incognito tab" to "Open in
incognito tab" since the translation for the former one needs too much
characters to show on the small screen devices.

BUG= 703426 

Review-Url: https://codereview.chromium.org/2767703002
Cr-Commit-Position: refs/heads/master@{#459178}

[modify] https://crrev.com/d8860857f5aa2a2a358c31c1122eccca7188faf9/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
[modify] https://crrev.com/d8860857f5aa2a2a358c31c1122eccca7188faf9/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/d8860857f5aa2a2a358c31c1122eccca7188faf9/tools/metrics/histograms/histograms.xml

Comment 4 by ltian@chromium.org, Mar 23 2017

Labels: Merge-Request-58
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 23 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 32 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by sbirch@chromium.org, Mar 23 2017

Cc: amineer@chromium.org
+amineer

Alex, for context on the .grd change -- we found out during initial translation that the string we were planning to use was too long in a few languages. We circled back to UI review and decided to drop "Chrome."

(This merge also updates a histogram that UI reviewers asked us to monitor.)
Labels: -Merge-Review-58 Merge-Approved-58
Approved for M58 branch 3029, we still have time to take the string change.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 27 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40f4a7c18ed0ca2b713c273c612b713d9f7f1c4f

commit 40f4a7c18ed0ca2b713c273c612b713d9f7f1c4f
Author: ltian <ltian@chromium.org>
Date: Mon Mar 27 17:50:06 2017

[Android] Record user actions of new context menus for CCT

Add the logic to record user actions for the newly added context
menus ("Open in new Chrome tab", "Open in Chrome incognito tab",
"Open in browser") for CCT. Also record the user action of "Open in
Chrome" for Fullscreen mode.

Change the title from "Open in Chrome incognito tab" to "Open in
incognito tab" since the translation for the former one needs too much
characters to show on the small screen devices.

BUG= 703426 
NOTRY=true
NOPRESUBMIT=true

Original-Review-Url: https://codereview.chromium.org/2767703002
Original-Cr-Commit-Position: refs/heads/master@{#459178}
(cherry picked from commit d8860857f5aa2a2a358c31c1122eccca7188faf9)

Review-Url: https://codereview.chromium.org/2771283002
Cr-Commit-Position: refs/branch-heads/3029@{#428}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/40f4a7c18ed0ca2b713c273c612b713d9f7f1c4f/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
[modify] https://crrev.com/40f4a7c18ed0ca2b713c273c612b713d9f7f1c4f/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/40f4a7c18ed0ca2b713c273c612b713d9f7f1c4f/tools/metrics/histograms/histograms.xml

Comment 9 by ltian@chromium.org, Mar 27 2017

Status: Fixed (was: Assigned)

Sign in to add a comment