New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703409 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Move getNavigationType logic from PerformanceBase to PerformanceNavigationTiming.

Project Member Reported by sunjian@chromium.org, Mar 20 2017

Issue description

Move getNavigationType logic from PerformanceBase to PerformanceNavigationTiming.

Currently, the type() method in PerformanceNavigationTiming will call PerformanceBase::getNavigationType(). Since PNT is the only caller of this method. It makes more sense to merge this logic into PNT.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d663f46bd1cef7b00e9a52b5148af16014ec652

commit 5d663f46bd1cef7b00e9a52b5148af16014ec652
Author: sunjian <sunjian@chromium.org>
Date: Thu Mar 30 21:05:28 2017

Move getNavigationType logic from PerformanceBase to PerformanceNavigationTiming.

Currently, the type() method in PerformanceNavigationTiming will call
PerformanceBase::getNavigationType(). Since PNT is the only caller of
this method. It makes more sense to merge this logic into PNT.

BUG= 703409 

Review-Url: https://codereview.chromium.org/2761113002
Cr-Commit-Position: refs/heads/master@{#460873}

[modify] https://crrev.com/5d663f46bd1cef7b00e9a52b5148af16014ec652/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/5d663f46bd1cef7b00e9a52b5148af16014ec652/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
[modify] https://crrev.com/5d663f46bd1cef7b00e9a52b5148af16014ec652/third_party/WebKit/Source/core/timing/PerformanceBase.h
[modify] https://crrev.com/5d663f46bd1cef7b00e9a52b5148af16014ec652/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
[modify] https://crrev.com/5d663f46bd1cef7b00e9a52b5148af16014ec652/third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.cpp
[modify] https://crrev.com/5d663f46bd1cef7b00e9a52b5148af16014ec652/third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.h
[add] https://crrev.com/5d663f46bd1cef7b00e9a52b5148af16014ec652/third_party/WebKit/Source/core/timing/PerformanceNavigationTimingTest.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment