Remove dependency of WebLocalFrame on modules/ |
||
Issue descriptionE.g. move WebLocalFrame AppBanner methods to AppBanner controller in modules/.
,
Mar 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94c0ec2f5e66cf6939523e14cf4db4d3267d1ef1 commit 94c0ec2f5e66cf6939523e14cf4db4d3267d1ef1 Author: slangley <slangley@chromium.org> Date: Thu Mar 30 07:02:48 2017 Move registration of LocalFrame mojo interfaces to ModulesInitializer. To enable this, added a method to register initilization callbacks for LocalFrame initization. This method adds the callbacks to a static vector, and the callbacks are executed when a new LocalFrame is initizialized. This is part of the work to remove the dependency between WebLocalFrameImpl and modules/*. BUG= 703405 Review-Url: https://codereview.chromium.org/2783543004 Cr-Commit-Position: refs/heads/master@{#460684} [modify] https://crrev.com/94c0ec2f5e66cf6939523e14cf4db4d3267d1ef1/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/94c0ec2f5e66cf6939523e14cf4db4d3267d1ef1/third_party/WebKit/Source/core/frame/LocalFrame.h [modify] https://crrev.com/94c0ec2f5e66cf6939523e14cf4db4d3267d1ef1/third_party/WebKit/Source/modules/ModulesInitializer.cpp [modify] https://crrev.com/94c0ec2f5e66cf6939523e14cf4db4d3267d1ef1/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
,
Mar 30 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Mar 27 2017