New issue
Advanced search Search tips

Issue 703405 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove dependency of WebLocalFrame on modules/

Project Member Reported by slangley@chromium.org, Mar 20 2017

Issue description

E.g. move WebLocalFrame AppBanner methods to AppBanner controller in modules/.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96d533dcfc175886ce842d1fc5c4e0ea7f26e0a6

commit 96d533dcfc175886ce842d1fc5c4e0ea7f26e0a6
Author: slangley <slangley@chromium.org>
Date: Mon Mar 27 23:35:52 2017

Use ScreenOrientationController and not the implementation to break modules/ dep.

WebLocalFrameImpl was using ScreenOrientationControllerImpl as the method
notifyOrientationChanged was not defined in ScreenOrientationController. By
making this method pure virtual in ScreenOrientationController we no longer
need to pull in ScreenOrientationControllerImpl from modules but can now use the
base class defined in core/frame/.

BUG= 703405 

Review-Url: https://codereview.chromium.org/2779523002
Cr-Commit-Position: refs/heads/master@{#459935}

[modify] https://crrev.com/96d533dcfc175886ce842d1fc5c4e0ea7f26e0a6/third_party/WebKit/Source/core/frame/ScreenOrientationController.h
[modify] https://crrev.com/96d533dcfc175886ce842d1fc5c4e0ea7f26e0a6/third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp
[modify] https://crrev.com/96d533dcfc175886ce842d1fc5c4e0ea7f26e0a6/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h
[modify] https://crrev.com/96d533dcfc175886ce842d1fc5c4e0ea7f26e0a6/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94c0ec2f5e66cf6939523e14cf4db4d3267d1ef1

commit 94c0ec2f5e66cf6939523e14cf4db4d3267d1ef1
Author: slangley <slangley@chromium.org>
Date: Thu Mar 30 07:02:48 2017

Move registration of LocalFrame mojo interfaces to ModulesInitializer.

To enable this, added a method to register initilization callbacks for
LocalFrame initization. This method adds the callbacks to a static vector, and
the callbacks are executed when a new LocalFrame is initizialized.

This is part of the work to remove the dependency between WebLocalFrameImpl and
modules/*.

BUG= 703405 

Review-Url: https://codereview.chromium.org/2783543004
Cr-Commit-Position: refs/heads/master@{#460684}

[modify] https://crrev.com/94c0ec2f5e66cf6939523e14cf4db4d3267d1ef1/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/94c0ec2f5e66cf6939523e14cf4db4d3267d1ef1/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/94c0ec2f5e66cf6939523e14cf4db4d3267d1ef1/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/94c0ec2f5e66cf6939523e14cf4db4d3267d1ef1/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment