New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 703404 link

Starred by 2 users
Status: Fixed
Owner:
tommycli@chromium.org
Closed: Mar 2017
Cc:
█ ericde@chromium.org
lafo...@chromium.org
█ groby@chromium.org
█ rsch...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Plugin Power Saver: Treat 0x0 (unknown) size plugins as tiny

Project Member Reported by tommycli@chromium.org, Mar 20 2017 
We treat 0x0 plugins as essential.

This is a holdover choice from early PPS days that we made for two reasons:

 - Blink used to be buggy and provide wrong sizing data or erroneous 0x0.
 - We wanted to be conservative and not break too much content.

Now Blink's sizing bugs have been fixed (it seems), so we can get correctly treat these 0x0 plugins as tiny.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5fe8f12bcaf5b03b0bdbf5afb735b050ad6dd5b

commit f5fe8f12bcaf5b03b0bdbf5afb735b050ad6dd5b
Author: tommycli <tommycli@chromium.org>
Date: Tue Mar 21 17:28:32 2017

Plugin Power Saver Tiny: Treat completely obscured plugins as Tiny.

Previously we can considered 0x0 (completely obscured) plugins as
essential, out of an abundance of caution.

Now we are marking these as Tiny.

BUG= 703404 

Review-Url: https://codereview.chromium.org/2765633002
Cr-Commit-Position: refs/heads/master@{#458455}

[modify] https://crrev.com/f5fe8f12bcaf5b03b0bdbf5afb735b050ad6dd5b/chrome/browser/plugins/plugin_power_saver_browsertest.cc
[modify] https://crrev.com/f5fe8f12bcaf5b03b0bdbf5afb735b050ad6dd5b/chrome/test/data/plugin_power_saver/block_tiny_plugins.html
[modify] https://crrev.com/f5fe8f12bcaf5b03b0bdbf5afb735b050ad6dd5b/components/plugins/renderer/loadable_plugin_placeholder.cc
[modify] https://crrev.com/f5fe8f12bcaf5b03b0bdbf5afb735b050ad6dd5b/content/public/renderer/render_frame.h
[modify] https://crrev.com/f5fe8f12bcaf5b03b0bdbf5afb735b050ad6dd5b/content/renderer/pepper/plugin_instance_throttler_impl.cc
[modify] https://crrev.com/f5fe8f12bcaf5b03b0bdbf5afb735b050ad6dd5b/content/renderer/pepper/plugin_power_saver_helper.cc
[modify] https://crrev.com/f5fe8f12bcaf5b03b0bdbf5afb735b050ad6dd5b/content/renderer/peripheral_content_heuristic.cc
[modify] https://crrev.com/f5fe8f12bcaf5b03b0bdbf5afb735b050ad6dd5b/content/renderer/peripheral_content_heuristic_unittest.cc

Comment 2 by tommycli@chromium.org, Mar 23 2017

Status: Fixed (was: Started)
►

Sign in to add a comment