New issue
Advanced search Search tips

Issue 703381 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Remoting Android] Crash on ToT build due to unexpected call to fetchAuthToken()

Project Member Reported by yuweih@chromium.org, Mar 20 2017

Issue description

After a recent refactoring, fetchAuthToken() will be called immediately once the app is launch and before the user account is set, which breaks its presumption and crashes the app.
 

Comment 1 by yuweih@chromium.org, Mar 21 2017

Summary: [Remoting Android] Crash on ToT build due to unexpected call to fetchAuthToken() (was: [Remoting Android] Crash on ToT build due to call to unexpected call to fetchAuthToken())
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ced631a3b4de3fd68d98ecc1620d76b47a5ea9b2

commit ced631a3b4de3fd68d98ecc1620d76b47a5ea9b2
Author: yuweih <yuweih@chromium.org>
Date: Tue Mar 21 19:41:47 2017

[Remoting Android] Fix crash caused by fetchAuthToken()

Previously auth token was only fetched after the account switcher set the
account. A recent refactoring makes the app attempt to fetch the auth token
even before the account is set, so the fetchAuthToken() function just throws
an exception and crashes the app.

Since we are pretty sure that the Java code will soon feed the logger with the
auth code once the account is set, it's safe to fix this by loosening the check
to just a warning log.

Alternatively we can remove the immediate RequestAuthTokenForLogger() call from
ChromotingClientRuntime and make the logger request the auth token before it
tries to send out the logs. It depends on how the iOS client wants to provide
the auth token.

BUG= 703381 

Review-Url: https://codereview.chromium.org/2761983002
Cr-Commit-Position: refs/heads/master@{#458515}

[modify] https://crrev.com/ced631a3b4de3fd68d98ecc1620d76b47a5ea9b2/remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 21 2017

Labels: merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7fbced0ca231b04700c3629efcbba3fa842a837

commit d7fbced0ca231b04700c3629efcbba3fa842a837
Author: Yuwei Huang <yuweih@chromium.org>
Date: Tue Mar 21 21:01:04 2017

[Remoting Android] Fix crash caused by fetchAuthToken()

Previously auth token was only fetched after the account switcher set the
account. A recent refactoring makes the app attempt to fetch the auth token
even before the account is set, so the fetchAuthToken() function just throws
an exception and crashes the app.

Since we are pretty sure that the Java code will soon feed the logger with the
auth code once the account is set, it's safe to fix this by loosening the check
to just a warning log.

Alternatively we can remove the immediate RequestAuthTokenForLogger() call from
ChromotingClientRuntime and make the logger request the auth token before it
tries to send out the logs. It depends on how the iOS client wants to provide
the auth token.

BUG= 703381 

Review-Url: https://codereview.chromium.org/2761983002
Cr-Commit-Position: refs/heads/master@{#458515}
(cherry picked from commit ced631a3b4de3fd68d98ecc1620d76b47a5ea9b2)

Review-Url: https://codereview.chromium.org/2760373003 .
Cr-Commit-Position: refs/branch-heads/3029@{#341}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/d7fbced0ca231b04700c3629efcbba3fa842a837/remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java

Comment 4 by yuweih@chromium.org, Mar 21 2017

Labels: -merge-merged-3029
Sorry... I just attempted to merge the wrong CL into M58...
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 21 2017

Labels: merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a5b50e1823f3b922f94272001e81cb959d3b351

commit 1a5b50e1823f3b922f94272001e81cb959d3b351
Author: Yuwei Huang <yuweih@chromium.org>
Date: Tue Mar 21 21:41:39 2017

Revert "[Remoting Android] Fix crash caused by fetchAuthToken()"

This reverts commit d7fbced0ca231b04700c3629efcbba3fa842a837.

Accidentally merged this CL into M58. Reverting it.

R=jamiewalch@chromium.org
BUG= 703381 

Review-Url: https://codereview.chromium.org/2765073002 .
Cr-Commit-Position: refs/branch-heads/3029@{#345}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/1a5b50e1823f3b922f94272001e81cb959d3b351/remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java

Comment 6 by yuweih@chromium.org, Mar 21 2017

Labels: -merge-merged-3029

Comment 7 by yuweih@chromium.org, May 26 2017

Status: Fixed (was: Started)

Sign in to add a comment