New issue
Advanced search Search tips

Issue 703378 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-XR



Sign in to add a comment

Image tearing on try.matterport.com

Project Member Reported by dbbrooks@chromium.org, Mar 20 2017

Issue description

Chrome Version: 58.0.3029.28
OS: Android N
Device: Pixel, Pixel XL
VR Services: 1.3.149854881

When you move your head around, the image seems to tear or split. This does not happen in M57 (57.0.2987.117) so it seems to be a new regression.

What steps will reproduce the problem?
Start with Daydream as the default headset
(1) go to https://try.matterport.com/virtual-reality/webvr/ and scroll down to select the Hawaiian Oceanside Villa
(2) Select the vr icon in the bottom right hand corner and follow DON flow prompts

What is the expected result? head movement happens without distortion to the image

What happens instead? The image seems to tear or split in a couple places briefly when you move your head around.

 
Cc: klausw@chromium.org
Labels: M58
Does this repro in M59?
M59 is doing something much worse. The image tears from the center and smears the content around with movement. Its a bit hard to describe. Here's a couple screenshots.
Screenshot_20170321-090412 (1).png
2.0 MB View Download
Screenshot_20170321-091319 (1).png
2.7 MB View Download
That was 59.0.3046.3

Comment 4 by klausw@google.com, Mar 21 2017

I can reproduce, this is very odd. Looks like it's not properly clearing the screen on each new frame, content is accumulating and getting drawn on top of each other. The tearing effect may be due to Z buffer fighting for near-coplanar textured triangles.

Is it doing anything unusual with your rendering pipeline or canvas? I'll keep looking, but this is definitely unexpected.

Comment 5 by klausw@chromium.org, Mar 21 2017

Labels: -M58 M-59
Owner: klausw@chromium.org
Status: Started (was: Untriaged)
Found it, we're supposed to be clearing the screen each frame if preserveDrawingBuffer is false. This used to happen as a side effect of compositing, but we're no longer doing that. Working on a fix.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e214268ec8e017ccaafe1dda4dca58015456f7a9

commit e214268ec8e017ccaafe1dda4dca58015456f7a9
Author: klausw <klausw@chromium.org>
Date: Wed Mar 22 06:49:14 2017

WebVR: clear screen after submit if preserveDrawingBuffer is false.

That's part of the spec, normally compositing does so but that's
paused while presenting.

BUG= 703378 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2766553004
Cr-Commit-Position: refs/heads/master@{#458648}

[modify] https://crrev.com/e214268ec8e017ccaafe1dda4dca58015456f7a9/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/e214268ec8e017ccaafe1dda4dca58015456f7a9/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/e214268ec8e017ccaafe1dda4dca58015456f7a9/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

Comment 7 by klausw@chromium.org, Mar 22 2017

Owner: vsupruniuk@google.com
Status: Fixed (was: Started)
Should be fixed by this CL, but as of now the change hasn't made it to a canary build. Can you please verify once that has rolled out? Thanks for catching it!

Comment 8 by klausw@chromium.org, Mar 23 2017

Status: Verified (was: Fixed)
Looks good in today's canary 59.0.3049.0.
Owner: klausw@chromium.org
Status: Assigned (was: Verified)
The issue still exists in M58 - not as substantial as in M59, but as described in #1. Should I log a new issue since the M59 issue which is fixed seems a bit different?
New issue please, but fair warning that we're unlikely to be able to do
much about issues in M58 at this point unless it's a severe issue and/or
has a very small and obviously correct fix. I suspect this one would be
neither of those.
Status: Verified (was: Assigned)
OK thanks. I logged a new issue,706431.
Components: Blink>WebXR

Sign in to add a comment