Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 703369 Refactor BrowserAccessibility to use ui::AXPlatformNode
Starred by 1 user Project Member Reported by dougt@chromium.org, Mar 20 Back to list
Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment
Objective

Currently in chromium, there are two areas of code that provide low-level operating system Accessibility APIs.

ui/accessibility/platform/*

content/browser/accessibility/browser_accessibility*

In order to reduce some complexity and code, we’d to remove code that interacts with the native accessibility APIs from content. This will also enable feature parity between Views and Chrome Content It will make supporting foreign accessibility trees easier (i.e. PDF could go directly to the browser rather than via its host web page), and we could maybe support remote desktop accessibility someday Finally, it'd allow us to do things like the COM proxy idea to avoid injected DLLs.

Overview

On the content/ side, there exists a class called BrowserAccessibility which is exactly one node in the accessibility tree.  It provides a number of methods to find boundaries, walk the accessibility tree, and access internals.  In addition, BrowserAccessibility has subclasses on each platforms that handle interacting with the host operating system.  For example, on Windows, BrowserAccessibilityWin (a subclass of BrowserAccessibility) implements IAccessible2 et. al.

On the ui/ side, we also have a set of classes in ui/accessibility/platform/ which interact with the host operating system as well.

Eventual Goal

BrowserAccessibility would inherit from AXPlatformNodeDelegate and own a AXPlatformNode.

The code in ui/accessibility/platform becomes the ONLY implementation of platform-native accessibility APIs, but it has no understanding of things like renderers, frames, and other "how Chrome implements the web" details. It would understand web-specific things like live regions and some web-specific roles, but it wouldn't have to understand too many implementation details, just how to map those to native APIs.

The code in content/browser/accessibility becomes the glue code that maps the accessibility data we get from a web renderer, into a tree of AXPlatformNode objects that implement the native API on each platform. It knows about renderers and iframes and stuff like that, but it doesn't have much platform-specific code anymore.

No code outside of ui/accessibility/platform or content/browser/accessibility should be affected. In particular this is completely orthogonal to any changes to Blink code.


 
Project Member Comment 1 by bugdroid1@chromium.org, Mar 23
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2653b40a23ed879d175abda534f9d24e83495a2

commit e2653b40a23ed879d175abda534f9d24e83495a2
Author: dougt <dougt@chromium.org>
Date: Thu Mar 23 22:09:44 2017

Rename BrowserAccessibility::GetParent to PlatformGetParent.

In prep of refactoring BrowserAccessibility, we are renaming
BrowserAccessibility::GetParent to BrowserAccessibility::PlatformGetParent
to avoid a conflict with AXPlatformNodeDelegate::GetParent.

BUG=703369

Review-Url: https://codereview.chromium.org/2761853004
Cr-Commit-Position: refs/heads/master@{#459246}

[modify] https://crrev.com/e2653b40a23ed879d175abda534f9d24e83495a2/content/browser/accessibility/ax_platform_position.cc
[modify] https://crrev.com/e2653b40a23ed879d175abda534f9d24e83495a2/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/e2653b40a23ed879d175abda534f9d24e83495a2/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/e2653b40a23ed879d175abda534f9d24e83495a2/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/e2653b40a23ed879d175abda534f9d24e83495a2/content/browser/accessibility/browser_accessibility_auralinux.cc
[modify] https://crrev.com/e2653b40a23ed879d175abda534f9d24e83495a2/content/browser/accessibility/browser_accessibility_cocoa.mm
[modify] https://crrev.com/e2653b40a23ed879d175abda534f9d24e83495a2/content/browser/accessibility/browser_accessibility_manager.cc
[modify] https://crrev.com/e2653b40a23ed879d175abda534f9d24e83495a2/content/browser/accessibility/browser_accessibility_manager_android.cc
[modify] https://crrev.com/e2653b40a23ed879d175abda534f9d24e83495a2/content/browser/accessibility/browser_accessibility_manager_unittest.cc
[modify] https://crrev.com/e2653b40a23ed879d175abda534f9d24e83495a2/content/browser/accessibility/browser_accessibility_win.cc
[modify] https://crrev.com/e2653b40a23ed879d175abda534f9d24e83495a2/content/browser/accessibility/one_shot_accessibility_tree_search.cc
[modify] https://crrev.com/e2653b40a23ed879d175abda534f9d24e83495a2/content/browser/accessibility/site_per_process_accessibility_browsertest.cc
[modify] https://crrev.com/e2653b40a23ed879d175abda534f9d24e83495a2/content/browser/web_contents/web_contents_android.cc

Project Member Comment 2 by bugdroid1@chromium.org, Mar 24
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf9bcae65b9dc113edb7409c582238d5cbf7acaf

commit bf9bcae65b9dc113edb7409c582238d5cbf7acaf
Author: dougt <dougt@chromium.org>
Date: Fri Mar 24 01:17:46 2017

Make AXPlatformNodeDelegate::GetData() const

In prep of refactoring BrowserAccessibility, we are making
AXPlatformNodeDelegate::GetData const so that it matches
BrowserAccessibility::GetData.

BUG=703369

Review-Url: https://codereview.chromium.org/2766683003
Cr-Commit-Position: refs/heads/master@{#459323}

[modify] https://crrev.com/bf9bcae65b9dc113edb7409c582238d5cbf7acaf/ui/accessibility/platform/ax_platform_node_delegate.h
[modify] https://crrev.com/bf9bcae65b9dc113edb7409c582238d5cbf7acaf/ui/accessibility/platform/test_ax_node_wrapper.cc
[modify] https://crrev.com/bf9bcae65b9dc113edb7409c582238d5cbf7acaf/ui/accessibility/platform/test_ax_node_wrapper.h
[modify] https://crrev.com/bf9bcae65b9dc113edb7409c582238d5cbf7acaf/ui/views/accessibility/native_view_accessibility_auralinux.cc
[modify] https://crrev.com/bf9bcae65b9dc113edb7409c582238d5cbf7acaf/ui/views/accessibility/native_view_accessibility_base.cc
[modify] https://crrev.com/bf9bcae65b9dc113edb7409c582238d5cbf7acaf/ui/views/accessibility/native_view_accessibility_base.h

Project Member Comment 3 by bugdroid1@chromium.org, Mar 24
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8abfeeb28cc7c6a4fb2bfeca1da3dc82d13ea24b

commit 8abfeeb28cc7c6a4fb2bfeca1da3dc82d13ea24b
Author: dougt <dougt@chromium.org>
Date: Fri Mar 24 06:46:49 2017

DLL Export AXPlatformNodeWin.

In order to use ui::AXPlatformNodeWin from content, we must dll export
these classes.

BUG=703369

Review-Url: https://codereview.chromium.org/2766463002
Cr-Commit-Position: refs/heads/master@{#459376}

[modify] https://crrev.com/8abfeeb28cc7c6a4fb2bfeca1da3dc82d13ea24b/ui/accessibility/platform/ax_platform_node_win.h

Project Member Comment 4 by bugdroid1@chromium.org, Mar 24
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15dcbd89eadd0958c8347a9dee7a26f7d8f614f6

commit 15dcbd89eadd0958c8347a9dee7a26f7d8f614f6
Author: dougt <dougt@chromium.org>
Date: Fri Mar 24 19:15:47 2017

Make BrowserAccessibility implement AXPlatformNodeDelegete.

As part of the fefactoring of BrowserAccessibility, we want to end up with
BrowserAccessibility inheriting from AXPlatformNodeDelegate and owning a
AXPlatformNode. This change has BrowserAccessibility implmenting a
AXPlatformNodeDelegete.  This implementation should do nothing.

BUG=703369

Review-Url: https://codereview.chromium.org/2759113004
Cr-Commit-Position: refs/heads/master@{#459511}

[modify] https://crrev.com/15dcbd89eadd0958c8347a9dee7a26f7d8f614f6/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/15dcbd89eadd0958c8347a9dee7a26f7d8f614f6/content/browser/accessibility/browser_accessibility.h

Labels: NewComponent-Accessibility-Internals NewComponent-Accessibility
Project Member Comment 6 by bugdroid1@chromium.org, Mar 29
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ec1039bc225dfb4221c0c5f387a37cd87fc33a1

commit 5ec1039bc225dfb4221c0c5f387a37cd87fc33a1
Author: dougt <dougt@chromium.org>
Date: Wed Mar 29 05:40:10 2017

BrowserAccessibility should own a AXPlatformNode.

As part of the refacting of BrowserAccessibility, BrowserAccessibility will
create and own a AXPlatformNode.  BrowserAccessibility will forward
IAccessible* and related calls to the AXPlatformNode.

This change simple creates the object and does nothing with it.

BUG=703369

Review-Url: https://codereview.chromium.org/2763803002
Cr-Commit-Position: refs/heads/master@{#460289}

[modify] https://crrev.com/5ec1039bc225dfb4221c0c5f387a37cd87fc33a1/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/5ec1039bc225dfb4221c0c5f387a37cd87fc33a1/content/browser/accessibility/browser_accessibility.h

Project Member Comment 7 by bugdroid1@chromium.org, Apr 7
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f99a6f415f9a0caaae84ed0a768b8c63e3fceb3

commit 9f99a6f415f9a0caaae84ed0a768b8c63e3fceb3
Author: dougt <dougt@chromium.org>
Date: Fri Apr 07 20:11:06 2017

Implement BrowserAccessibility accLocation in terms of AXPlatformNodeWin.

Here we are implementing one IAccessibility method, accLocation(), in terms of
ui::AXPlatformNodeWin. The idea is that we can forward IAccessibility calls to
ui::AXPlatformNodeWin and then slowly trim down, and maybe remove,
BrowserAccessibilityWin.

This CL adds a small helper method that allows the cast conversation of
platform_node_, which is created in AXPlatformNode, from a AXPlatformNode to
AXPlatformNodeWin. If this result is nullptr, we will fall back to using the
BrowserAccessibilityWin implementation.

BUG=703369

Review-Url: https://codereview.chromium.org/2763043002
Cr-Commit-Position: refs/heads/master@{#462978}

[modify] https://crrev.com/9f99a6f415f9a0caaae84ed0a768b8c63e3fceb3/content/browser/accessibility/browser_accessibility_win.cc
[modify] https://crrev.com/9f99a6f415f9a0caaae84ed0a768b8c63e3fceb3/content/browser/accessibility/browser_accessibility_win.h

Project Member Comment 8 by bugdroid1@chromium.org, Apr 9
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc2ea45ec4b3b2d9d426182d5927a6cf74cd680d

commit bc2ea45ec4b3b2d9d426182d5927a6cf74cd680d
Author: dougt <dougt@chromium.org>
Date: Sun Apr 09 21:51:42 2017

Test for accLocation to confirm that transformations work.

BUG=703369

Review-Url: https://codereview.chromium.org/2802173002
Cr-Commit-Position: refs/heads/master@{#463149}

[modify] https://crrev.com/bc2ea45ec4b3b2d9d426182d5927a6cf74cd680d/content/test/data/accessibility/html/iframe-transform-expected-blink.txt
[add] https://crrev.com/bc2ea45ec4b3b2d9d426182d5927a6cf74cd680d/content/test/data/accessibility/html/iframe-transform-expected-win.txt
[modify] https://crrev.com/bc2ea45ec4b3b2d9d426182d5927a6cf74cd680d/content/test/data/accessibility/html/iframe-transform.html
[modify] https://crrev.com/bc2ea45ec4b3b2d9d426182d5927a6cf74cd680d/content/test/data/accessibility/html/iframe.html

Project Member Comment 9 by bugdroid1@chromium.org, Apr 10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c756e00873d3dfe7c07609a3b4f21885a552b1f

commit 8c756e00873d3dfe7c07609a3b4f21885a552b1f
Author: dougt <dougt@chromium.org>
Date: Mon Apr 10 15:39:37 2017

Implement BrowserAccessibility accNavigate() in terms of AXPlatformNodeWin.

Here we are implementing one more IAccessibility method, accNavigate(), in
terms of ui::AXPlatformNodeWin. The idea is that we can forward
IAccessibility calls to ui::AXPlatformNodeWin and then slowly trim down,
and maybe remove, BrowserAccessibilityWin.

Note that this does not forward NAVDIR_. That will be a follow up.

BUG=703369

patch from issue 2789333002 at patchset 40001 (http://crrev.com/2789333002#ps40001)

Review-Url: https://codereview.chromium.org/2806963002
Cr-Commit-Position: refs/heads/master@{#463273}

[modify] https://crrev.com/8c756e00873d3dfe7c07609a3b4f21885a552b1f/content/browser/accessibility/browser_accessibility_win.cc
[modify] https://crrev.com/8c756e00873d3dfe7c07609a3b4f21885a552b1f/ui/accessibility/platform/ax_platform_node_win.cc

Project Member Comment 10 by bugdroid1@chromium.org, Apr 18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a3aeb67d211a7c37fc2ce6355898d27fdfdad04

commit 6a3aeb67d211a7c37fc2ce6355898d27fdfdad04
Author: dougt <dougt@chromium.org>
Date: Tue Apr 18 18:08:16 2017

AXPlatformNodeWin implements IAccessibility. Many of these MSAA methods take a
var_id parameter indicating that the operation should be performed on a
particular child ID, rather than the called object.

This CL mimics the approach taken by BrowserAccessibilityWin.

BUG=703369

Review-Url: https://codereview.chromium.org/2806093002
Cr-Commit-Position: refs/heads/master@{#465288}

[modify] https://crrev.com/6a3aeb67d211a7c37fc2ce6355898d27fdfdad04/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/6a3aeb67d211a7c37fc2ce6355898d27fdfdad04/ui/accessibility/platform/ax_platform_node_win.h

Components: Internals>Accessibility
Components: -UI>Accessibility
Labels: -newcomponent-accessibility-internals -newcomponent-accessibility
Project Member Comment 13 by bugdroid1@chromium.org, Apr 22
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c9b90603321c436e6f892be5435fed84eff857a

commit 0c9b90603321c436e6f892be5435fed84eff857a
Author: dougt <dougt@chromium.org>
Date: Sat Apr 22 21:22:39 2017

Implement GetParent, GetChildCount, ChildAtIndex on BrowserAccessibility

BUG=703369

Review-Url: https://codereview.chromium.org/2816273002
Cr-Commit-Position: refs/heads/master@{#466552}

[modify] https://crrev.com/0c9b90603321c436e6f892be5435fed84eff857a/content/browser/accessibility/browser_accessibility.cc

Project Member Comment 14 by bugdroid1@chromium.org, May 1
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/851c752c37f7400ce870f46bfcaaa0d65742f15f

commit 851c752c37f7400ce870f46bfcaaa0d65742f15f
Author: dougt <dougt@chromium.org>
Date: Mon May 01 21:23:01 2017

Drop the retargeting of accNavigate in BrowserAccessibilityWin

AXPlatformNode already retargets based on the start variant, so we can drop
the GetTargetFromChildID call for GetPlatformNodeWin()->accNavigate.

BUG=703369

Review-Url: https://codereview.chromium.org/2851093002
Cr-Commit-Position: refs/heads/master@{#468412}

[modify] https://crrev.com/851c752c37f7400ce870f46bfcaaa0d65742f15f/content/browser/accessibility/browser_accessibility_win.cc

Project Member Comment 15 by bugdroid1@chromium.org, May 1
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9451bd7ecb9c10fa982c98a67366b2390c9dcbd2

commit 9451bd7ecb9c10fa982c98a67366b2390c9dcbd2
Author: dougt <dougt@chromium.org>
Date: Mon May 01 21:38:22 2017

Forward BrowserAccessibilityWin::get_accHelp to the platform node.

BUG=703369

Review-Url: https://codereview.chromium.org/2854553002
Cr-Commit-Position: refs/heads/master@{#468420}

[modify] https://crrev.com/9451bd7ecb9c10fa982c98a67366b2390c9dcbd2/content/browser/accessibility/browser_accessibility_win.cc
[modify] https://crrev.com/9451bd7ecb9c10fa982c98a67366b2390c9dcbd2/ui/accessibility/platform/ax_platform_node_win.cc

Project Member Comment 16 by bugdroid1@chromium.org, May 1
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f3d6445352e0d05801e98c765f3222b5163e489

commit 4f3d6445352e0d05801e98c765f3222b5163e489
Author: dougt <dougt@chromium.org>
Date: Mon May 01 21:40:39 2017

Forward BrowserAccessibilityWin::get_accName to platform node.

BUG=703369

Review-Url: https://codereview.chromium.org/2855463003
Cr-Commit-Position: refs/heads/master@{#468422}

[modify] https://crrev.com/4f3d6445352e0d05801e98c765f3222b5163e489/content/browser/accessibility/browser_accessibility_win.cc
[modify] https://crrev.com/4f3d6445352e0d05801e98c765f3222b5163e489/ui/accessibility/platform/ax_platform_node_win.cc

Project Member Comment 17 by bugdroid1@chromium.org, May 10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b5b4cd8b3f76c0c4ad01e69b3f137604a9a21ee

commit 6b5b4cd8b3f76c0c4ad01e69b3f137604a9a21ee
Author: dougt <dougt@chromium.org>
Date: Wed May 10 06:03:54 2017

Split out the MSCOM pieces of BrowserAccessibilityWin into a seperate class.

This CL splits out all of the MSCOM stuff in BrowserAccessibilityWin into to a
new class BrowserAccessibilityComWin. This allows us to more easily to reuse
the AXPlatformNodeWin.

The way this works is that BrowserAccessibilityWin creates and owns a COM
object named |browser_accessibility_com_|.  BrowserAccessibilityWin continues
to implement BrowserAccessibility but all interactions with Windows is done
through the BrowserAccessibilityComWin object.

BrowserAccessibilityComWin is created with both a delegate for
AXPlatformNodeWin usage as well as a backpointer to BrowserAccessibilityWin so
it can call back into BrowserAccessibility. Ownership is such that:

BrowserAccessibilityWin owns one reference on BrowserAccessibilityComWin.  When
BrowserAccessibilityWin goes away, it nulls out the backpointer and delegate
pointer rendering the BrowserAccessibilityComWin potentially still alive but
basically useless.

Note that this split is similar to how MacOS is implemented.

BUG=703369

Review-Url: https://codereview.chromium.org/2864953002
Cr-Commit-Position: refs/heads/master@{#470493}

[modify] https://crrev.com/6b5b4cd8b3f76c0c4ad01e69b3f137604a9a21ee/content/browser/BUILD.gn
[modify] https://crrev.com/6b5b4cd8b3f76c0c4ad01e69b3f137604a9a21ee/content/browser/accessibility/accessibility_event_recorder_win.cc
[modify] https://crrev.com/6b5b4cd8b3f76c0c4ad01e69b3f137604a9a21ee/content/browser/accessibility/accessibility_tree_formatter_win.cc
[modify] https://crrev.com/6b5b4cd8b3f76c0c4ad01e69b3f137604a9a21ee/content/browser/accessibility/accessibility_win_browsertest.cc
[add] https://crrev.com/6b5b4cd8b3f76c0c4ad01e69b3f137604a9a21ee/content/browser/accessibility/browser_accessibility_com_win.cc
[add] https://crrev.com/6b5b4cd8b3f76c0c4ad01e69b3f137604a9a21ee/content/browser/accessibility/browser_accessibility_com_win.h
[modify] https://crrev.com/6b5b4cd8b3f76c0c4ad01e69b3f137604a9a21ee/content/browser/accessibility/browser_accessibility_manager_unittest.cc
[modify] https://crrev.com/6b5b4cd8b3f76c0c4ad01e69b3f137604a9a21ee/content/browser/accessibility/browser_accessibility_manager_win.cc
[modify] https://crrev.com/6b5b4cd8b3f76c0c4ad01e69b3f137604a9a21ee/content/browser/accessibility/browser_accessibility_win.cc
[modify] https://crrev.com/6b5b4cd8b3f76c0c4ad01e69b3f137604a9a21ee/content/browser/accessibility/browser_accessibility_win.h
[modify] https://crrev.com/6b5b4cd8b3f76c0c4ad01e69b3f137604a9a21ee/content/browser/accessibility/browser_accessibility_win_unittest.cc
[modify] https://crrev.com/6b5b4cd8b3f76c0c4ad01e69b3f137604a9a21ee/content/browser/renderer_host/legacy_render_widget_host_win.cc
[modify] https://crrev.com/6b5b4cd8b3f76c0c4ad01e69b3f137604a9a21ee/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/6b5b4cd8b3f76c0c4ad01e69b3f137604a9a21ee/ui/accessibility/platform/ax_platform_node_base.h
[modify] https://crrev.com/6b5b4cd8b3f76c0c4ad01e69b3f137604a9a21ee/ui/accessibility/platform/ax_platform_node_win.h

Project Member Comment 18 by bugdroid1@chromium.org, May 10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a5ce801c1afa20f33bca1d8f6b059d20b76fc40

commit 7a5ce801c1afa20f33bca1d8f6b059d20b76fc40
Author: dougt <dougt@chromium.org>
Date: Wed May 10 06:23:34 2017

BrowserAccessibilityWin precondition only needs to check for a valid owner

BUG=703369

Review-Url: https://codereview.chromium.org/2874443002
Cr-Commit-Position: refs/heads/master@{#470501}

[modify] https://crrev.com/7a5ce801c1afa20f33bca1d8f6b059d20b76fc40/content/browser/accessibility/browser_accessibility_com_win.cc

Project Member Comment 19 by bugdroid1@chromium.org, May 10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a1c7507804d3955f71fa3f2d55461dfcf556245

commit 5a1c7507804d3955f71fa3f2d55461dfcf556245
Author: dougt <dougt@chromium.org>
Date: Wed May 10 19:08:20 2017

Create accessor for owner's manager to simplify code a bit

BUG=703369

Review-Url: https://codereview.chromium.org/2865133005
Cr-Commit-Position: refs/heads/master@{#470663}

[modify] https://crrev.com/5a1c7507804d3955f71fa3f2d55461dfcf556245/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/5a1c7507804d3955f71fa3f2d55461dfcf556245/content/browser/accessibility/browser_accessibility_com_win.h

Project Member Comment 20 by bugdroid1@chromium.org, May 11
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/225d81472e1c740fe8719b3bfc99612bc89fed36

commit 225d81472e1c740fe8719b3bfc99612bc89fed36
Author: dougt <dougt@chromium.org>
Date: Thu May 11 00:07:52 2017

Use BrowserAccessibilityComWin::Destroy to clear delegate and owner.

BUG=703369

Review-Url: https://codereview.chromium.org/2873683003
Cr-Commit-Position: refs/heads/master@{#470760}

[modify] https://crrev.com/225d81472e1c740fe8719b3bfc99612bc89fed36/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/225d81472e1c740fe8719b3bfc99612bc89fed36/content/browser/accessibility/browser_accessibility_com_win.h
[modify] https://crrev.com/225d81472e1c740fe8719b3bfc99612bc89fed36/content/browser/accessibility/browser_accessibility_win.cc

Project Member Comment 21 by bugdroid1@chromium.org, May 11
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/081e4c81bb3c3a10b7e6921954dbe1e234e469c1

commit 081e4c81bb3c3a10b7e6921954dbe1e234e469c1
Author: dougt <dougt@chromium.org>
Date: Thu May 11 03:59:36 2017

Remove BrowserAccessibilityWin::Destroy in favor of using the destructor

BUG=703369

Review-Url: https://codereview.chromium.org/2866283003
Cr-Commit-Position: refs/heads/master@{#470800}

[modify] https://crrev.com/081e4c81bb3c3a10b7e6921954dbe1e234e469c1/content/browser/accessibility/browser_accessibility_win.cc
[modify] https://crrev.com/081e4c81bb3c3a10b7e6921954dbe1e234e469c1/content/browser/accessibility/browser_accessibility_win.h

Project Member Comment 22 by bugdroid1@chromium.org, May 11
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a6336392c7c5c16279bcb773012fd40d6970e82

commit 3a6336392c7c5c16279bcb773012fd40d6970e82
Author: dougt <dougt@chromium.org>
Date: Thu May 11 06:35:32 2017

Rename BrowserAccessibilityComWin::GetOwner() to ::owner()

BUG=703369

Review-Url: https://codereview.chromium.org/2873753002
Cr-Commit-Position: refs/heads/master@{#470846}

[modify] https://crrev.com/3a6336392c7c5c16279bcb773012fd40d6970e82/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/3a6336392c7c5c16279bcb773012fd40d6970e82/content/browser/accessibility/browser_accessibility_com_win.h

Project Member Comment 23 by bugdroid1@chromium.org, May 11
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f57fb3c6faf2347318e9a5fc2fb7796ea508903

commit 8f57fb3c6faf2347318e9a5fc2fb7796ea508903
Author: dougt <dougt@chromium.org>
Date: Thu May 11 21:34:37 2017

Reuse AXPlatformNodeBase::Init to set owner.

BUG=703369

Review-Url: https://codereview.chromium.org/2872983002
Cr-Commit-Position: refs/heads/master@{#471080}

[modify] https://crrev.com/8f57fb3c6faf2347318e9a5fc2fb7796ea508903/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/8f57fb3c6faf2347318e9a5fc2fb7796ea508903/content/browser/accessibility/browser_accessibility_com_win.h
[modify] https://crrev.com/8f57fb3c6faf2347318e9a5fc2fb7796ea508903/content/browser/accessibility/browser_accessibility_win.cc

Project Member Comment 24 by bugdroid1@chromium.org, May 12
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9e4777c60d6d7277520da3733346b2b7cda04fa

commit e9e4777c60d6d7277520da3733346b2b7cda04fa
Author: nektar <nektar@chromium.org>
Date: Fri May 12 02:38:49 2017

Fixed crash in accessibility code in LegacyRenderWidgetHost.

R=dougt@chromium.org, dmazzoni@chromium.org, ananta@chromium.org
BUG=703369
TESTED=Manually with Jaws 18

Review-Url: https://codereview.chromium.org/2879623003
Cr-Commit-Position: refs/heads/master@{#471191}

[modify] https://crrev.com/e9e4777c60d6d7277520da3733346b2b7cda04fa/content/browser/renderer_host/legacy_render_widget_host_win.cc

Project Member Comment 25 by bugdroid1@chromium.org, May 22
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/501939067a93844fd22780691e362ce74ddabb83

commit 501939067a93844fd22780691e362ce74ddabb83
Author: dougt <dougt@chromium.org>
Date: Mon May 22 03:53:38 2017

Remove BrowserAccessibility::platform_node_

Since we have decided to subclass from AXPlatformNode, we no longer need
to use the platform_node_ variable.

BUG=703369

Review-Url: https://codereview.chromium.org/2886353003
Cr-Commit-Position: refs/heads/master@{#473500}

[modify] https://crrev.com/501939067a93844fd22780691e362ce74ddabb83/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/501939067a93844fd22780691e362ce74ddabb83/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/501939067a93844fd22780691e362ce74ddabb83/content/browser/accessibility/browser_accessibility_win.cc
[modify] https://crrev.com/501939067a93844fd22780691e362ce74ddabb83/content/browser/accessibility/browser_accessibility_win.h

Project Member Comment 26 by bugdroid1@chromium.org, May 23
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df2eff4a9cd6e379198f2c7cebdf6a11ea7157c1

commit df2eff4a9cd6e379198f2c7cebdf6a11ea7157c1
Author: dougt <dougt@chromium.org>
Date: Tue May 23 01:12:18 2017

Force AXPlatformNode to have the same unique id as the owning BA object.

This CL allows us to override the AXPlatformNode's GetFromUniqueId
method.  In BrowserAccessibilityComWin we implement this by using the
BrowserAccessibility GetFromUniqueId.

BUG=703369

Review-Url: https://codereview.chromium.org/2894673003
Cr-Commit-Position: refs/heads/master@{#473771}

[modify] https://crrev.com/df2eff4a9cd6e379198f2c7cebdf6a11ea7157c1/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/df2eff4a9cd6e379198f2c7cebdf6a11ea7157c1/content/browser/accessibility/browser_accessibility_com_win.h
[modify] https://crrev.com/df2eff4a9cd6e379198f2c7cebdf6a11ea7157c1/ui/accessibility/platform/ax_platform_node.h

Project Member Comment 27 by bugdroid1@chromium.org, May 23
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6458fe10187e3a93348f6f15551ad82551f7c44c

commit 6458fe10187e3a93348f6f15551ad82551f7c44c
Author: dougt <dougt@chromium.org>
Date: Tue May 23 03:52:52 2017

Implement a few BrowserAccessibilityComWin methods with AXPlatformNodeWin.

In this CL, we will implement the following in terms of AXPlatformNodeWin:

get_accChild
get_accChildCount
get_accDefaultAction
get_accDescription
get_accFocus
get_accParent
accDoDefaultAction

BUG=703369

Review-Url: https://codereview.chromium.org/2891913005
Cr-Commit-Position: refs/heads/master@{#473803}

[modify] https://crrev.com/6458fe10187e3a93348f6f15551ad82551f7c44c/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/6458fe10187e3a93348f6f15551ad82551f7c44c/content/browser/accessibility/browser_accessibility_com_win.cc

Project Member Comment 28 by bugdroid1@chromium.org, May 31
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebe52af6c0285feef6f776dfd95669123315e525

commit ebe52af6c0285feef6f776dfd95669123315e525
Author: dougt <dougt@chromium.org>
Date: Wed May 31 02:50:51 2017

Forward BrowserAccessibility get_accRole to AXPlatformNode.

This is another migration from BrowserAccessibility to AXPlatformNodeWin.
In this installment, we're converting get_accRole.  I have updated the
AXPlatformNodeWin::MSAARole() to include many of the missing roles that
the BrowserAccessibility code had.  I also introduced a new method that
allows get_accRole to return a string (overriding the default type value
that MSAARole() returns).  I have not dug into why we need to return the
various values instead of just using the role number or html element
name. Instead, I just added todos for me to follow up on.

BUG=703369

Review-Url: https://codereview.chromium.org/2909853002
Cr-Commit-Position: refs/heads/master@{#475757}

[modify] https://crrev.com/ebe52af6c0285feef6f776dfd95669123315e525/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/ebe52af6c0285feef6f776dfd95669123315e525/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/ebe52af6c0285feef6f776dfd95669123315e525/ui/accessibility/platform/ax_platform_node_win.h

Project Member Comment 29 by bugdroid1@chromium.org, May 31
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9570c41a05e2556411722bf15da9f527ccaaa646

commit 9570c41a05e2556411722bf15da9f527ccaaa646
Author: dougt <dougt@chromium.org>
Date: Wed May 31 04:46:02 2017

Forward BrowserAccessibility accSelect() to AXPlatformNode.

This forwards accSelect to the AXPlatformNode. In order to do this, we
had to extension AccessibilityPerformAction a bit to be able to handle
AX_ACTION_FOCUS. Not that the node id is not passed as part of the AXActionData
and is not being used by the delegate at this point.

BUG=703369

Review-Url: https://codereview.chromium.org/2913553003
Cr-Commit-Position: refs/heads/master@{#475806}

[modify] https://crrev.com/9570c41a05e2556411722bf15da9f527ccaaa646/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/9570c41a05e2556411722bf15da9f527ccaaa646/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/9570c41a05e2556411722bf15da9f527ccaaa646/ui/accessibility/platform/ax_platform_node_win.cc

Project Member Comment 30 by bugdroid1@chromium.org, Jun 6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e42c06947d8e001c30bdc0efafefedd8afa2256

commit 0e42c06947d8e001c30bdc0efafefedd8afa2256
Author: dougt <dougt@chromium.org>
Date: Tue Jun 06 06:29:47 2017

Fix todo's in AXPlatformNodeWin::get_accRole related to string results.

For historical reasons, AXPlatformNodeWin::get_accRole can return a string
which can containing the HTML tag name as the MSAA role, rather than a int.

In some cases, we special cased roles such that they alway returned a specific
string instead of the underlying HTML tag name. For example, AX_ROLE_PARAGRAPH
always returned upper case "P".

What this CL does is removes some of these special cases in favor of just
returning the uppercase of the HTML tag name.

This is a follow up from issue 2909853002.

BUG=703369

Review-Url: https://codereview.chromium.org/2912243002
Cr-Commit-Position: refs/heads/master@{#477216}

[modify] https://crrev.com/0e42c06947d8e001c30bdc0efafefedd8afa2256/content/browser/accessibility/accessibility_win_browsertest.cc
[modify] https://crrev.com/0e42c06947d8e001c30bdc0efafefedd8afa2256/content/test/data/accessibility/event/add-child-of-body-expected-win.txt
[modify] https://crrev.com/0e42c06947d8e001c30bdc0efafefedd8afa2256/content/test/data/accessibility/event/css-display-expected-win.txt
[modify] https://crrev.com/0e42c06947d8e001c30bdc0efafefedd8afa2256/content/test/data/accessibility/event/css-visibility-expected-win.txt
[modify] https://crrev.com/0e42c06947d8e001c30bdc0efafefedd8afa2256/content/test/data/accessibility/event/description-change-expected-win.txt
[modify] https://crrev.com/0e42c06947d8e001c30bdc0efafefedd8afa2256/content/test/data/accessibility/event/inner-html-change-expected-win.txt
[modify] https://crrev.com/0e42c06947d8e001c30bdc0efafefedd8afa2256/content/test/data/accessibility/event/name-change-expected-win.txt
[modify] https://crrev.com/0e42c06947d8e001c30bdc0efafefedd8afa2256/content/test/data/accessibility/event/text-changed-expected-win.txt
[modify] https://crrev.com/0e42c06947d8e001c30bdc0efafefedd8afa2256/ui/accessibility/platform/ax_platform_node_win.cc

Project Member Comment 31 by bugdroid1@chromium.org, Jun 8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2396b649beff6d478edff6334af2305418cc3c45

commit 2396b649beff6d478edff6334af2305418cc3c45
Author: dougt <dougt@chromium.org>
Date: Thu Jun 08 22:48:42 2017

Forward BrowserAccessibility get_accState to AXPlatformNode.

This is another migration from BrowserAccessibility to AXPlatformNodeWin.
In this installment, we're converting get_accState. This one is mostly
straightforward. The one gotcha is that there are some types that need
to be explictly marked as focusable if they are selectable.

BUG=703369

Review-Url: https://codereview.chromium.org/2913553002
Cr-Commit-Position: refs/heads/master@{#478110}

[modify] https://crrev.com/2396b649beff6d478edff6334af2305418cc3c45/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/2396b649beff6d478edff6334af2305418cc3c45/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/2396b649beff6d478edff6334af2305418cc3c45/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/2396b649beff6d478edff6334af2305418cc3c45/ui/accessibility/platform/ax_fake_caret_win.cc
[modify] https://crrev.com/2396b649beff6d478edff6334af2305418cc3c45/ui/accessibility/platform/ax_fake_caret_win.h
[modify] https://crrev.com/2396b649beff6d478edff6334af2305418cc3c45/ui/accessibility/platform/ax_platform_node_delegate.h
[modify] https://crrev.com/2396b649beff6d478edff6334af2305418cc3c45/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/2396b649beff6d478edff6334af2305418cc3c45/ui/accessibility/platform/test_ax_node_wrapper.cc
[modify] https://crrev.com/2396b649beff6d478edff6334af2305418cc3c45/ui/accessibility/platform/test_ax_node_wrapper.h
[modify] https://crrev.com/2396b649beff6d478edff6334af2305418cc3c45/ui/views/accessibility/native_view_accessibility_auralinux.cc
[modify] https://crrev.com/2396b649beff6d478edff6334af2305418cc3c45/ui/views/accessibility/native_view_accessibility_base.cc
[modify] https://crrev.com/2396b649beff6d478edff6334af2305418cc3c45/ui/views/accessibility/native_view_accessibility_base.h

Project Member Comment 32 by bugdroid1@chromium.org, Jun 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/317b0a78cf083a14fcf59871e03ca049fac2822d

commit 317b0a78cf083a14fcf59871e03ca049fac2822d
Author: dougt <dougt@chromium.org>
Date: Tue Jun 13 04:04:40 2017

Forward BrowserAccessibilityWin::get_accKeyboardShortcut to the platform node

BUG=703369

Review-Url: https://codereview.chromium.org/2849063002
Cr-Commit-Position: refs/heads/master@{#478896}

[modify] https://crrev.com/317b0a78cf083a14fcf59871e03ca049fac2822d/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/317b0a78cf083a14fcf59871e03ca049fac2822d/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/317b0a78cf083a14fcf59871e03ca049fac2822d/content/renderer/accessibility/blink_ax_tree_source.cc
[modify] https://crrev.com/317b0a78cf083a14fcf59871e03ca049fac2822d/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/317b0a78cf083a14fcf59871e03ca049fac2822d/ui/accessibility/ax_node_data.cc
[modify] https://crrev.com/317b0a78cf083a14fcf59871e03ca049fac2822d/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/317b0a78cf083a14fcf59871e03ca049fac2822d/ui/accessibility/platform/ax_platform_node_win_unittest.cc

Project Member Comment 33 by bugdroid1@chromium.org, Jun 14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f29d6038c0a838d1eb2e94536634b6bc83a068b5

commit f29d6038c0a838d1eb2e94536634b6bc83a068b5
Author: dmazzoni <dmazzoni@chromium.org>
Date: Wed Jun 14 18:27:55 2017

Revert of Forward BrowserAccessibility get_accState to AXPlatformNode. (patchset #5 id:80001 of https://codereview.chromium.org/2913553002/ )

Reason for revert:
READONLY state missing, breaks screen reader virtual buffers

Original issue's description:
> Forward BrowserAccessibility get_accState to AXPlatformNode.
>
> This is another migration from BrowserAccessibility to AXPlatformNodeWin.
> In this installment, we're converting get_accState. This one is mostly
> straightforward. The one gotcha is that there are some types that need
> to be explictly marked as focusable if they are selectable.
>
> BUG=703369
>
> Review-Url: https://codereview.chromium.org/2913553002
> Cr-Commit-Position: refs/heads/master@{#478110}
> Committed: https://chromium.googlesource.com/chromium/src/+/2396b649beff6d478edff6334af2305418cc3c45

TBR=dougt@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=703369,733313

Review-Url: https://codereview.chromium.org/2937083002
Cr-Commit-Position: refs/heads/master@{#479448}

[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/ui/accessibility/platform/ax_fake_caret_win.cc
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/ui/accessibility/platform/ax_fake_caret_win.h
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/ui/accessibility/platform/ax_platform_node_delegate.h
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/ui/accessibility/platform/test_ax_node_wrapper.cc
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/ui/accessibility/platform/test_ax_node_wrapper.h
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/ui/views/accessibility/native_view_accessibility_auralinux.cc
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/ui/views/accessibility/native_view_accessibility_base.cc
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/ui/views/accessibility/native_view_accessibility_base.h

Project Member Comment 34 by bugdroid1@chromium.org, Jun 15
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d2a90d730038e5608c9b89256746636b64b292f

commit 4d2a90d730038e5608c9b89256746636b64b292f
Author: dougt <dougt@chromium.org>
Date: Thu Jun 15 08:54:23 2017

Remove unused ui::AXPlatformNode pointer from BrowserAccessibility.

A while ago, we thought we would keep the the platform node as a seperate
object.  Most of this was removed in
https://codereview.chromium.org/2886353003 but we missed this.

BUG=703369

Review-Url: https://codereview.chromium.org/2930413004
Cr-Commit-Position: refs/heads/master@{#479644}

[modify] https://crrev.com/4d2a90d730038e5608c9b89256746636b64b292f/content/browser/accessibility/browser_accessibility.h

Project Member Comment 35 by bugdroid1@chromium.org, Jun 16
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/216269ac2dc0901d2ca0fd3686fbfedf2f01b06f

commit 216269ac2dc0901d2ca0fd3686fbfedf2f01b06f
Author: dougt <dougt@chromium.org>
Date: Fri Jun 16 04:17:02 2017

Forward four more BrowserAccessibility APIs to AXPlatformNode.

put_accValue
put_accName
get_accHelpTopic
get_accValue

To support get_accValue, we extended AXPlatformNodeBase with a number of
helper methods (mostly copied from BrowserAccessibility).

BUG=703369

Review-Url: https://codereview.chromium.org/2933353002
Cr-Commit-Position: refs/heads/master@{#479946}

[modify] https://crrev.com/216269ac2dc0901d2ca0fd3686fbfedf2f01b06f/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/216269ac2dc0901d2ca0fd3686fbfedf2f01b06f/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/216269ac2dc0901d2ca0fd3686fbfedf2f01b06f/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/216269ac2dc0901d2ca0fd3686fbfedf2f01b06f/ui/accessibility/DEPS
[modify] https://crrev.com/216269ac2dc0901d2ca0fd3686fbfedf2f01b06f/ui/accessibility/platform/ax_fake_caret_win.cc
[modify] https://crrev.com/216269ac2dc0901d2ca0fd3686fbfedf2f01b06f/ui/accessibility/platform/ax_fake_caret_win.h
[modify] https://crrev.com/216269ac2dc0901d2ca0fd3686fbfedf2f01b06f/ui/accessibility/platform/ax_platform_node_base.cc
[modify] https://crrev.com/216269ac2dc0901d2ca0fd3686fbfedf2f01b06f/ui/accessibility/platform/ax_platform_node_base.h
[modify] https://crrev.com/216269ac2dc0901d2ca0fd3686fbfedf2f01b06f/ui/accessibility/platform/ax_platform_node_delegate.h
[modify] https://crrev.com/216269ac2dc0901d2ca0fd3686fbfedf2f01b06f/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/216269ac2dc0901d2ca0fd3686fbfedf2f01b06f/ui/accessibility/platform/test_ax_node_wrapper.cc
[modify] https://crrev.com/216269ac2dc0901d2ca0fd3686fbfedf2f01b06f/ui/accessibility/platform/test_ax_node_wrapper.h
[modify] https://crrev.com/216269ac2dc0901d2ca0fd3686fbfedf2f01b06f/ui/views/accessibility/native_view_accessibility_auralinux.cc
[modify] https://crrev.com/216269ac2dc0901d2ca0fd3686fbfedf2f01b06f/ui/views/accessibility/native_view_accessibility_base.cc
[modify] https://crrev.com/216269ac2dc0901d2ca0fd3686fbfedf2f01b06f/ui/views/accessibility/native_view_accessibility_base.h

Project Member Comment 36 by bugdroid1@chromium.org, Jun 26
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07c299e9c4839adca2fb75822fe21c4513b4bdd6

commit 07c299e9c4839adca2fb75822fe21c4513b4bdd6
Author: dougt <dougt@chromium.org>
Date: Mon Jun 26 21:10:00 2017

Forward BrowserAccessibility::accHitTest to AXPlatformNode.

BUG=703369

Review-Url: https://codereview.chromium.org/2948513002
Cr-Commit-Position: refs/heads/master@{#482398}

[modify] https://crrev.com/07c299e9c4839adca2fb75822fe21c4513b4bdd6/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/07c299e9c4839adca2fb75822fe21c4513b4bdd6/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/07c299e9c4839adca2fb75822fe21c4513b4bdd6/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/07c299e9c4839adca2fb75822fe21c4513b4bdd6/ui/accessibility/platform/ax_platform_node_win_unittest.cc
[modify] https://crrev.com/07c299e9c4839adca2fb75822fe21c4513b4bdd6/ui/accessibility/platform/test_ax_node_wrapper.cc
[modify] https://crrev.com/07c299e9c4839adca2fb75822fe21c4513b4bdd6/ui/accessibility/platform/test_ax_node_wrapper.h

Project Member Comment 37 by bugdroid1@chromium.org, Jun 26
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d17869d645c52f8850580b88fcf6dd221bec3e4

commit 9d17869d645c52f8850580b88fcf6dd221bec3e4
Author: dougt <dougt@chromium.org>
Date: Mon Jun 26 23:27:00 2017

Forward BrowserAccessibility::get_accSelection to AXPlatformNode.

BUG=703369

Review-Url: https://codereview.chromium.org/2942413003
Cr-Commit-Position: refs/heads/master@{#482460}

[modify] https://crrev.com/9d17869d645c52f8850580b88fcf6dd221bec3e4/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/9d17869d645c52f8850580b88fcf6dd221bec3e4/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/9d17869d645c52f8850580b88fcf6dd221bec3e4/ui/accessibility/platform/ax_platform_node_win_unittest.cc

Project Member Comment 38 by bugdroid1@chromium.org, Jun 27
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57c6dff1214ac4d327d0705d89534412a1743f3c

commit 57c6dff1214ac4d327d0705d89534412a1743f3c
Author: dougt <dougt@chromium.org>
Date: Tue Jun 27 21:36:46 2017

Forward BrowserAccessibility get_accState to AXPlatformNode.

This is another migration from BrowserAccessibility to AXPlatformNodeWin.
In this installment, we're converting get_accState.

We attempted to land this CL in https://codereview.chromium.org/2913553002/.
The CL was reverted due to lack of adequate testing. We since have improved
our testing in bug 733437.

BUG=703369

Review-Url: https://codereview.chromium.org/2943243002
Cr-Commit-Position: refs/heads/master@{#482751}

[modify] https://crrev.com/57c6dff1214ac4d327d0705d89534412a1743f3c/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/57c6dff1214ac4d327d0705d89534412a1743f3c/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/57c6dff1214ac4d327d0705d89534412a1743f3c/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/57c6dff1214ac4d327d0705d89534412a1743f3c/content/browser/accessibility/browser_accessibility_com_win.h
[modify] https://crrev.com/57c6dff1214ac4d327d0705d89534412a1743f3c/ui/accessibility/platform/ax_fake_caret_win.cc
[modify] https://crrev.com/57c6dff1214ac4d327d0705d89534412a1743f3c/ui/accessibility/platform/ax_fake_caret_win.h
[modify] https://crrev.com/57c6dff1214ac4d327d0705d89534412a1743f3c/ui/accessibility/platform/ax_platform_node_delegate.h
[modify] https://crrev.com/57c6dff1214ac4d327d0705d89534412a1743f3c/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/57c6dff1214ac4d327d0705d89534412a1743f3c/ui/accessibility/platform/ax_platform_node_win.h
[modify] https://crrev.com/57c6dff1214ac4d327d0705d89534412a1743f3c/ui/accessibility/platform/test_ax_node_wrapper.cc
[modify] https://crrev.com/57c6dff1214ac4d327d0705d89534412a1743f3c/ui/accessibility/platform/test_ax_node_wrapper.h
[modify] https://crrev.com/57c6dff1214ac4d327d0705d89534412a1743f3c/ui/views/accessibility/native_view_accessibility_auralinux.cc
[modify] https://crrev.com/57c6dff1214ac4d327d0705d89534412a1743f3c/ui/views/accessibility/native_view_accessibility_base.cc
[modify] https://crrev.com/57c6dff1214ac4d327d0705d89534412a1743f3c/ui/views/accessibility/native_view_accessibility_base.h

Project Member Comment 39 by bugdroid1@chromium.org, Jul 11
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce47e57c2d95752a2d78fd080a95f4e635140bcb

commit ce47e57c2d95752a2d78fd080a95f4e635140bcb
Author: dougt <dougt@chromium.org>
Date: Tue Jul 11 00:18:12 2017

Update AX Roles for AX_ROLE_MENU_LIST_POPUP and AX_ROLE_MENU_LIST_OPTION

This CL is based on the work tmoniuszko@opera.com did in CL
2962633004 which found a regression in a changed to ROLE_SYSTEM_LIST
(see https://codereview.chromium.org/2909853002).

BUG=703369

Review-Url: https://codereview.chromium.org/2969743002
Cr-Commit-Position: refs/heads/master@{#485458}

[modify] https://crrev.com/ce47e57c2d95752a2d78fd080a95f4e635140bcb/content/test/data/accessibility/event/menulist-collapse-expected-win.txt
[modify] https://crrev.com/ce47e57c2d95752a2d78fd080a95f4e635140bcb/content/test/data/accessibility/event/menulist-focus-expected-win.txt
[modify] https://crrev.com/ce47e57c2d95752a2d78fd080a95f4e635140bcb/ui/accessibility/platform/ax_platform_node_win.cc

Project Member Comment 40 by bugdroid1@chromium.org, Jul 11
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37f7a151bff77deda03cc942b7e7abde9ab5f549

commit 37f7a151bff77deda03cc942b7e7abde9ab5f549
Author: dougt <dougt@chromium.org>
Date: Tue Jul 11 00:21:54 2017

Move two BrowserAccessibility role predicates to ax_role_properties.

BUG=703369

Review-Url: https://codereview.chromium.org/2969603002
Cr-Commit-Position: refs/heads/master@{#485462}

[modify] https://crrev.com/37f7a151bff77deda03cc942b7e7abde9ab5f549/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/37f7a151bff77deda03cc942b7e7abde9ab5f549/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/37f7a151bff77deda03cc942b7e7abde9ab5f549/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/37f7a151bff77deda03cc942b7e7abde9ab5f549/content/browser/accessibility/browser_accessibility_cocoa.mm
[modify] https://crrev.com/37f7a151bff77deda03cc942b7e7abde9ab5f549/content/browser/accessibility/one_shot_accessibility_tree_search.cc
[modify] https://crrev.com/37f7a151bff77deda03cc942b7e7abde9ab5f549/ui/accessibility/ax_role_properties.cc
[modify] https://crrev.com/37f7a151bff77deda03cc942b7e7abde9ab5f549/ui/accessibility/ax_role_properties.h

Project Member Comment 41 by bugdroid1@chromium.org, Jul 11
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/731db9d2f7dca2fe98df656ed9b139e494409793

commit 731db9d2f7dca2fe98df656ed9b139e494409793
Author: dougt <dougt@chromium.org>
Date: Tue Jul 11 22:32:58 2017

Use MSAA_Role directly from BrowserAccessibility.

During the move of get_accRole(), I left the ia_role initialization in
BrowserAccessibilityComWin::InitRoleAndState(). This CL removes this
duplication and prevents any further drift between the files.

BUG=703369

Review-Url: https://codereview.chromium.org/2967493005
Cr-Commit-Position: refs/heads/master@{#485704}

[modify] https://crrev.com/731db9d2f7dca2fe98df656ed9b139e494409793/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/731db9d2f7dca2fe98df656ed9b139e494409793/content/browser/accessibility/browser_accessibility_com_win.h
[modify] https://crrev.com/731db9d2f7dca2fe98df656ed9b139e494409793/content/test/data/accessibility/html/modal-dialog-closed-expected-win.txt
[modify] https://crrev.com/731db9d2f7dca2fe98df656ed9b139e494409793/content/test/data/accessibility/html/select-expected-win.txt
[modify] https://crrev.com/731db9d2f7dca2fe98df656ed9b139e494409793/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/731db9d2f7dca2fe98df656ed9b139e494409793/ui/accessibility/platform/ax_platform_node_win.h

Project Member Comment 42 by bugdroid1@chromium.org, Jul 12
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c836dc519c8e2043e006e5fcb62f3cf48d7e00ce

commit c836dc519c8e2043e006e5fcb62f3cf48d7e00ce
Author: dougt <dougt@chromium.org>
Date: Wed Jul 12 04:31:59 2017

Move IA2 State handling to AXPlatformNodeWin.

This CL moves all ia2_state handling from BrowserAccessibilityComWin to
AXPlatformNodeWin. In addition, we now forward get_states() to
AXPlatformNodeWin as well.

BUG=703369

Review-Url: https://codereview.chromium.org/2968833002
Cr-Commit-Position: refs/heads/master@{#485862}

[modify] https://crrev.com/c836dc519c8e2043e006e5fcb62f3cf48d7e00ce/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/c836dc519c8e2043e006e5fcb62f3cf48d7e00ce/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/c836dc519c8e2043e006e5fcb62f3cf48d7e00ce/content/browser/accessibility/browser_accessibility_com_win.h
[modify] https://crrev.com/c836dc519c8e2043e006e5fcb62f3cf48d7e00ce/ui/accessibility/ax_role_properties.cc
[modify] https://crrev.com/c836dc519c8e2043e006e5fcb62f3cf48d7e00ce/ui/accessibility/ax_role_properties.h
[modify] https://crrev.com/c836dc519c8e2043e006e5fcb62f3cf48d7e00ce/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/c836dc519c8e2043e006e5fcb62f3cf48d7e00ce/ui/accessibility/platform/ax_platform_node_win.h

Project Member Comment 43 by bugdroid1@chromium.org, Jul 12
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e6b541f1c1347d07ed12751cd8d35c67dc8a102

commit 7e6b541f1c1347d07ed12751cd8d35c67dc8a102
Author: dougt <dougt@chromium.org>
Date: Wed Jul 12 06:03:28 2017

Move IA2 Role handling to AXPlatformNodeWin.

This CL moves all ia2_role handling from BrowserAccessibilityComWin to
AXPlatformNodeWin. In addition, we now forward IAccessible2::role() to
AXPlatformNodeWin as well.

BUG=703369

Review-Url: https://codereview.chromium.org/2965873002
Cr-Commit-Position: refs/heads/master@{#485872}

[modify] https://crrev.com/7e6b541f1c1347d07ed12751cd8d35c67dc8a102/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/7e6b541f1c1347d07ed12751cd8d35c67dc8a102/content/browser/accessibility/browser_accessibility_com_win.h
[modify] https://crrev.com/7e6b541f1c1347d07ed12751cd8d35c67dc8a102/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/7e6b541f1c1347d07ed12751cd8d35c67dc8a102/ui/accessibility/platform/ax_platform_node_win.h

Project Member Comment 44 by bugdroid1@chromium.org, Jul 12
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9344ce7d3f2fe16e08af9a0902423d5d3b27a34c

commit 9344ce7d3f2fe16e08af9a0902423d5d3b27a34c
Author: dougt <dougt@chromium.org>
Date: Wed Jul 12 07:17:14 2017

Converts accNavigate over to the AXPlatformNode code.

This CL switches accNavigate completely over to the AXPlatformNode code.
It also moves the table handling code from BrowserAccessibility to
AXPlatformNodeBase.

BUG=703369

Review-Url: https://codereview.chromium.org/2964313002
Cr-Commit-Position: refs/heads/master@{#485887}

[modify] https://crrev.com/9344ce7d3f2fe16e08af9a0902423d5d3b27a34c/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/9344ce7d3f2fe16e08af9a0902423d5d3b27a34c/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/9344ce7d3f2fe16e08af9a0902423d5d3b27a34c/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/9344ce7d3f2fe16e08af9a0902423d5d3b27a34c/content/browser/accessibility/browser_accessibility_win.cc
[modify] https://crrev.com/9344ce7d3f2fe16e08af9a0902423d5d3b27a34c/content/browser/accessibility/browser_accessibility_win.h
[modify] https://crrev.com/9344ce7d3f2fe16e08af9a0902423d5d3b27a34c/ui/accessibility/platform/ax_platform_node_base.cc
[modify] https://crrev.com/9344ce7d3f2fe16e08af9a0902423d5d3b27a34c/ui/accessibility/platform/ax_platform_node_base.h
[modify] https://crrev.com/9344ce7d3f2fe16e08af9a0902423d5d3b27a34c/ui/accessibility/platform/ax_platform_node_delegate.h
[modify] https://crrev.com/9344ce7d3f2fe16e08af9a0902423d5d3b27a34c/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/9344ce7d3f2fe16e08af9a0902423d5d3b27a34c/ui/accessibility/platform/ax_system_caret_win.cc
[modify] https://crrev.com/9344ce7d3f2fe16e08af9a0902423d5d3b27a34c/ui/accessibility/platform/ax_system_caret_win.h
[modify] https://crrev.com/9344ce7d3f2fe16e08af9a0902423d5d3b27a34c/ui/accessibility/platform/test_ax_node_wrapper.cc
[modify] https://crrev.com/9344ce7d3f2fe16e08af9a0902423d5d3b27a34c/ui/accessibility/platform/test_ax_node_wrapper.h
[modify] https://crrev.com/9344ce7d3f2fe16e08af9a0902423d5d3b27a34c/ui/views/accessibility/native_view_accessibility_auralinux.cc
[modify] https://crrev.com/9344ce7d3f2fe16e08af9a0902423d5d3b27a34c/ui/views/accessibility/native_view_accessibility_base.cc
[modify] https://crrev.com/9344ce7d3f2fe16e08af9a0902423d5d3b27a34c/ui/views/accessibility/native_view_accessibility_base.h

Project Member Comment 45 by bugdroid1@chromium.org, Jul 12
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63ad8c63891cf5c19e7742f1b72940937c6c9784

commit 63ad8c63891cf5c19e7742f1b72940937c6c9784
Author: dougt <dougt@chromium.org>
Date: Wed Jul 12 16:51:23 2017

Forward BrowserAccessibilityWin table APIs to AXPlatformNodeWin.

This CL implements IAccessibleTable, IAccessibleTable2 and
IAccessibleTableCell on AXPlatformNodeWin. It forwards calls on
BrowserAccessibilityWin to this implementation.

BUG=703369

Review-Url: https://codereview.chromium.org/2969113002
Cr-Commit-Position: refs/heads/master@{#485996}

[modify] https://crrev.com/63ad8c63891cf5c19e7742f1b72940937c6c9784/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/63ad8c63891cf5c19e7742f1b72940937c6c9784/content/browser/accessibility/browser_accessibility_com_win.h
[modify] https://crrev.com/63ad8c63891cf5c19e7742f1b72940937c6c9784/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/63ad8c63891cf5c19e7742f1b72940937c6c9784/ui/accessibility/platform/ax_platform_node_win.h
[modify] https://crrev.com/63ad8c63891cf5c19e7742f1b72940937c6c9784/ui/accessibility/platform/ax_platform_node_win_unittest.cc
[modify] https://crrev.com/63ad8c63891cf5c19e7742f1b72940937c6c9784/ui/accessibility/platform/test_ax_node_wrapper.cc
[modify] https://crrev.com/63ad8c63891cf5c19e7742f1b72940937c6c9784/ui/accessibility/platform/test_ax_node_wrapper.h

Project Member Comment 46 by bugdroid1@chromium.org, Jul 17
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05e325468af27dfd72e5090bd94276b14ce2beb4

commit 05e325468af27dfd72e5090bd94276b14ce2beb4
Author: dougt <dougt@chromium.org>
Date: Mon Jul 17 16:58:35 2017

Move Win32 API Histogram code to AXPlatformNode so that it can be shared.

One side effect of this is that we will begin collecting data on API usage
from views (on the APIs we've migrated to platform node).

BUG=703369

Review-Url: https://codereview.chromium.org/2981023002
Cr-Commit-Position: refs/heads/master@{#487123}

[modify] https://crrev.com/05e325468af27dfd72e5090bd94276b14ce2beb4/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/05e325468af27dfd72e5090bd94276b14ce2beb4/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/05e325468af27dfd72e5090bd94276b14ce2beb4/ui/accessibility/platform/ax_platform_node_win.h

Project Member Comment 47 by bugdroid1@chromium.org, Jul 17
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/264fce039d83d045fdaf2d613f72c435aa81d225

commit 264fce039d83d045fdaf2d613f72c435aa81d225
Author: dougt <dougt@chromium.org>
Date: Mon Jul 17 19:35:53 2017

Move ia2_attributes handling to AXPlatformNodeWin.

BUG=703369

Review-Url: https://codereview.chromium.org/2975413002
Cr-Commit-Position: refs/heads/master@{#487194}

[modify] https://crrev.com/264fce039d83d045fdaf2d613f72c435aa81d225/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/264fce039d83d045fdaf2d613f72c435aa81d225/content/browser/accessibility/browser_accessibility_com_win.h
[modify] https://crrev.com/264fce039d83d045fdaf2d613f72c435aa81d225/ui/accessibility/platform/ax_platform_node_base.cc
[modify] https://crrev.com/264fce039d83d045fdaf2d613f72c435aa81d225/ui/accessibility/platform/ax_platform_node_base.h
[modify] https://crrev.com/264fce039d83d045fdaf2d613f72c435aa81d225/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/264fce039d83d045fdaf2d613f72c435aa81d225/ui/accessibility/platform/ax_platform_node_win.h

Project Member Comment 48 by bugdroid1@chromium.org, Jul 19
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ab0dd0c1a9df25e89f2a5f18cf051d7f368eaa4

commit 4ab0dd0c1a9df25e89f2a5f18cf051d7f368eaa4
Author: dougt <dougt@chromium.org>
Date: Wed Jul 19 03:34:09 2017

Remove methods from BrowserAccessibilityComWin which aren't needed.

This is the first larger patch where we can start removing methods from
BrowserAccessibilityComWin that are completely implemented by
AXPlatformNodeWin.

Note, I believe the owner() check that is used in BrowserAccessibilityComWin
is not needed anymore. This is because the AXPlatformNodeWin should be
testing for a valid delegate in all of the exposed COM interfaces.

Also note, that I have removed changing the accessibility mode flags
from some of the unimplemented methods.  I do not believe that this will be
a problem since these methods aren't really used.

There will be a follow up that moves more over after we work out what
to do about handling of the mode flags.

BUG=703369

Review-Url: https://codereview.chromium.org/2981053002
Cr-Commit-Position: refs/heads/master@{#487738}

[modify] https://crrev.com/4ab0dd0c1a9df25e89f2a5f18cf051d7f368eaa4/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/4ab0dd0c1a9df25e89f2a5f18cf051d7f368eaa4/content/browser/accessibility/browser_accessibility_com_win.h
[modify] https://crrev.com/4ab0dd0c1a9df25e89f2a5f18cf051d7f368eaa4/ui/accessibility/platform/ax_platform_node_win.cc

Project Member Comment 49 by bugdroid1@chromium.org, Jul 19
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e1d55ad37f669ddf349799cea5874e015bbe95a

commit 3e1d55ad37f669ddf349799cea5874e015bbe95a
Author: dougt <dougt@chromium.org>
Date: Wed Jul 19 21:14:46 2017

Move BrowserAccessibilityRelation code to the ui/accessibility/

BUG=703369

Review-Url: https://codereview.chromium.org/2981073002
Cr-Commit-Position: refs/heads/master@{#487984}

[modify] https://crrev.com/3e1d55ad37f669ddf349799cea5874e015bbe95a/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/3e1d55ad37f669ddf349799cea5874e015bbe95a/content/browser/accessibility/browser_accessibility_com_win.h
[modify] https://crrev.com/3e1d55ad37f669ddf349799cea5874e015bbe95a/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/3e1d55ad37f669ddf349799cea5874e015bbe95a/ui/accessibility/platform/ax_platform_node_win.h
[modify] https://crrev.com/3e1d55ad37f669ddf349799cea5874e015bbe95a/ui/accessibility/platform/ax_platform_node_win_unittest.cc

Project Member Comment 50 by bugdroid1@chromium.org, Yesterday (47 hours ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b5355784ac527145920d375a2065537c76dea01

commit 8b5355784ac527145920d375a2065537c76dea01
Author: dougt <dougt@chromium.org>
Date: Tue Jul 25 01:29:49 2017

Migrate BrowserAccessibility windows unique id handling to AXPlatformNodeWin.

Global identifiers are allocated out of ui::GetNextAXPlatformNodeUniqueId
currently. Both BrowserAccessibility and the AXPlatform code both independently
Assign a unique id during object creation.

What we want to have happen is for the BrowserAccessibilityComWin class,
and it�s typical owner, the BrowserAccessibilityWin, to share the same unique
id. This makes it easier to reason about as well as necessary to be able to
Implement get_uniqueID().

This CL makes private the |unique_id_| used in both above base classes private
and forces all access through virtual class methods. The BrowserAccessibilityWin
overrides and implements in terms of AXPlatformNodeWin.

BUG=703369

Review-Url: https://codereview.chromium.org/2981083002
Cr-Commit-Position: refs/heads/master@{#489177}

[modify] https://crrev.com/8b5355784ac527145920d375a2065537c76dea01/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/8b5355784ac527145920d375a2065537c76dea01/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/8b5355784ac527145920d375a2065537c76dea01/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/8b5355784ac527145920d375a2065537c76dea01/content/browser/accessibility/browser_accessibility_android.h
[modify] https://crrev.com/8b5355784ac527145920d375a2065537c76dea01/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/8b5355784ac527145920d375a2065537c76dea01/content/browser/accessibility/browser_accessibility_com_win.h
[modify] https://crrev.com/8b5355784ac527145920d375a2065537c76dea01/content/browser/accessibility/browser_accessibility_event.cc
[modify] https://crrev.com/8b5355784ac527145920d375a2065537c76dea01/content/browser/accessibility/browser_accessibility_manager_android.cc
[modify] https://crrev.com/8b5355784ac527145920d375a2065537c76dea01/content/browser/accessibility/browser_accessibility_manager_win.cc
[modify] https://crrev.com/8b5355784ac527145920d375a2065537c76dea01/content/browser/accessibility/browser_accessibility_win_unittest.cc
[modify] https://crrev.com/8b5355784ac527145920d375a2065537c76dea01/content/browser/accessibility/web_contents_accessibility_android.cc
[modify] https://crrev.com/8b5355784ac527145920d375a2065537c76dea01/ui/accessibility/platform/ax_platform_node.cc
[modify] https://crrev.com/8b5355784ac527145920d375a2065537c76dea01/ui/accessibility/platform/ax_platform_node.h
[modify] https://crrev.com/8b5355784ac527145920d375a2065537c76dea01/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/8b5355784ac527145920d375a2065537c76dea01/ui/accessibility/platform/ax_platform_node_win.h

Project Member Comment 51 by bugdroid1@chromium.org, Yesterday (31 hours ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba05045c920078d04b7135144dd14c649bc73727

commit ba05045c920078d04b7135144dd14c649bc73727
Author: dougt <dougt@chromium.org>
Date: Tue Jul 25 16:58:18 2017

Revert of Migrate BrowserAccessibility windows unique id handling to AXPlatformNodeWin. (patchset #4 id:80001 of https://codereview.chromium.org/2981083002/ )

Reason for revert:
Revert due to crbug 748472. Will reland w/ fix after merge to M61 branch.

Original issue's description:
> Migrate BrowserAccessibility windows unique id handling to AXPlatformNodeWin.
>
> Global identifiers are allocated out of ui::GetNextAXPlatformNodeUniqueId
> currently. Both BrowserAccessibility and the AXPlatform code both independently
> Assign a unique id during object creation.
>
> What we want to have happen is for the BrowserAccessibilityComWin class,
> and it�s typical owner, the BrowserAccessibilityWin, to share the same unique
> id. This makes it easier to reason about as well as necessary to be able to
> Implement get_uniqueID().
>
> This CL makes private the |unique_id_| used in both above base classes private
> and forces all access through virtual class methods. The BrowserAccessibilityWin
> overrides and implements in terms of AXPlatformNodeWin.
>
> BUG=703369
>
> Review-Url: https://codereview.chromium.org/2981083002
> Cr-Commit-Position: refs/heads/master@{#489177}
> Committed: https://chromium.googlesource.com/chromium/src/+/8b5355784ac527145920d375a2065537c76dea01

TBR=dmazzoni@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=703369

Review-Url: https://codereview.chromium.org/2988753002
Cr-Commit-Position: refs/heads/master@{#489342}

[modify] https://crrev.com/ba05045c920078d04b7135144dd14c649bc73727/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/ba05045c920078d04b7135144dd14c649bc73727/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/ba05045c920078d04b7135144dd14c649bc73727/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/ba05045c920078d04b7135144dd14c649bc73727/content/browser/accessibility/browser_accessibility_android.h
[modify] https://crrev.com/ba05045c920078d04b7135144dd14c649bc73727/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/ba05045c920078d04b7135144dd14c649bc73727/content/browser/accessibility/browser_accessibility_com_win.h
[modify] https://crrev.com/ba05045c920078d04b7135144dd14c649bc73727/content/browser/accessibility/browser_accessibility_event.cc
[modify] https://crrev.com/ba05045c920078d04b7135144dd14c649bc73727/content/browser/accessibility/browser_accessibility_manager_android.cc
[modify] https://crrev.com/ba05045c920078d04b7135144dd14c649bc73727/content/browser/accessibility/browser_accessibility_manager_win.cc
[modify] https://crrev.com/ba05045c920078d04b7135144dd14c649bc73727/content/browser/accessibility/browser_accessibility_win_unittest.cc
[modify] https://crrev.com/ba05045c920078d04b7135144dd14c649bc73727/content/browser/accessibility/web_contents_accessibility_android.cc
[modify] https://crrev.com/ba05045c920078d04b7135144dd14c649bc73727/ui/accessibility/platform/ax_platform_node.cc
[modify] https://crrev.com/ba05045c920078d04b7135144dd14c649bc73727/ui/accessibility/platform/ax_platform_node.h
[modify] https://crrev.com/ba05045c920078d04b7135144dd14c649bc73727/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/ba05045c920078d04b7135144dd14c649bc73727/ui/accessibility/platform/ax_platform_node_win.h

Sign in to add a comment