New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703359 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature



Sign in to add a comment

Move userAgent method from cwv_delegate to cwv_web_view class per API doc.

Project Member Reported by michaeldo@chromium.org, Mar 20 2017

Issue description

UserAgent method should be part of CWVWebView API per API doc.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cb7e8847ef119d5b997c9d9964457c69b622adb

commit 8cb7e8847ef119d5b997c9d9964457c69b622adb
Author: michaeldo <michaeldo@chromium.org>
Date: Wed Apr 05 00:17:47 2017

Remove CWVDelegate.

BUG= 703359 

Review-Url: https://codereview.chromium.org/2800433002
Cr-Commit-Position: refs/heads/master@{#461910}

[modify] https://crrev.com/8cb7e8847ef119d5b997c9d9964457c69b622adb/ios/web_view/BUILD.gn
[modify] https://crrev.com/8cb7e8847ef119d5b997c9d9964457c69b622adb/ios/web_view/internal/cwv.mm
[modify] https://crrev.com/8cb7e8847ef119d5b997c9d9964457c69b622adb/ios/web_view/internal/web_view_web_client.h
[modify] https://crrev.com/8cb7e8847ef119d5b997c9d9964457c69b622adb/ios/web_view/internal/web_view_web_client.mm
[modify] https://crrev.com/8cb7e8847ef119d5b997c9d9964457c69b622adb/ios/web_view/internal/web_view_web_main_delegate.h
[modify] https://crrev.com/8cb7e8847ef119d5b997c9d9964457c69b622adb/ios/web_view/internal/web_view_web_main_delegate.mm
[modify] https://crrev.com/8cb7e8847ef119d5b997c9d9964457c69b622adb/ios/web_view/internal/web_view_web_main_parts.h
[modify] https://crrev.com/8cb7e8847ef119d5b997c9d9964457c69b622adb/ios/web_view/internal/web_view_web_main_parts.mm
[modify] https://crrev.com/8cb7e8847ef119d5b997c9d9964457c69b622adb/ios/web_view/public/cwv.h
[delete] https://crrev.com/131f7de1b67282e70b34c8281601e099a30101ba/ios/web_view/public/cwv_delegate.h
[modify] https://crrev.com/8cb7e8847ef119d5b997c9d9964457c69b622adb/ios/web_view/shell/BUILD.gn
[modify] https://crrev.com/8cb7e8847ef119d5b997c9d9964457c69b622adb/ios/web_view/shell/shell_app_delegate.m
[delete] https://crrev.com/131f7de1b67282e70b34c8281601e099a30101ba/ios/web_view/shell/shell_delegate.h
[delete] https://crrev.com/131f7de1b67282e70b34c8281601e099a30101ba/ios/web_view/shell/shell_delegate.m

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f21fa55c1594deac368f09c8847b451bea0c1bc2

commit f21fa55c1594deac368f09c8847b451bea0c1bc2
Author: michaeldo <michaeldo@chromium.org>
Date: Sat Apr 15 01:45:12 2017

Remove CWV class and move setting User Agent to CWVWebViewConfiguration.
Move Browser State and Web Client ownership to CWVWebViewConfiguration.
CWVWebViewConfiguration will now create it’s own browser state and will not
share a browser state between copies of the configuration.

BUG= 690182 ,  703359 , 706287

Review-Url: https://codereview.chromium.org/2791403005
Cr-Commit-Position: refs/heads/master@{#464848}

[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/BUILD.gn
[delete] https://crrev.com/c77104dfbdbdb4e4952dad12fa2d2352a07e65ff/ios/web_view/internal/cwv.mm
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/internal/cwv_web_view.mm
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/internal/cwv_web_view_configuration.mm
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/internal/web_view_browser_state.mm
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/internal/web_view_web_client.h
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/internal/web_view_web_client.mm
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/internal/web_view_web_main_delegate.h
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/internal/web_view_web_main_delegate.mm
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/internal/web_view_web_main_parts.h
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/internal/web_view_web_main_parts.mm
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/public/ChromeWebView.h
[delete] https://crrev.com/c77104dfbdbdb4e4952dad12fa2d2352a07e65ff/ios/web_view/public/cwv.h
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/public/cwv_web_view.h
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/shell/shell_app_delegate.m
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/shell/shell_view_controller.m

Status: Fixed (was: Started)

Sign in to add a comment