New issue
Advanced search Search tips

Issue 703346 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocked on:
issue 748715
issue 750779

Blocking:
issue 708584
issue 552633
issue 587199



Sign in to add a comment

Add RunLoop support to TestMockTimeTaskRunner (first: decouple MessageLoop <=> RunLoop)

Project Member Reported by gab@chromium.org, Mar 20 2017

Issue description

Today: ScopedMockTimeMessageLoopTaskRunner fails to properly replace MessageLoop's TaskRunner because TestMockTimeTaskRunner doesn't support RunLoop() (using it ends up running an empty queue).

Coming up: base::test::ScopedTaskEnvironment will also require the ability to drive the main thread via RunLoop() (https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit).
 

Comment 1 by gab@chromium.org, Apr 10 2017

Labels: -Pri-3 Pri-1
Status: Started (was: Assigned)
This is required to fix

content_unittests.exe --gtest_filter=MojoAsyncResourceHandlerUploadTest.UploadProgressHandling

in https://codereview.chromium.org/2491613004/ (Fix TaskRunner race in base::Timer and make it sequence-friendly).

The best way to fix that test is to make it override the main message loop's task runner but that breaks the underlying call to ControlMessageProxy::FlushForTesting() which correctly assumes RunLoop+SendMessage to ThreadTaskRunnerHandle with QuitClosure should work...

Comment 2 by gab@chromium.org, Apr 11 2017

Blocking: 552633 708584 587199

Comment 3 by gab@chromium.org, Apr 11 2017

Summary: Add RunLoop support to TestMockTimeTaskRunner (first: decouple MessageLoop <=> RunLoop) (was: Add RunLoop support to TestMockTimeTaskRunner)
Project Member

Comment 4 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7af9dc076d2349ade19a95e24f6ee6811e939765

commit 7af9dc076d2349ade19a95e24f6ee6811e939765
Author: gab <gab@chromium.org>
Date: Fri May 05 13:38:54 2017

Make nesting/running states a RunLoop rather than a MessageLoop concept.

First CL of a series to split inter-dependency between RunLoop and MessageLoop.

Also modernized bluetooth_socket_bluez_unittest.cc away from using deprecated MessageLoop Quit
methods on its fixture's MessageLoop member to ease transition.

Lastly, tried to add thread safety checks for documentation purposes but turns
out there are already improper usage of the API... those will have to be
addressed first through issue 715235.

https://codereview.chromium.org/2828913003 follows to
s/nested message loop/nested run loop/ in comments.

BUG= 703346 , 715235

Review-Url: https://codereview.chromium.org/2818533003
Cr-Commit-Position: refs/heads/master@{#469636}

[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/base/message_loop/message_loop.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/base/message_loop/message_loop.h
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/base/message_loop/message_loop_test.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/base/message_loop/message_loop_test.h
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/base/run_loop.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/base/run_loop.h
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/base/run_loop_unittest.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/chrome/browser/app_controller_mac.mm
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/chrome/browser/metrics/chromeos_metrics_provider_unittest.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/chrome/browser/ui/views/simple_message_box_views.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/chromeos/dbus/services/service_provider_test_helper.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/components/omnibox/browser/autocomplete_provider_unittest.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/components/sync/engine_impl/sync_scheduler_impl_unittest.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/content/browser/browser_main_runner.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/content/browser/browser_thread_impl.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/device/bluetooth/bluez/bluetooth_adapter_profile_bluez_unittest.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/device/bluetooth/bluez/bluetooth_advertisement_bluez_unittest.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/device/bluetooth/bluez/bluetooth_bluez_unittest.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/device/bluetooth/bluez/bluetooth_socket_bluez_unittest.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/device/bluetooth/test/test_bluetooth_adapter_observer.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/extensions/browser/api/alarms/alarms_api_unittest.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/mash/quick_launch/quick_launch.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/mojo/public/cpp/bindings/connector.h
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/mojo/public/cpp/bindings/lib/connector.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/services/service_manager/tests/lifecycle/package.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/services/ui/service.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/storage/browser/fileapi/file_system_operation_impl_write_unittest.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/core/frame/PerformanceMonitor.h
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator.h
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator_unittest.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_delegate.h
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_delegate_for_test.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_delegate_for_test.h
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/base/task_time_observer.h
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/base/test_task_time_observer.h
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/child/scheduler_tqm_delegate_for_test.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/child/scheduler_tqm_delegate_for_test.h
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/child/scheduler_tqm_delegate_impl.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/child/scheduler_tqm_delegate_impl.h
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.h
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/third_party/WebKit/Source/platform/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.h
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/ui/aura/mus/mus_mouse_location_updater.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/ui/aura/mus/mus_mouse_location_updater.h
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/7af9dc076d2349ade19a95e24f6ee6811e939765/ui/aura/window_event_dispatcher_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be

commit 2998ee7b318fc904fdaf9faa3db5b4201a3fa5be
Author: gab <gab@chromium.org>
Date: Fri May 05 16:23:50 2017

Replace "nested message loop" with "nested run loop" in comments.

Following https://codereview.chromium.org/2818533003/

BUG= 703346 
TBR=danakj@chromium.org

Review-Url: https://codereview.chromium.org/2828913003
Cr-Commit-Position: refs/heads/master@{#469674}

[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ash/drag_drop/drag_drop_controller.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ash/drag_drop/drag_drop_controller.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ash/root_window_controller.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ash/wm/toplevel_window_event_handler.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/base/message_loop/message_loop.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/base/message_loop/message_loop.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/base/message_loop/message_pump_win.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/base/run_loop.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/chrome/browser/app_controller_mac.mm
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/chrome/browser/autocomplete/search_provider_unittest.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/chrome/browser/chrome_navigation_browsertest.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/chrome/browser/extensions/api/notifications/notifications_apitest.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/chrome/browser/media/webrtc/desktop_capture_access_handler.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/chrome/browser/printing/print_job.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/chrome/browser/printing/print_job.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/chrome/browser/sessions/session_restore.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/chrome/browser/subresource_filter/test_ruleset_publisher.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/chrome/browser/sync/test/integration/status_change_checker.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/chrome/browser/ui/app_list/test/chrome_app_list_test_support.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop_cocoa.mm
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/chrome/browser/ui/views/certificate_viewer_win.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/chrome/browser/ui/views/chrome_views_delegate_win.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/chrome/browser/ui/views/frame/taskbar_decorator_win.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/chrome/browser/ui/views/tabs/tab_drag_controller.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/components/history/core/browser/top_sites_impl_unittest.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/components/printing/common/print_messages.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/components/printing/renderer/print_web_view_helper.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/content/browser/renderer_host/delegated_frame_host_client_aura.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/content/public/browser/web_contents.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/content/public/test/android/javatests/src/org/chromium/content/browser/test/NestedSystemMessageHandler.java
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/content/public/test/browser_test_base.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/content/public/test/test_download_request_handler.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/content/public/test/test_frame_navigation_observer.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/content/public/test/test_navigation_observer.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/content/renderer/pepper/host_globals.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/content/renderer/pepper/ppb_flash_message_loop_impl.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/content/renderer/render_frame_impl.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/content/shell/browser/layout_test/blink_test_controller.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/extensions/test/result_catcher.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ipc/ipc_sync_channel.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ipc/ipc_sync_channel.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/mojo/public/cpp/bindings/lib/connector.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/native_client_sdk/doc_generated/pepper_beta/c/struct_p_p_b___message_loop__1__0.html
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/native_client_sdk/doc_generated/pepper_beta/cpp/classpp_1_1_message_loop.html
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/native_client_sdk/doc_generated/pepper_dev/c/struct_p_p_b___message_loop__1__0.html
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/native_client_sdk/doc_generated/pepper_dev/cpp/classpp_1_1_message_loop.html
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/native_client_sdk/doc_generated/pepper_stable/c/struct_p_p_b___message_loop__1__0.html
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/native_client_sdk/doc_generated/pepper_stable/cpp/classpp_1_1_message_loop.html
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ppapi/api/ppb_message_loop.idl
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ppapi/api/private/ppb_flash_message_loop.idl
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ppapi/api/private/ppb_testing_private.idl
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ppapi/c/ppb_message_loop.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ppapi/c/private/ppb_flash_message_loop.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ppapi/c/private/ppb_testing_private.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ppapi/cpp/message_loop.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ppapi/proxy/flash_menu_resource.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ppapi/tests/test_case.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ppapi/tests/test_graphics_2d.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ppapi/tests/test_utils.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ppapi/tests/test_view.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/services/ui/ws/window_manager_client_unittest.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/third_party/WebKit/Source/core/page/CreateWindow.cpp
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/third_party/WebKit/Source/platform/PluginScriptForbiddenScope.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator_unittest.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_delegate.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/third_party/WebKit/Source/platform/scheduler/base/task_time_observer.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/third_party/WebKit/Source/web/tests/TouchActionTest.cpp
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/aura/mus/drag_drop_controller_mus.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/aura/mus/mus_mouse_location_updater.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/aura/window_event_dispatcher.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/aura/window_event_dispatcher_unittest.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/base/clipboard/clipboard_aurax11.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/base/win/shell.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/base/x/selection_requestor.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/events/test/event_generator.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/views/controls/menu/menu_controller.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/views/controls/menu/menu_controller_unittest.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/views/controls/menu/menu_runner.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/views/controls/menu/menu_runner_cocoa_unittest.mm
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/views/controls/menu/menu_runner_impl.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/views/controls/menu/menu_runner_impl_interface.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/views/widget/desktop_aura/x11_move_loop.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/views/widget/widget.h
[modify] https://crrev.com/2998ee7b318fc904fdaf9faa3db5b4201a3fa5be/ui/wm/public/window_move_client.h

Project Member

Comment 6 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/968d9ebc4d22158616e9f55d01313f0973d13fea

commit 968d9ebc4d22158616e9f55d01313f0973d13fea
Author: gab <gab@chromium.org>
Date: Fri May 05 19:24:10 2017

Fix RunLoopTest.DisallowWaitingDeathTest for official builds.

Official builds eat the error string of the CHECKs.

BUG= 703346 
TBR=danakj@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2857393006
Cr-Commit-Position: refs/heads/master@{#469754}

[modify] https://crrev.com/968d9ebc4d22158616e9f55d01313f0973d13fea/base/run_loop_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f64a25e32afb6f3fd7141cdf589b402290fee16a

commit f64a25e32afb6f3fd7141cdf589b402290fee16a
Author: gab <gab@chromium.org>
Date: Fri May 12 19:43:18 2017

Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False
  if 'class MessageLoopForUI;' in content:
    return False
  if 'class MessageLoopForIO;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(\n *[^/\n][^/\n][^/\n]*base::MessageLoop(ForUI|ForIO)?\b[^*])', re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in headers in first pass...
  if os.path.splitext(file_path)[1] == '.h':
    found = False
    for match in matches:
      if not 'std::unique_ptr<base::MessageLoop' in match[0]:
        found = True
        break
    if not found:
      return False

  updated_content = refactor_lib.AddInclude(file_path, content, "base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

TBR=gab@chromium.org
BUG= 703346 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2876013002
Cr-Commit-Position: refs/heads/master@{#471412}

[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/android_webview/browser/test/rendering_test.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/ash/autoclick/mus/autoclick_application.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/ash/touch_hud/mus/touch_hud_application.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/base/cancelable_callback_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/base/deferred_sequenced_task_runner_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/base/files/file_path_watcher_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/base/task_runner_util_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/base/test/test_io_thread.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/base/threading/thread_perftest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/base/trace_event/blame_context_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/base/trace_event/trace_event_system_stats_monitor_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/cc/test/layer_tree_test.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/app_controller_mac_browsertest.mm
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/apps/app_window_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/autofill/autofill_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/autofill/autofill_uitest_util.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/chrome_browser_main_android.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/chromeos/arc/intent_helper/arc_settings_service_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/chromeos/customization/customization_wallpaper_downloader_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/chromeos/input_method/textinput_test_helper.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/chromeos/login/lock/screen_locker_tester.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/chromeos/login/saml/saml_offline_signin_limiter_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/chromeos/net/client_cert_store_chromeos_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/chromeos/net/network_state_notifier_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/conflicts/module_inspector_win_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/devtools/device/adb/mock_adb_server.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/devtools/device/android_device_manager.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/devtools/device/port_forwarding_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/devtools/device/usb/android_usb_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/devtools/devtools_sanity_interactive_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/extensions/activity_log/counting_policy_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/extensions/api/downloads/downloads_api.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/extensions/api/feedback_private/feedback_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/extensions/api/notifications/notifications_apitest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/extensions/api/socket/udp_socket_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/extensions/api/tabs/tabs_test.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/extensions/api/top_sites/top_sites_apitest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/extensions/app_data_migrator_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/extensions/crx_installer_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/extensions/error_console/error_console_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/extensions/extension_storage_monitor_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/extensions/extension_user_script_loader_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/extensions/permissions_updater_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/geolocation/access_token_store_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/geolocation/geolocation_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/history/android/sqlite_cursor_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/history/redirect_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/importer/profile_writer_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/local_discovery/local_domain_resolver_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/local_discovery/service_discovery_client_mac.mm
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/local_discovery/service_discovery_client_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/media/webrtc/tab_desktop_media_list_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/media_galleries/fileapi/itunes_file_util_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/net/predictor_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/net/sdch_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/password_manager/password_store_mac_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/plugins/plugin_power_saver_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/policy/cloud/cloud_policy_invalidator_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/policy/profile_policy_connector_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/prefs/profile_pref_store_manager_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/printing/cloud_print/privet_http_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/printing/cloud_print/privet_notifications_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/printing/cloud_print/privet_url_fetcher_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/printing/print_view_manager_base.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/profiles/profile_list_desktop_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/profiles/profile_manager_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/profiles/profile_window_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/safe_browsing/certificate_reporting_service_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/safe_browsing/incident_reporting/platform_state_store_win_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/service_process/service_process_control_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/sessions/session_restore.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/sessions/session_service_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/ssl/ssl_browser_tests.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/sync/test/integration/bookmarks_helper.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/sync/test/integration/passwords_helper.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/sync_file_system/drive_backend/callback_helper_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/ui/desktop_ios_promotion/sms_service_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/ui/search/instant_extended_interactive_uitest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/ui/views/first_run_bubble_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/ui/views/menu_model_adapter_test.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/browser/ui/webui/web_ui_test_handler.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/chrome_watcher/chrome_watcher_main.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/common/service_process_util_mac_unittest.mm
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/common/service_process_util_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/service/service_process.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/test/base/chrome_unit_test_suite.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/test/chromedriver/commands_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chrome/utility/image_writer/image_writer_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chromecast/browser/cast_media_blocker_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chromecast/media/audio/cast_audio_mixer_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chromecast/media/audio/cast_audio_output_stream_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chromecast/media/cma/backend/alsa/volume_control.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chromecast/media/cma/base/balanced_media_task_runner_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chromecast/media/cma/base/buffering_frame_provider_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chromecast/media/cma/base/demuxer_stream_adapter_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chromecast/media/cma/base/multi_demuxer_stream_adapter_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chromeos/dbus/biod/biod_client_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chromeos/dbus/dbus_thread_manager.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chromeos/network/client_cert_resolver_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chromeos/network/host_resolver_impl_chromeos_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chromeos/network/network_cert_migrator_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chromeos/process_proxy/process_output_watcher_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chromeos/process_proxy/process_proxy_registry.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/chromeos/process_proxy/process_proxy_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/autofill/core/browser/autofill_download_manager_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/autofill/core/browser/webdata/web_data_service_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/bookmarks/test/bookmark_test_helpers.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/browser_sync/profile_sync_service_startup_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/browser_sync/profile_sync_service_typed_url_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/browser_sync/test_profile_sync_service.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/browser_watcher/window_hang_monitor_win_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/certificate_reporting/error_report_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/certificate_transparency/ct_policy_manager_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/cronet/android/test/quic_test_server.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/data_reduction_proxy/content/browser/content_resource_type_provider_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/dom_distiller/core/task_tracker_unittest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/dom_distiller/standalone/content_extractor_browsertest.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/exo/wayland/server.cc
[modify] https://crrev.com/f64a25e32afb6f3fd7141cdf589b402290fee16a/components/gcm_driver/gcm_driver_desktop_unittest.cc
[modify] https://crrev.com/f64a25e32afb
Project Member

Comment 8 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec

commit 5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec
Author: Gabriel Charette <gab@chromium.org>
Date: Tue May 16 18:05:52 2017

Automated IWYU fix for TaskRunner includes.

Pre-requisite to suppress message_loop.h from run_loop.h ( issue 703346 ).

A similar include fix for message_loop.h was done in r471412 but some
targets are the removal as it looks like they properly didn't need
message_loop.h but were relying on it to get task runner includes...

The reasoning for this is the same as was once done in https://codereview.chromium.org/2443103003
(it was then done only on targets that failed to compile instead of via script):
scoped_refptr<Foo> requires full type of Foo to be defined not just fwd-declared.

Script used:

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  if not 'TaskRunner' in content:
    return False

  # Assume fwd-decls are correct in first pass.
  if 'class TaskRunner;' in content:
    return False
  if 'class SequencedTaskRunner;' in content:
    return False
  if 'class SingleThreadTaskRunner;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(private:|protected:|public:)|(\n *[^/\n][^/\n][^/\n]*base::(Sequenced|SingleThread)TaskRunner\b(>&|\*)?)', re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore instances in private sections (probably members or worst case methods
  # only used by impl which must include header already).
  in_private_section = False

  found_task_runner = False
  found_sequenced_task_runner = False
  found_single_thread_task_runner = False
  for match in matches:
    if match[0] == 'private:':
      in_private_section = True
      continue
    if match[0] == 'protected:':
      in_private_section = False
      continue
    if match[0] == 'public:':
      in_private_section = False
      continue

    # Otherwise match[0] was empty and we have a match[1] for the main thing.
    assert not match[0]

    # Only want to add the include if we don't have a match[3] (which indicates
    # this match is for a ref or a pointer).
    if match[3]:
      continue

    # Not a ref nor a pointer, count it if not in a private section, match[2]
    # tells which TaskRunner type it is.
    if not in_private_section:
      if not match[2]:
        found_task_runner = True
      elif match[2] == 'Sequenced':
        found_sequenced_task_runner = True
      elif match[2] == 'SingleThread':
        found_single_thread_task_runner = True
      else:
        assert False

  updated_content = content

  if found_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content, "base/task_runner.h")
  if found_sequenced_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content, "base/sequenced_task_runner.h")
  if found_single_thread_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content, "base/single_thread_task_runner.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

TBR=gab@chromiu.org
BUG= 703346 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2884763002 .
Cr-Commit-Position: refs/heads/master@{#472157}

[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/android_webview/browser/aw_browser_context.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/android_webview/browser/net/aw_url_request_context_getter.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/ash/mojo_interface_factory.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/base/trace_event/memory_dump_manager_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/cc/benchmarks/unittest_only_benchmark.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/cc/layers/surface_layer.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/cc/resources/resource_pool_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/cc/test/fake_impl_task_runner_provider.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/cc/test/fake_layer_tree_host.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/cc/test/fake_layer_tree_host_impl.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/cc/test/test_compositor_frame_sink.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/cc/tiles/image_controller.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/cc/tiles/tile_manager.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/cc/trees/layer_tree_host.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/chrome_browser_main_linux.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/chromeos/arc/extensions/arc_support_message_host.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/chromeos/extensions/external_cache_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/chromeos/policy/device_local_account_policy_store.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/chromeos/settings/session_manager_operation.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/chromeos/system_logs/debug_log_writer.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/component_updater/chrome_component_updater_configurator.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/component_updater/subresource_filter_component_installer_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/devtools/device/cast_device_provider.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/dom_distiller/dom_distiller_service_factory.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/extensions/api/messaging/native_message_host_chromeos.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/extensions/api/messaging/native_message_process_host.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/extensions/updater/local_extension_cache_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/gcm/gcm_profile_service_factory.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/gcm/gcm_profile_service_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/io_thread.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/media_galleries/fileapi/native_media_file_util.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/media_galleries/fileapi/safe_iapps_library_parser.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/metrics/network_quality_estimator_provider_impl.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/net/chrome_url_request_context_getter.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/net/predictor_browsertest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/password_manager/password_store_factory.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/password_manager/password_store_mac.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/password_manager/password_store_proxy_mac.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/password_manager/password_store_win.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/password_manager/password_store_x.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/password_manager/simple_password_store_mac.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/password_manager/simple_password_store_mac_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/profiles/off_the_record_profile_impl.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_browsertest_win.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/safe_browsing/download_feedback_service_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/safe_browsing/protocol_manager_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/search/suggestions/suggestions_service_factory.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/search/thumbnail_source.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/task_manager/sampling/task_group_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/thumbnails/thumbnail_list_source.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/ui/webui/net_export_ui.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/browser/ui/webui/theme_source.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/renderer/chrome_mock_render_thread.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/renderer/media/cast_threads.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/service/service_process.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/test/chromedriver/net/url_request_context_getter.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chrome/test/chromedriver/server/http_handler.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chromecast/base/alarm_manager.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chromecast/browser/cast_content_browser_client.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chromecast/browser/pref_service_helper.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chromecast/browser/url_request_context_factory.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chromeos/accelerometer/accelerometer_reader.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/chromeos/network/proxy/proxy_config_service_impl.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/autofill/core/browser/autofill_wallet_data_type_controller.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/autofill/core/browser/webdata/autofill_data_type_controller.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/autofill/core/browser/webdata/autofill_profile_data_type_controller.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/browser_sync/profile_sync_components_factory_impl.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/browser_sync/profile_sync_service_autofill_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/browser_sync/profile_sync_service_typed_url_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/browser_sync/profile_sync_test_util.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/drive/chromeos/search_metadata.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/grpc_support/test/get_stream_engine.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/invalidation/impl/invalidation_notifier.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/invalidation/impl/unacked_invalidation_set_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/leveldb/leveldb_service_impl.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/metrics/metrics_service.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/metrics/metrics_state_manager.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/metrics/net/network_metrics_provider.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/offline_pages/core/background/request_queue_store_sql.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/offline_pages/core/offline_page_metadata_store_sql.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/os_crypt/os_crypt_linux.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/password_manager/core/browser/password_store_default.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/password_manager/core/browser/webdata/password_web_data_service_win.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/policy/core/common/cloud/cloud_policy_manager_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/policy/core/common/cloud/component_cloud_policy_store.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/policy/core/common/cloud/mock_user_cloud_policy_store.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/policy/core/common/cloud/policy_header_service.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/policy/core/common/cloud/user_cloud_policy_store.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/policy/core/common/cloud/user_cloud_policy_store_base.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/policy/core/common/config_dir_policy_loader.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/policy/core/common/policy_loader_ios.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/policy/core/common/policy_loader_ios_unittest.mm
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/policy/core/common/policy_loader_mac_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/policy/core/common/policy_loader_win_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/previews/core/previews_opt_out_store_sql.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/safe_browsing/password_protection/password_protection_service_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/signin/core/browser/signin_cookie_changed_subscription.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/subresource_filter/content/browser/content_ruleset_service.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/sync/model/attachments/attachment_service_proxy_for_test.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/sync/model/attachments/attachment_store.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/ui_devtools/devtools_server.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/update_client/component_patcher.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/update_client/component_patcher_operation.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/update_client/component_patcher_unittest.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/wallpaper/wallpaper_color_calculator_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/wifi/fake_wifi_service.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/wifi/wifi_service_mac.mm
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/components/wifi/wifi_service_win.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/cache_storage/cache_storage_blob_to_disk_cache_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/cache_storage/cache_storage_context_impl.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/cache_storage/cache_storage_manager.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/compositor/software_browser_compositor_output_surface.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/devtools/browser_devtools_agent_host.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/dom_storage/local_storage_context_mojo.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/download/url_downloader.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/fileapi/browser_file_system_helper_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/gpu/browser_gpu_channel_host_factory.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/gpu/browser_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/gpu/shader_cache_factory.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/media/capture/desktop_capture_device.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/net/quota_policy_cookie_store.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/net/quota_policy_cookie_store_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/renderer_host/media/audio_input_renderer_host_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/renderer_host/media/in_process_launched_video_capture_device.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/renderer_host/media/in_process_video_capture_device_launcher.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/renderer_host/media/in_process_video_capture_provider.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/renderer_host/media/renderer_audio_output_stream_factory_context_impl_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/startup_task_runner_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/tracing/memory_tracing_browsertest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/webui/shared_resources_data_source.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/browser/webui/web_ui_url_loader_factory.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/child/blink_platform_impl.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/child/indexed_db/indexed_db_callbacks_impl.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/child/indexed_db/webidbdatabase_impl.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/child/indexed_db/webidbfactory_impl.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/child/url_response_body_consumer_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/gpu/gpu_child_thread.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/public/renderer/render_thread.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/public/test/mock_render_thread.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/public/test/test_browser_context.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/renderer/categorized_worker_pool_unittest.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/renderer/input/main_thread_event_queue.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/renderer/media/android/media_player_renderer_client.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/renderer/media/android/media_player_renderer_client_factory.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/renderer/media/android/stream_texture_wrapper_impl.h
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/renderer/media/pepper_to_video_track_adapter.cc
[modify] https://crrev.com/5ff87ceb5f871cfd111b0d057eaf04d25ccb17ec/content/renderer/media/renderer_
Project Member

Comment 9 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27355196d32f75606b3e43b54bd0d03ef42b4579

commit 27355196d32f75606b3e43b54bd0d03ef42b4579
Author: gab <gab@chromium.org>
Date: Thu May 18 06:01:10 2017

Introduce RunLoop::Delegate splitting RunLoop/MessageLoop some more.

Separates RunLoop/MessageLoop further. Still some interdependencies to address
but this drops friend class RunLoop; from MessageLoop :).

It also moves the relevant state from TLS back onto the MessageLoop instance
(hidden as private data in RunLoop::Delegate). This is easier to manage
and ensures cleanup when MessageLoop goes away (particularly important in unit
tests).

BUG= 703346 ,  719530 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=phajdan.jr@chromium.org for content\public\test\cache_test_util.h fwd-decl nit

Review-Url: https://codereview.chromium.org/2880453003
Cr-Commit-Position: refs/heads/master@{#472695}

[modify] https://crrev.com/27355196d32f75606b3e43b54bd0d03ef42b4579/base/message_loop/message_loop.cc
[modify] https://crrev.com/27355196d32f75606b3e43b54bd0d03ef42b4579/base/message_loop/message_loop.h
[modify] https://crrev.com/27355196d32f75606b3e43b54bd0d03ef42b4579/base/run_loop.cc
[modify] https://crrev.com/27355196d32f75606b3e43b54bd0d03ef42b4579/base/run_loop.h
[modify] https://crrev.com/27355196d32f75606b3e43b54bd0d03ef42b4579/components/download/internal/scheduler/network_listener_unittest.cc
[modify] https://crrev.com/27355196d32f75606b3e43b54bd0d03ef42b4579/content/public/test/cache_test_util.h

Comment 10 by gab@chromium.org, Jul 25 2017

Blockedon: 748715

Comment 11 by gab@chromium.org, Jul 31 2017

Blockedon: 750779
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2b632b52572c12f4a2c130e557ac2a0f1ca2358

commit e2b632b52572c12f4a2c130e557ac2a0f1ca2358
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Aug 02 03:52:16 2017

Make RunLoop 100% standalone.

MessageLoop is no longer a friend of RunLoop :)!

The only minor dependency remaining shows up in tests as allowing
nestable tasks in a scope (different from allowing nested loops on a
thread in general) is still a MessageLoop concept. I plan to move that
to RunLoop as well in a follow-up.

R=danakj@chromium.org

Bug:  703346 
Change-Id: I0a6269c94de179d97c14855499edd70be9e1d1af
Reviewed-on: https://chromium-review.googlesource.com/594352
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491258}
[modify] https://crrev.com/e2b632b52572c12f4a2c130e557ac2a0f1ca2358/base/message_loop/message_loop.cc
[modify] https://crrev.com/e2b632b52572c12f4a2c130e557ac2a0f1ca2358/base/run_loop.cc
[modify] https://crrev.com/e2b632b52572c12f4a2c130e557ac2a0f1ca2358/base/run_loop.h
[modify] https://crrev.com/e2b632b52572c12f4a2c130e557ac2a0f1ca2358/base/run_loop_unittest.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4497505959f854d186f55150deed36474225842

commit a4497505959f854d186f55150deed36474225842
Author: Gabriel Charette <gab@chromium.org>
Date: Mon Aug 21 23:14:04 2017

Make TestMockTimeTaskRunner a RunLoop::Delegate.

Introducing TestMockTimeTaskRunner::Type::kBound which will make that
TestMockTimeTaskRunner takeover the thread it's created on (a la
MessageLoop), enabling RunLoop and Thread/SequencedTaskRunnerHandle.

Also introduces RunLoop::ScopedDisallowRunningForTesting to enforce
mutual exclusion TestMockTimeTaskRunner::ScopedContext (used to toggle
context to another task runner on the main thread) and RunLoop::Run()
(meant to run the current thread's associated task runner). Mixing the
two would result in running the incorrect task runner. While I don't
think this is a use case worth supporting, experience with //base
APIs has taught me that if there's a way to use it wrong, someone
will, and it's much easier to prevent than to heal; hence this check.
(there should already be no RunLoop usage during TaskRunnerHandle 
overrides per RunLoop not being previously supported by 
TestMockTimeTaskRunner and this check ensures it stays that way :))

EDIT: Well except that HeartbeatSenderTest had found a way to use it
the deprecated way, but it's a nice fit for using a kBound 
TestMockTimeTaskRunner so all good :).

Had to drop support for virtual 
TestMockTimeTaskRunner::IsElapsingStopped() which in turn forced
removal of custom task runner in remote_commands_service_unittest.cc
whose use case is now supported by the new API :).

This enables follow-ups to:
 1) Add mock time to base::test::ScopedTaskEnvironment :)
    https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit
 2) Fixing a race in base::Timer which requires RunLoop from
    TestMockTimeTaskRunner to get rid of the two remaining problematic
    use cases (see bug blocked by 703346).

Bug:  703346 
Change-Id: I062b77b669853a36c30813e44dd984d01fcefbe2

TBR=pastarmovj@chromium.org (for components/policy test side-effects)

Change-Id: I062b77b669853a36c30813e44dd984d01fcefbe2
Reviewed-on: https://chromium-review.googlesource.com/614788
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496111}
[modify] https://crrev.com/a4497505959f854d186f55150deed36474225842/PRESUBMIT.py
[modify] https://crrev.com/a4497505959f854d186f55150deed36474225842/base/BUILD.gn
[modify] https://crrev.com/a4497505959f854d186f55150deed36474225842/base/run_loop.cc
[modify] https://crrev.com/a4497505959f854d186f55150deed36474225842/base/run_loop.h
[modify] https://crrev.com/a4497505959f854d186f55150deed36474225842/base/run_loop_unittest.cc
[modify] https://crrev.com/a4497505959f854d186f55150deed36474225842/base/test/scoped_mock_time_message_loop_task_runner.h
[modify] https://crrev.com/a4497505959f854d186f55150deed36474225842/base/test/test_mock_time_task_runner.cc
[modify] https://crrev.com/a4497505959f854d186f55150deed36474225842/base/test/test_mock_time_task_runner.h
[add] https://crrev.com/a4497505959f854d186f55150deed36474225842/base/test/test_mock_time_task_runner_unittest.cc
[modify] https://crrev.com/a4497505959f854d186f55150deed36474225842/base/threading/thread_task_runner_handle.cc
[modify] https://crrev.com/a4497505959f854d186f55150deed36474225842/components/policy/core/common/remote_commands/remote_commands_service_unittest.cc
[modify] https://crrev.com/a4497505959f854d186f55150deed36474225842/remoting/host/heartbeat_sender_unittest.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc7820af772d69d0d3d8293c7aeef769a221947a

commit cc7820af772d69d0d3d8293c7aeef769a221947a
Author: Gabriel Charette <gab@chromium.org>
Date: Mon Aug 28 15:55:22 2017

Fix QuitWhenIdle() from empty in new kBoundToThread TestMockTimeTaskRunner mode.

(forgot to signal CV in CL introducing kBoundToThread...)

R=dcheng@chromium.org

Bug:  703346 
Change-Id: I017c633c0377d3f9694cc37cb1cb487a9ba029cd
Reviewed-on: https://chromium-review.googlesource.com/636857
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497766}
[modify] https://crrev.com/cc7820af772d69d0d3d8293c7aeef769a221947a/base/test/test_mock_time_task_runner.cc
[modify] https://crrev.com/cc7820af772d69d0d3d8293c7aeef769a221947a/base/test/test_mock_time_task_runner_unittest.cc

Comment 15 by gab@chromium.org, Aug 28 2017

Status: Fixed (was: Started)
Woohoo :)!
Awesome! This unblocked a bunch of testing fixes on my end. Thank you very much for your persistence!!
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39ee610f7bfa84da3bcdb33c31d126cfc4081905

commit 39ee610f7bfa84da3bcdb33c31d126cfc4081905
Author: Wez <wez@chromium.org>
Date: Sat Apr 14 21:33:59 2018

Fix RunLoopDeathTest to expect CHECK rather than DCHECK failure.

Bug:  832728 ,  703346 
Change-Id: I4f400986db39b957095a30dc7770f6e6e541a8ae
Reviewed-on: https://chromium-review.googlesource.com/1012568
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550908}
[modify] https://crrev.com/39ee610f7bfa84da3bcdb33c31d126cfc4081905/base/run_loop_unittest.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39ee610f7bfa84da3bcdb33c31d126cfc4081905

commit 39ee610f7bfa84da3bcdb33c31d126cfc4081905
Author: Wez <wez@chromium.org>
Date: Sat Apr 14 21:33:59 2018

Fix RunLoopDeathTest to expect CHECK rather than DCHECK failure.

Bug:  832728 ,  703346 
Change-Id: I4f400986db39b957095a30dc7770f6e6e541a8ae
Reviewed-on: https://chromium-review.googlesource.com/1012568
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550908}
[modify] https://crrev.com/39ee610f7bfa84da3bcdb33c31d126cfc4081905/base/run_loop_unittest.cc

Sign in to add a comment