In Gerrit, the review-url can be composed by https://<Gerrit_host>/q/<change_id> And change_id can easily be parsed from the commit log.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/d8a303b33ef417a325dccc77a79a819002d722d1 commit d8a303b33ef417a325dccc77a79a819002d722d1 Author: Roberto Carrillo <robertocn@google.com> Date: Thu Mar 23 22:50:43 2017 [Findit] Adding stub for implementing Gerrit (codereview subclass). This is the minimum piping necessary to support getting a url from a gerrit change_id. R=stgao BUG= 703334 Change-Id: I9f5b1c5a20f8a632308feaee49ccbd3877573269 Reviewed-on: https://chromium-review.googlesource.com/457290 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> [modify] https://crrev.com/d8a303b33ef417a325dccc77a79a819002d722d1/appengine/findit/waterfall/create_revert_cl_pipeline.py [modify] https://crrev.com/d8a303b33ef417a325dccc77a79a819002d722d1/appengine/findit/waterfall/test/waterfall_config_test.py [modify] https://crrev.com/d8a303b33ef417a325dccc77a79a819002d722d1/appengine/findit/handlers/test/config_test.py [modify] https://crrev.com/d8a303b33ef417a325dccc77a79a819002d722d1/appengine/findit/waterfall/waterfall_config.py [modify] https://crrev.com/d8a303b33ef417a325dccc77a79a819002d722d1/appengine/findit/handlers/test/check_reverted_cls_test.py [modify] https://crrev.com/d8a303b33ef417a325dccc77a79a819002d722d1/appengine/findit/templates/config.html [modify] https://crrev.com/d8a303b33ef417a325dccc77a79a819002d722d1/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py [modify] https://crrev.com/d8a303b33ef417a325dccc77a79a819002d722d1/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py [modify] https://crrev.com/d8a303b33ef417a325dccc77a79a819002d722d1/appengine/findit/handlers/config.py [modify] https://crrev.com/d8a303b33ef417a325dccc77a79a819002d722d1/appengine/findit/handlers/check_reverted_cls.py [modify] https://crrev.com/d8a303b33ef417a325dccc77a79a819002d722d1/appengine/findit/waterfall/test/wf_testcase.py [modify] https://crrev.com/d8a303b33ef417a325dccc77a79a819002d722d1/appengine/findit/infra_api_clients/codereview/rietveld.py [modify] https://crrev.com/d8a303b33ef417a325dccc77a79a819002d722d1/appengine/findit/infra_api_clients/codereview/codereview_util.py [modify] https://crrev.com/d8a303b33ef417a325dccc77a79a819002d722d1/appengine/findit/infra_api_clients/codereview/test/codereview_util_test.py [modify] https://crrev.com/d8a303b33ef417a325dccc77a79a819002d722d1/appengine/findit/infra_api_clients/codereview/codereview.py [modify] https://crrev.com/d8a303b33ef417a325dccc77a79a819002d722d1/appengine/findit/model/wf_config.py [add] https://crrev.com/d8a303b33ef417a325dccc77a79a819002d722d1/appengine/findit/infra_api_clients/codereview/gerrit.py
This is not done yet. What I expect is to make the function below able to extract codereview url for commits through Gerrit. Currently it only supports commits through Rietveld. https://cs.chromium.org/chromium/infra/appengine/findit/libs/gitiles/commit_util.py?l=16
assigned to Chan.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/1affc5c053b7b577782d188de4c373d9bfdc70c2 commit 1affc5c053b7b577782d188de4c373d9bfdc70c2 Author: Chan <chanli@chromium.org> Date: Sat Mar 25 05:06:05 2017 [Findit] Get host and change_id of a CL and save in change_log. Bug:703334 Change-Id: Ic2a7f66d1d7e73a5a63dcc00cf18552bb3a32a7b Reviewed-on: https://chromium-review.googlesource.com/459011 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> [modify] https://crrev.com/1affc5c053b7b577782d188de4c373d9bfdc70c2/appengine/findit/libs/gitiles/test/change_log_test.py [modify] https://crrev.com/1affc5c053b7b577782d188de4c373d9bfdc70c2/appengine/findit/libs/gitiles/test/gitiles_repository_test.py [modify] https://crrev.com/1affc5c053b7b577782d188de4c373d9bfdc70c2/appengine/findit/libs/gitiles/test/commit_util_test.py [modify] https://crrev.com/1affc5c053b7b577782d188de4c373d9bfdc70c2/appengine/findit/libs/gitiles/change_log.py [modify] https://crrev.com/1affc5c053b7b577782d188de4c373d9bfdc70c2/appengine/findit/libs/gitiles/gitiles_repository.py [modify] https://crrev.com/1affc5c053b7b577782d188de4c373d9bfdc70c2/appengine/findit/libs/gitiles/commit_util.py [modify] https://crrev.com/1affc5c053b7b577782d188de4c373d9bfdc70c2/appengine/findit/util_scripts/git_checkout/local_git_parsers.py [modify] https://crrev.com/1affc5c053b7b577782d188de4c373d9bfdc70c2/appengine/findit/waterfall/test/pull_changelog_pipeline_test.py
As Chan's CL landed, I think this is done.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/ee462d7aa9682e8736ebda1803d563b4f22502da commit ee462d7aa9682e8736ebda1803d563b4f22502da Author: Chan <chanli@chromium.org> Date: Thu Mar 30 17:09:06 2017 [Findit] Don't get change id from code review url Bug: 703334 Change-Id: I3732cdadb987fbb9f0eca3674a16dd2742fb2636 Reviewed-on: https://chromium-review.googlesource.com/459687 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/ee462d7aa9682e8736ebda1803d563b4f22502da/appengine/findit/waterfall/create_revert_cl_pipeline.py [modify] https://crrev.com/ee462d7aa9682e8736ebda1803d563b4f22502da/appengine/findit/handlers/test/check_reverted_cls_test.py [modify] https://crrev.com/ee462d7aa9682e8736ebda1803d563b4f22502da/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py [modify] https://crrev.com/ee462d7aa9682e8736ebda1803d563b4f22502da/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py [modify] https://crrev.com/ee462d7aa9682e8736ebda1803d563b4f22502da/appengine/findit/handlers/check_reverted_cls.py [modify] https://crrev.com/ee462d7aa9682e8736ebda1803d563b4f22502da/appengine/findit/infra_api_clients/codereview/rietveld.py [modify] https://crrev.com/ee462d7aa9682e8736ebda1803d563b4f22502da/appengine/findit/infra_api_clients/codereview/codereview_util.py [modify] https://crrev.com/ee462d7aa9682e8736ebda1803d563b4f22502da/appengine/findit/waterfall/test/create_revert_cl_pipeline_test.py [modify] https://crrev.com/ee462d7aa9682e8736ebda1803d563b4f22502da/appengine/findit/infra_api_clients/codereview/test/codereview_util_test.py [modify] https://crrev.com/ee462d7aa9682e8736ebda1803d563b4f22502da/appengine/findit/waterfall/test/suspected_cl_util_test.py [modify] https://crrev.com/ee462d7aa9682e8736ebda1803d563b4f22502da/appengine/findit/waterfall/suspected_cl_util.py
Comment 1 by st...@chromium.org
, Mar 20 2017