Buildbot will eventually go away, buildbucket can already schedule recipe jobs on swarming. This bug is meant to track the effort needed to make findit trigger jobs on swarming instead of buildbot where possible.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/4a11c7adf396535ab84edffd5df1f357ff8b48d3 commit 4a11c7adf396535ab84edffd5df1f357ff8b48d3 Author: Roberto Carrillo <robertocn@google.com> Date: Thu Apr 20 22:42:28 2017 [Findit Recipes] Allow buildbucket property as a raw dict. Unlike on buildbot, when a buildbucket build is triggered on swarming, the buildbucket property is populated with a dictionary instead of a string containg the json dump of a dictionary. This change allows for either type. R=lijeffrey,chanli,stgao BUG= 703328 Change-Id: I1e78feefe998f5020098b91c48d9492d974aa711 Reviewed-on: https://chromium-review.googlesource.com/483430 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Chan Li <chanli@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/4a11c7adf396535ab84edffd5df1f357ff8b48d3/scripts/slave/recipes/findit/chromium/compile.py [modify] https://crrev.com/4a11c7adf396535ab84edffd5df1f357ff8b48d3/scripts/slave/recipe_modules/findit/api.py [modify] https://crrev.com/4a11c7adf396535ab84edffd5df1f357ff8b48d3/scripts/slave/recipes/findit/chromium/test.py [add] https://crrev.com/4a11c7adf396535ab84edffd5df1f357ff8b48d3/scripts/slave/recipes/findit/chromium/compile.expected/compile_succeeded_non_json_buildbucket.json [add] https://crrev.com/4a11c7adf396535ab84edffd5df1f357ff8b48d3/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests_non_json_buildbucket.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/7bc124aba06a388311a4bb6552e7de83e1af7e19 commit 7bc124aba06a388311a4bb6552e7de83e1af7e19 Author: Roberto Carrillo <robertocn@google.com> Date: Fri Apr 21 22:58:34 2017 [Findit recipes] Passing ninja path to check_target_exists.py In buildbot ninja is in the PATH environment variable. In swarming, it is not. Rather than modifying the PATH, this change passes the path to the executable, gotten from the depot tools recipe module directly to the script that uses it. R=chanli,stgao,lijeffrey BUG= 703328 Change-Id: I62899ac6a61f886dcbb083e26e489567b447118f Reviewed-on: https://chromium-review.googlesource.com/484639 Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> [modify] https://crrev.com/7bc124aba06a388311a4bb6552e7de83e1af7e19/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_using_bisect.json [modify] https://crrev.com/7bc124aba06a388311a4bb6552e7de83e1af7e19/scripts/slave/recipe_modules/findit/api.py [modify] https://crrev.com/7bc124aba06a388311a4bb6552e7de83e1af7e19/scripts/slave/recipe_modules/findit/__init__.py [modify] https://crrev.com/7bc124aba06a388311a4bb6552e7de83e1af7e19/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_in_middle_of_a_sub_range.json [modify] https://crrev.com/7bc124aba06a388311a4bb6552e7de83e1af7e19/scripts/slave/recipes/findit/chromium/compile.expected/last_revision_pass_not_bisect.json [modify] https://crrev.com/7bc124aba06a388311a4bb6552e7de83e1af7e19/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_build_error.json [modify] https://crrev.com/7bc124aba06a388311a4bb6552e7de83e1af7e19/scripts/slave/recipes/findit/chromium/compile.expected/first_revision_of_entire_range_failed_but_is_not_culprit.json [modify] https://crrev.com/7bc124aba06a388311a4bb6552e7de83e1af7e19/scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets_from_parameter.json [modify] https://crrev.com/7bc124aba06a388311a4bb6552e7de83e1af7e19/scripts/slave/recipes/findit/chromium/compile.expected/last_revision_pass_bisect.json [modify] https://crrev.com/7bc124aba06a388311a4bb6552e7de83e1af7e19/scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets.json [modify] https://crrev.com/7bc124aba06a388311a4bb6552e7de83e1af7e19/scripts/slave/recipe_modules/findit/resources/check_target_existence.py [modify] https://crrev.com/7bc124aba06a388311a4bb6552e7de83e1af7e19/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_in_second_sub_range.json [modify] https://crrev.com/7bc124aba06a388311a4bb6552e7de83e1af7e19/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_at_first_revision_of_a_sub_range.json [modify] https://crrev.com/7bc124aba06a388311a4bb6552e7de83e1af7e19/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_as_first_revision_of_entire_range.json [modify] https://crrev.com/7bc124aba06a388311a4bb6552e7de83e1af7e19/scripts/slave/recipes/findit/chromium/compile.expected/check_suspected_revision_before_bisect.json [modify] https://crrev.com/7bc124aba06a388311a4bb6552e7de83e1af7e19/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_ping_failure.json [modify] https://crrev.com/7bc124aba06a388311a4bb6552e7de83e1af7e19/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_setup_failure.json [modify] https://crrev.com/7bc124aba06a388311a4bb6552e7de83e1af7e19/scripts/slave/recipes/findit/chromium/compile.expected/compile_none_existing_targets.json
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/86ac4e8764d723398ae987ea8b182c141979d760 commit 86ac4e8764d723398ae987ea8b182c141979d760 Author: Roberto Carrillo <robertocn@google.com> Date: Fri Apr 28 01:01:59 2017 [Findit] Add swarmbucket overrides on buildbucket client. This is a break-out from the larger https://chromium-review.googlesource.com/c/477672 R=chanli,lijeffrey,stgao BUG= 703328 Change-Id: I820b1ba97140cc1ac718f3a636d40b964214e0b8 Reviewed-on: https://chromium-review.googlesource.com/489428 Reviewed-by: Chan Li <chanli@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> [modify] https://crrev.com/86ac4e8764d723398ae987ea8b182c141979d760/appengine/findit/common/waterfall/buildbucket_client.py [modify] https://crrev.com/86ac4e8764d723398ae987ea8b182c141979d760/appengine/findit/common/waterfall/test/buildbucket_client_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/8922d47b794e91671aec6be956c317362460432f commit 8922d47b794e91671aec6be956c317362460432f Author: Roberto Carrillo <robertocn@google.com> Date: Thu May 04 00:41:23 2017 [Findit] Set swarming properties when triggering tryjobs on swarming R=chanli,stgao,lijeffrey BUG= 703328 Change-Id: Ib752c508541bf4fcfe184631c6b8e3132597fd84 Reviewed-on: https://chromium-review.googlesource.com/477672 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> [modify] https://crrev.com/8922d47b794e91671aec6be956c317362460432f/appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py [modify] https://crrev.com/8922d47b794e91671aec6be956c317362460432f/appengine/findit/waterfall/test/schedule_compile_try_job_pipeline_test.py [modify] https://crrev.com/8922d47b794e91671aec6be956c317362460432f/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py [modify] https://crrev.com/8922d47b794e91671aec6be956c317362460432f/appengine/findit/waterfall/build_info.py [modify] https://crrev.com/8922d47b794e91671aec6be956c317362460432f/appengine/findit/waterfall/flake/recursive_flake_pipeline.py [modify] https://crrev.com/8922d47b794e91671aec6be956c317362460432f/appengine/findit/waterfall/monitor_try_job_pipeline.py [modify] https://crrev.com/8922d47b794e91671aec6be956c317362460432f/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py [modify] https://crrev.com/8922d47b794e91671aec6be956c317362460432f/appengine/findit/waterfall/detect_first_failure_pipeline.py [modify] https://crrev.com/8922d47b794e91671aec6be956c317362460432f/appengine/findit/waterfall/schedule_try_job_pipeline.py [modify] https://crrev.com/8922d47b794e91671aec6be956c317362460432f/appengine/findit/waterfall/flake/recursive_flake_try_job_pipeline.py [modify] https://crrev.com/8922d47b794e91671aec6be956c317362460432f/appengine/findit/waterfall/flake/test/recursive_flake_try_job_pipeline_test.py [modify] https://crrev.com/8922d47b794e91671aec6be956c317362460432f/appengine/findit/waterfall/schedule_compile_try_job_pipeline.py [modify] https://crrev.com/8922d47b794e91671aec6be956c317362460432f/appengine/findit/waterfall/test/schedule_test_try_job_pipeline_test.py [modify] https://crrev.com/8922d47b794e91671aec6be956c317362460432f/appengine/findit/waterfall/flake/schedule_flake_try_job_pipeline.py [modify] https://crrev.com/8922d47b794e91671aec6be956c317362460432f/appengine/findit/waterfall/schedule_test_try_job_pipeline.py [modify] https://crrev.com/8922d47b794e91671aec6be956c317362460432f/appengine/findit/waterfall/test/start_try_job_on_demand_pipeline_test.py [modify] https://crrev.com/8922d47b794e91671aec6be956c317362460432f/appengine/findit/waterfall/flake/test/schedule_flake_try_job_pipeline_test.py [modify] https://crrev.com/8922d47b794e91671aec6be956c317362460432f/appengine/findit/waterfall/buildbot.py [modify] https://crrev.com/8922d47b794e91671aec6be956c317362460432f/appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py
What's the remaining work for this bug? Can we file sub-bugs for them?
Comment 1 by robert...@chromium.org
, Apr 12 2017Status: Started (was: Available)