Implement feature parity with the current support for rietveld.
To be more specific, this task includes: 1. Implement the APIs for Gerrit as defined in https://cs.chromium.org/chromium/infra/appengine/findit/infra_api_clients/codereview/codereview.py 2. Get findit app whitelisted with access for those APIs on chromium project. 3. Hook up the support for Gerrit in Findit: a simple change in https://cs.chromium.org/chromium/infra/appengine/findit/infra_api_clients/codereview/codereview_util.py
Just to double check: I think the implementation itself is not blocked on that bug, while the actual end-2-end testing on Gerrit is. So coding itself is not blocked, right?
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/425aa59507d5b1d3276df0185362a35cbae0fbb4 commit 425aa59507d5b1d3276df0185362a35cbae0fbb4 Author: Roberto Carrillo <robertocn@google.com> Date: Wed Mar 29 23:46:48 2017 [Findit] Implement gerrit's GetClDetails Also, refactoring ClInfo to take a host and change_id instead of a url. R=stgao,chanli BUG= 703327 Change-Id: I6ab6a660907f2d7c77fbb74baa181577fafc2644 Reviewed-on: https://chromium-review.googlesource.com/461338 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Reviewed-by: Chan Li <chanli@chromium.org> [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/handlers/test/check_reverted_cls_test.py [add] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/infra_api_clients/codereview/test/gerrit_test.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/infra_api_clients/codereview/gerrit.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/infra_api_clients/codereview/test/codereview_util_test.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/infra_api_clients/codereview/codereview.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/infra_api_clients/codereview/test/rietveld_test.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/infra_api_clients/codereview/cl_info.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/handlers/test/config_test.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/libs/time_util.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/waterfall/test/wf_testcase.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/infra_api_clients/codereview/rietveld.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/waterfall/test/create_revert_cl_pipeline_test.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/waterfall/test/suspected_cl_util_test.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/model/wf_config.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/handlers/check_reverted_cls.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/waterfall/create_revert_cl_pipeline.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/handlers/config.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/waterfall/test/waterfall_config_test.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/infra_api_clients/codereview/codereview_util.py [modify] https://crrev.com/425aa59507d5b1d3276df0185362a35cbae0fbb4/appengine/findit/waterfall/suspected_cl_util.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/d339997c0bce441a6f1940b7420add4e60ec8832 commit d339997c0bce441a6f1940b7420add4e60ec8832 Author: Roberto Carrillo <robertocn@google.com> Date: Thu Mar 30 18:39:50 2017 [Findit] Implement PostMessage for Gerrit codereview. R=stgao,chanli BUG= 703327 Change-Id: Id005a76b52f10dc1af2a97de87f78a28b8b614fb Reviewed-on: https://chromium-review.googlesource.com/461207 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/d339997c0bce441a6f1940b7420add4e60ec8832/appengine/findit/infra_api_clients/codereview/gerrit.py [modify] https://crrev.com/d339997c0bce441a6f1940b7420add4e60ec8832/appengine/findit/infra_api_clients/codereview/test/gerrit_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/b9b3f6626fb961d54e2af712bb4eb97ddae0a039 commit b9b3f6626fb961d54e2af712bb4eb97ddae0a039 Author: Roberto Carrillo <robertocn@google.com> Date: Thu Mar 30 19:00:49 2017 [Findit] Implement gerrit's AddReviewers. R=stgao,chanli,lijeffrey BUG= 703327 Change-Id: Ib7e8252c44dc98d6aa4f6c3a5bca999679711475 Reviewed-on: https://chromium-review.googlesource.com/462060 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Reviewed-by: Chan Li <chanli@chromium.org> [modify] https://crrev.com/b9b3f6626fb961d54e2af712bb4eb97ddae0a039/appengine/findit/infra_api_clients/codereview/gerrit.py [modify] https://crrev.com/b9b3f6626fb961d54e2af712bb4eb97ddae0a039/appengine/findit/infra_api_clients/codereview/test/gerrit_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/a4038d7cd6ab8c5bdbc9879bcc9df58ba04bab6a commit a4038d7cd6ab8c5bdbc9879bcc9df58ba04bab6a Author: Roberto Carrillo <robertocn@google.com> Date: Thu Mar 30 19:21:11 2017 [Findit] Implement CreateRevert api for gerrit R=stgao,chanli,lijeffrey BUG= 703327 Change-Id: Ib09b8ab6ed95024d198390ee9e7fb1ee144b38f9 Reviewed-on: https://chromium-review.googlesource.com/462382 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/a4038d7cd6ab8c5bdbc9879bcc9df58ba04bab6a/appengine/findit/infra_api_clients/codereview/gerrit.py [modify] https://crrev.com/a4038d7cd6ab8c5bdbc9879bcc9df58ba04bab6a/appengine/findit/infra_api_clients/codereview/test/gerrit_test.py
Comment 1 by robert...@chromium.org
, Mar 20 2017Status: Assigned (was: ass)