New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703321 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

New Tab Page in Chrome iOS shows IDS_APP_RATING_PROMO_STRING_IOS below the search box

Project Member Reported by nhar...@chromium.org, Mar 20 2017

Issue description

App Version (from "Chrome Settings > About Chrome"): 57.0.2987.100
iOS Version: 10.2.1 (14D27)
Device: iPhone 6

Steps to reproduce: Open Chrome app

Observed behavior: Below the search/url bar is "IDS_APP_RATING_PROMO_STRING_IOS" (see attached screenshot)

Expected behavior: Some other string appears in place of that string

Frequency: 
I restarted Chrome multiple times and it reproduced each time. It continues to reproduce after restarting my phone.

Additional comments: 

 
IMG_0901.PNG
97.8 KB View Download
Cc: linds...@chromium.org gch...@chromium.org

Comment 2 by edchin@chromium.org, Mar 20 2017

Cc: -gch...@chromium.org cma...@chromium.org
Components: UI>Browser>Promo
Labels: -Pri-2 Pri-1
Owner: gch...@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by edchin@chromium.org, Mar 20 2017

Labels: ReleaseBlock-Stable M-58
Labels: M-57
We'd want this fix asap for M57, right? As the promo is only 3 days starting today?

Comment 5 by gch...@chromium.org, Mar 20 2017

Reverted launch of promo. Will take time for new config to roll out to users. 

Comment 6 by gch...@chromium.org, Mar 20 2017

Looks like upstreaming of strings changed string ID, but did not update lookup table. 

Comment 7 by pkl@chromium.org, Mar 20 2017

Cc: jasonkliu@chromium.org mard...@chromium.org
Labels: -M-58
Status: Started (was: Assigned)

Comment 8 by gch...@chromium.org, Mar 20 2017

Correction: lookup table was updated, but config was not.
CL is out for review to relaunch with updated string id. 

Comment 9 by gch...@chromium.org, Mar 22 2017

Status: Fixed (was: Started)
Marking as fixed since config was reverted. 
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD

Sign in to add a comment