This is only used for allocating bitmaps at this point. Callers can be changed to allocate bitmaps themselves and wrap that in a SkiaPaintCanvas.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82843780df15988017b386494f1e76c333410b1d commit 82843780df15988017b386494f1e76c333410b1d Author: khushalsagar <khushalsagar@chromium.org> Date: Mon Mar 27 21:55:26 2017 cc/paint: Remove cc::PaintSurface. The callers can now use SkiaPaintCanvas::CreateRasterZeroed to create a raster canvas. TBR=bauerb@chromium.org,dalecurtis@chromium.org BUG= 703320 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2764633002 Cr-Commit-Position: refs/heads/master@{#459894} [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/cc/paint/BUILD.gn [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/cc/paint/display_item_list_unittest.cc [delete] https://crrev.com/625dec950fc94b1678646d4d5ef19b76c49c96db/cc/paint/paint_surface.cc [delete] https://crrev.com/625dec950fc94b1678646d4d5ef19b76c49c96db/cc/paint/paint_surface.h [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/cc/trees/layer_tree_host_pixeltest_masks.cc [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/chrome/browser/ui/webui/app_launcher_login_handler.cc [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/content/renderer/image_capture/image_capture_frame_grabber.cc [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/content/renderer/media/webmediaplayer_ms_compositor.cc [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/content/renderer/media_capture_from_element/html_video_element_capturer_source.cc [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/content/renderer/media_capture_from_element/html_video_element_capturer_source.h [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/content/renderer/media_recorder/video_track_recorder.cc [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/media/renderers/skcanvas_video_renderer_unittest.cc [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h [modify] https://crrev.com/82843780df15988017b386494f1e76c333410b1d/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp [delete] https://crrev.com/625dec950fc94b1678646d4d5ef19b76c49c96db/third_party/WebKit/Source/platform/graphics/paint/PaintSurface.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431 commit 9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431 Author: hbos <hbos@chromium.org> Date: Tue Mar 28 08:30:59 2017 Revert of cc/paint: Remove cc::PaintSurface. (patchset #17 id:320001 of https://codereview.chromium.org/2764633002/ ) Reason for revert: This is likely the culprit causing WebRTC waterfall to consistently fail with error: [8593:779:0327/161553.140078:ERROR:video_track_recorder.cc(331)] Error trying to map PaintSurface's pixels Sample failure: https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/66456 Recent builds: https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/ Original issue's description: > cc/paint: Remove cc::PaintSurface. > > The callers can now use SkiaPaintCanvas::CreateRasterZeroed to create > a raster canvas. > > TBR=bauerb@chromium.org,dalecurtis@chromium.org > BUG= 703320 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2764633002 > Cr-Commit-Position: refs/heads/master@{#459894} > Committed: https://chromium.googlesource.com/chromium/src/+/82843780df15988017b386494f1e76c333410b1d TBR=enne@chromium.org,danakj@chromium.org,esprehn@chromium.org,vmpstr@chromium.org,khushalsagar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 703320 Review-Url: https://codereview.chromium.org/2781823002 Cr-Commit-Position: refs/heads/master@{#460041} [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/cc/paint/BUILD.gn [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/cc/paint/display_item_list_unittest.cc [add] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/cc/paint/paint_surface.cc [add] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/cc/paint/paint_surface.h [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/cc/trees/layer_tree_host_pixeltest_masks.cc [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/chrome/browser/ui/webui/app_launcher_login_handler.cc [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/content/renderer/image_capture/image_capture_frame_grabber.cc [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/content/renderer/media/webmediaplayer_ms_compositor.cc [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/content/renderer/media_capture_from_element/html_video_element_capturer_source.cc [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/content/renderer/media_capture_from_element/html_video_element_capturer_source.h [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/content/renderer/media_recorder/video_track_recorder.cc [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/media/renderers/skcanvas_video_renderer_unittest.cc [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h [modify] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp [add] https://crrev.com/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431/third_party/WebKit/Source/platform/graphics/paint/PaintSurface.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60900cbcf95fb50ed89330e5d26d5f37f9b845ef commit 60900cbcf95fb50ed89330e5d26d5f37f9b845ef Author: khushalsagar <khushalsagar@chromium.org> Date: Wed Mar 29 18:39:42 2017 cc/paint: Remove cc::PaintSurface. The callers can now create a bitmap to wrap a SkiaPaintCanvas for raster. TBR=bauerb@chromium.org,dalecurtis@chromium.org BUG= 703320 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2764633002 Cr-Commit-Position: refs/heads/master@{#459894} Committed: https://chromium.googlesource.com/chromium/src/+/82843780df15988017b386494f1e76c333410b1d Review-Url: https://codereview.chromium.org/2764633002 Cr-Commit-Position: refs/heads/master@{#460468} [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/cc/paint/BUILD.gn [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/cc/paint/display_item_list_unittest.cc [delete] https://crrev.com/a4e55ccbf27b3b2b8b8ddcb52bdc42e1372e8e28/cc/paint/paint_surface.cc [delete] https://crrev.com/a4e55ccbf27b3b2b8b8ddcb52bdc42e1372e8e28/cc/paint/paint_surface.h [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/cc/trees/layer_tree_host_pixeltest_masks.cc [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/chrome/browser/ui/webui/app_launcher_login_handler.cc [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/content/renderer/image_capture/image_capture_frame_grabber.cc [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/content/renderer/media/webmediaplayer_ms_compositor.cc [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/content/renderer/media_capture_from_element/html_video_element_capturer_source.cc [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/content/renderer/media_capture_from_element/html_video_element_capturer_source.h [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/content/renderer/media_recorder/video_track_recorder.cc [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/media/renderers/skcanvas_video_renderer_unittest.cc [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h [modify] https://crrev.com/60900cbcf95fb50ed89330e5d26d5f37f9b845ef/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp [delete] https://crrev.com/a4e55ccbf27b3b2b8b8ddcb52bdc42e1372e8e28/third_party/WebKit/Source/platform/graphics/paint/PaintSurface.h
Comment 1 by bugdroid1@chromium.org
, Mar 27 2017