New issue
Advanced search Search tips

Issue 703318 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----
Proj-XR
Proj-XR-VR

Blocking:
issue 689139
issue 703354



Sign in to add a comment

Transitions: 2D [full-screen]-to-WebVR transition in VRShell crashes browser

Project Member Reported by tiborg@chromium.org, Mar 20 2017

Issue description

If in VRShell and you click a link to a WebVR page on a 2D page (either full-screened or not) the browser crashes with SIGSEGV.
 

Comment 1 by tiborg@chromium.org, Mar 20 2017

Description: Show this description

Comment 2 by tiborg@chromium.org, Mar 20 2017

Description: Show this description

Comment 3 by tiborg@chromium.org, Mar 20 2017

Blocking: 703354

Comment 4 by tiborg@chromium.org, Mar 20 2017

Labels: VR-FF

Comment 5 by tiborg@chromium.org, Mar 20 2017

Blocking: 689139

Comment 6 by tiborg@chromium.org, Mar 20 2017

Summary: Transitions: 2D (full-screen)-to-WebVR transition in VRShell crashes browser (was: Transitions: 2D (full-screen)-to-WebVR transition in VRShell crashes)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3db9aa8aa3160f96599766955bf286a64a072e2

commit e3db9aa8aa3160f96599766955bf286a64a072e2
Author: tiborg <tiborg@chromium.org>
Date: Tue Mar 21 18:30:58 2017

Fixes 2D-to-WebVR site transitions when browsing in VR.

- Renames GetVRDevice(...) to CreateVRDisplayInfo(...) for better understandability.
- Refactores the addition for services in VRDeviceManager to simplify the code.
- Makes the client of VRDisplayImpl and VRServiceImpl private. Added delegate methods where calls to the client are necessary.
- Makes sure that VRDisplayImpl's client is initialized in the constructor. A call to an uninitialized client was the actual source of the bug.
- Moves the instantiation of VRDisplayImpl objects to VRServiceImpl since VRServiceImpl is the owner of the VRDisplayImpls.
- Adds class comments to the touched classes.
- Adaptes the unit tests accordingly.

BUG= 703318 

Review-Url: https://codereview.chromium.org/2746233002
Cr-Commit-Position: refs/heads/master@{#458483}

[modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/android/gvr/gvr_device.h
[modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/test/fake_vr_device.cc
[modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/test/fake_vr_device.h
[modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_device.cc
[modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_device.h
[modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_device_manager.cc
[modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_device_manager.h
[modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_device_manager_unittest.cc
[modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_display_impl.cc
[modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_display_impl.h
[modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_display_impl_unittest.cc
[modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_service.mojom
[modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_service_impl.cc
[modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_service_impl.h

Comment 8 by tiborg@chromium.org, Mar 21 2017

Description: Show this description

Comment 9 by tiborg@chromium.org, Mar 21 2017

Summary: Transitions: 2D [full-screen]-to-WebVR transition in VRShell crashes browser (was: Transitions: 2D (full-screen)-to-WebVR transition in VRShell crashes browser)
Status: Fixed (was: Started)

Sign in to add a comment