Issue metadata
Sign in to add a comment
|
Transitions: 2D [full-screen]-to-WebVR transition in VRShell crashes browser |
||||||||||||||||||||||||
Issue descriptionIf in VRShell and you click a link to a WebVR page on a 2D page (either full-screened or not) the browser crashes with SIGSEGV.
,
Mar 20 2017
,
Mar 20 2017
,
Mar 20 2017
,
Mar 20 2017
,
Mar 20 2017
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3db9aa8aa3160f96599766955bf286a64a072e2 commit e3db9aa8aa3160f96599766955bf286a64a072e2 Author: tiborg <tiborg@chromium.org> Date: Tue Mar 21 18:30:58 2017 Fixes 2D-to-WebVR site transitions when browsing in VR. - Renames GetVRDevice(...) to CreateVRDisplayInfo(...) for better understandability. - Refactores the addition for services in VRDeviceManager to simplify the code. - Makes the client of VRDisplayImpl and VRServiceImpl private. Added delegate methods where calls to the client are necessary. - Makes sure that VRDisplayImpl's client is initialized in the constructor. A call to an uninitialized client was the actual source of the bug. - Moves the instantiation of VRDisplayImpl objects to VRServiceImpl since VRServiceImpl is the owner of the VRDisplayImpls. - Adds class comments to the touched classes. - Adaptes the unit tests accordingly. BUG= 703318 Review-Url: https://codereview.chromium.org/2746233002 Cr-Commit-Position: refs/heads/master@{#458483} [modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/android/gvr/gvr_device.cc [modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/android/gvr/gvr_device.h [modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/test/fake_vr_device.cc [modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/test/fake_vr_device.h [modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_device.cc [modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_device.h [modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_device_manager.cc [modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_device_manager.h [modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_device_manager_unittest.cc [modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_display_impl.cc [modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_display_impl.h [modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_display_impl_unittest.cc [modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_service.mojom [modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_service_impl.cc [modify] https://crrev.com/e3db9aa8aa3160f96599766955bf286a64a072e2/device/vr/vr_service_impl.h
,
Mar 21 2017
,
Mar 21 2017
,
Mar 21 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by tiborg@chromium.org
, Mar 20 2017