New issue
Advanced search Search tips

Issue 703305 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Flaky CredentialManagerBrowserTest.ObsoleteHttpCredentialMovedOnMigrationToHstsSite

Project Member Reported by dim...@chromium.org, Mar 20 2017

Issue description

Assigning to jdoerrie@, since he added the test in https://codereview.chromium.org/2721663002

Example of failed builds:

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/38286
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/38288

Log:

CredentialManagerBrowserTest.ObsoleteHttpCredentialMovedOnMigrationToHstsSite (run #1):
[ RUN      ] CredentialManagerBrowserTest.ObsoleteHttpCredentialMovedOnMigrationToHstsSite
Mar 20 12:07:40 vm1154-m4.golo.chromium.org browser_tests[48643] <Error>: CGAffineTransformInvert: singular matrix.
[48643:58631:0320/120740.945643:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico
../../chrome/browser/password_manager/credential_manager_browsertest.cc:218: Failure
Value of: password_store->stored_passwords().at(http_origin.spec()).empty()
  Actual: false
Expected: true
BrowserTestBase received signal: Segmentation fault: 11. Backtrace:
0   browser_tests                       0x00000001088b6eac base::debug::StackTrace::StackTrace(unsigned long) + 28
1   browser_tests                       0x0000000108fe882a content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 202
2   libsystem_platform.dylib            0x00007fff8c8b05aa _sigtramp + 26
3   ???                                 0x00007fff6a49c1b0 0x0 + 140734976606640
4   browser_tests                       0x00000001089774e7 InProcessBrowserTest::RunTestOnMainThreadLoop() + 215
5   browser_tests                       0x0000000108fe8586 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 310
6   browser_tests                       0x00000001089e23b0 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4176
7   browser_tests                       0x00000001089e125e ChromeBrowserMainParts::PreMainMessageLoopRun() + 62
8   browser_tests                       0x0000000107773153 content::BrowserMainLoop::PreMainMessageLoopRun() + 67
9   browser_tests                       0x0000000107aac516 content::StartupTaskRunner::RunAllTasksNow() + 38
10  browser_tests                       0x0000000107771432 content::BrowserMainLoop::CreateStartupTasks() + 658
11  browser_tests                       0x0000000107776024 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 756
12  browser_tests                       0x000000010776ee24 content::BrowserMain(content::MainFunctionParams const&) + 100
13  browser_tests                       0x000000010889ce60 content::ContentMainRunnerImpl::Run() + 368
14  browser_tests                       0x000000010889c049 content::ContentMain(content::ContentMainParams const&) + 153
15  browser_tests                       0x0000000108fe8272 content::BrowserTestBase::SetUp() + 1906
16  browser_tests                       0x00000001089767c7 InProcessBrowserTest::SetUp() + 391
17  browser_tests                       0x00000001097167c1 testing::Test::Run() + 97
18  browser_tests                       0x00000001097172e0 testing::TestInfo::Run() + 288
19  browser_tests                       0x0000000109717877 testing::TestCase::Run() + 263
20  browser_tests                       0x000000010971d8a7 testing::internal::UnitTestImpl::RunAllTests() + 871
21  browser_tests                       0x000000010971d513 testing::UnitTest::Run() + 163
22  browser_tests                       0x000000010898c483 base::TestSuite::Run() + 163
23  browser_tests                       0x00000001088a917f ChromeTestSuiteRunner::RunTestSuite(int, char**) + 31
24  browser_tests                       0x000000010902737e content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) + 302
25  browser_tests                       0x00000001088a910a main + 90
26  libdyld.dylib                       0x00007fff899565fd start + 1

CredentialManagerBrowserTest.ObsoleteHttpCredentialMovedOnMigrationToHstsSite (run #2):
[ RUN      ] CredentialManagerBrowserTest.ObsoleteHttpCredentialMovedOnMigrationToHstsSite
[51127:58375:0320/121043.607121:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico
Mar 20 12:10:43 vm1154-m4.golo.chromium.org browser_tests[51127] <Error>: CGAffineTransformInvert: singular matrix.
../../chrome/browser/password_manager/credential_manager_browsertest.cc:218: Failure
Value of: password_store->stored_passwords().at(http_origin.spec()).empty()
  Actual: false
Expected: true
BrowserTestBase received signal: Segmentation fault: 11. Backtrace:
0   browser_tests                       0x000000010bb29eac base::debug::StackTrace::StackTrace(unsigned long) + 28
1   browser_tests                       0x000000010c25b82a content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 202
2   libsystem_platform.dylib            0x00007fff8c8b05aa _sigtramp + 26
3   ???                                 0x00007fff6cbb31b0 0x0 + 140735017595312
4   browser_tests                       0x000000010bbea4e7 InProcessBrowserTest::RunTestOnMainThreadLoop() + 215
5   browser_tests                       0x000000010c25b586 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 310
6   browser_tests                       0x000000010bc553b0 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4176
7   browser_tests                       0x000000010bc5425e ChromeBrowserMainParts::PreMainMessageLoopRun() + 62
8   browser_tests                       0x000000010a9e6153 content::BrowserMainLoop::PreMainMessageLoopRun() + 67
9   browser_tests                       0x000000010ad1f516 content::StartupTaskRunner::RunAllTasksNow() + 38
10  browser_tests                       0x000000010a9e4432 content::BrowserMainLoop::CreateStartupTasks() + 658
11  browser_tests                       0x000000010a9e9024 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 756
12  browser_tests                       0x000000010a9e1e24 content::BrowserMain(content::MainFunctionParams const&) + 100
13  browser_tests                       0x000000010bb0fe60 content::ContentMainRunnerImpl::Run() + 368
14  browser_tests                       0x000000010bb0f049 content::ContentMain(content::ContentMainParams const&) + 153
15  browser_tests                       0x000000010c25b272 content::BrowserTestBase::SetUp() + 1906
16  browser_tests                       0x000000010bbe97c7 InProcessBrowserTest::SetUp() + 391
17  browser_tests                       0x000000010c9897c1 testing::Test::Run() + 97
18  browser_tests                       0x000000010c98a2e0 testing::TestInfo::Run() + 288
19  browser_tests                       0x000000010c98a877 testing::TestCase::Run() + 263
20  browser_tests                       0x000000010c9908a7 testing::internal::UnitTestImpl::RunAllTests() + 871
21  browser_tests                       0x000000010c990513 testing::UnitTest::Run() + 163
22  browser_tests                       0x000000010bbff483 base::TestSuite::Run() + 163
23  browser_tests                       0x000000010bb1c17f ChromeTestSuiteRunner::RunTestSuite(int, char**) + 31
24  browser_tests                       0x000000010c29a37e content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) + 302
25  browser_tests                       0x000000010bb1c10a main + 90
26  libdyld.dylib                       0x00007fff899565fd start + 1
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa837586a63fe42235c24d4d76d5a1215562f5bf

commit aa837586a63fe42235c24d4d76d5a1215562f5bf
Author: dimich <dimich@chromium.org>
Date: Mon Mar 20 20:34:32 2017

Disabling flaky new test CredentialManagerBrowserTest.ObsoleteHttpCredentialMovedOnMigrationToHstsSite

BUG= 703305 
TBR=jdoerrie@chromium.org,isherman@chromium.org

Review-Url: https://codereview.chromium.org/2761023002
Cr-Commit-Position: refs/heads/master@{#458170}

[modify] https://crrev.com/aa837586a63fe42235c24d4d76d5a1215562f5bf/chrome/browser/password_manager/credential_manager_browsertest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47d59c35b288edbf4ded983949c0f5b0c4f3c5e3

commit 47d59c35b288edbf4ded983949c0f5b0c4f3c5e3
Author: vasilii <vasilii@chromium.org>
Date: Wed Mar 22 11:20:25 2017

Don't compile PasswordManagerBrowserTestBase on Android

BUG= 703305 

Review-Url: https://codereview.chromium.org/2766153002
Cr-Commit-Position: refs/heads/master@{#458715}

[modify] https://crrev.com/47d59c35b288edbf4ded983949c0f5b0c4f3c5e3/chrome/browser/BUILD.gn

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a3e6e43c4bdce4bdb64cbeb3f5bcf61d35e2ff7

commit 9a3e6e43c4bdce4bdb64cbeb3f5bcf61d35e2ff7
Author: vasilii <vasilii@chromium.org>
Date: Wed Mar 22 11:44:31 2017

Enable CredentialManagerBrowserTest.ObsoleteHttpCredentialMovedOnMigrationToHstsSite

The CL does
- introduce a new observer for the password UI state,
- uses it for ObsoleteHttpCredentialMovedOnMigrationToHstsSite,
- fixes all other tests broken by PasswordManagerBrowserTestBase changes.

BUG= 703305 

Review-Url: https://codereview.chromium.org/2759353004
Cr-Commit-Position: refs/heads/master@{#458721}

[modify] https://crrev.com/9a3e6e43c4bdce4bdb64cbeb3f5bcf61d35e2ff7/chrome/browser/password_manager/credential_manager_browsertest.cc
[modify] https://crrev.com/9a3e6e43c4bdce4bdb64cbeb3f5bcf61d35e2ff7/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/9a3e6e43c4bdce4bdb64cbeb3f5bcf61d35e2ff7/chrome/browser/password_manager/password_manager_test_base.cc
[modify] https://crrev.com/9a3e6e43c4bdce4bdb64cbeb3f5bcf61d35e2ff7/chrome/browser/password_manager/password_manager_test_base.h

Status: Fixed (was: Assigned)

Sign in to add a comment