New issue
Advanced search Search tips

Issue 703302 link

Starred by 2 users
Status: Fixed
Owner:
anthonyvd@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Implement selection in address/shipping/payment sheets

Project Member Reported by anthonyvd@chromium.org, Mar 20 2017 
In any of the sheets that contain lists (Shipping option/address, payment method, contact info), the user should be able to click on list items to select them.

When an item is selected, the new selection should be reflected in the model, the dialog should navigate back to the Payment Sheet, and the Payment Sheet should update.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0116ce334c021757db311c867d96bb56faeda1b7

commit 0116ce334c021757db311c867d96bb56faeda1b7
Author: anthonyvd <anthonyvd@chromium.org>
Date: Tue Mar 21 21:29:01 2017

[Web Payments] Implement item selection in lists.

This change implements item selection in all lists in PaymentRequest
dialog sheets. It also implements updating the Payment Sheet after a
selection changes.

BUG= 703302 
TEST=unit_tests,browsertests

Review-Url: https://codereview.chromium.org/2759253002
Cr-Commit-Position: refs/heads/master@{#458553}

[modify] https://crrev.com/0116ce334c021757db311c867d96bb56faeda1b7/chrome/browser/ui/views/payments/payment_method_view_controller.cc
[modify] https://crrev.com/0116ce334c021757db311c867d96bb56faeda1b7/chrome/browser/ui/views/payments/payment_method_view_controller_browsertest.cc
[modify] https://crrev.com/0116ce334c021757db311c867d96bb56faeda1b7/chrome/browser/ui/views/payments/payment_request_item_list.cc
[modify] https://crrev.com/0116ce334c021757db311c867d96bb56faeda1b7/chrome/browser/ui/views/payments/payment_request_item_list.h
[modify] https://crrev.com/0116ce334c021757db311c867d96bb56faeda1b7/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/0116ce334c021757db311c867d96bb56faeda1b7/chrome/browser/ui/views/payments/payment_sheet_view_controller.h
[modify] https://crrev.com/0116ce334c021757db311c867d96bb56faeda1b7/chrome/browser/ui/views/payments/profile_list_view_controller.cc
[modify] https://crrev.com/0116ce334c021757db311c867d96bb56faeda1b7/chrome/browser/ui/views/payments/profile_list_view_controller.h
[modify] https://crrev.com/0116ce334c021757db311c867d96bb56faeda1b7/chrome/browser/ui/views/payments/shipping_option_view_controller.cc
[modify] https://crrev.com/0116ce334c021757db311c867d96bb56faeda1b7/chrome/browser/ui/views/payments/view_stack.cc
[modify] https://crrev.com/0116ce334c021757db311c867d96bb56faeda1b7/components/payments/content/payment_request_state.cc
[modify] https://crrev.com/0116ce334c021757db311c867d96bb56faeda1b7/components/payments/content/payment_request_state.h
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5807cbec8e12dc0181f62c69221751486f8176ff

commit 5807cbec8e12dc0181f62c69221751486f8176ff
Author: anthonyvd <anthonyvd@chromium.org>
Date: Fri Mar 24 15:56:13 2017

[Web Payments] Refactor sheet display to allow updating view content

BUG= 703302 

Review-Url: https://codereview.chromium.org/2768133002
Cr-Commit-Position: refs/heads/master@{#459438}

[modify] https://crrev.com/5807cbec8e12dc0181f62c69221751486f8176ff/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
[modify] https://crrev.com/5807cbec8e12dc0181f62c69221751486f8176ff/chrome/browser/ui/views/payments/credit_card_editor_view_controller.h
[modify] https://crrev.com/5807cbec8e12dc0181f62c69221751486f8176ff/chrome/browser/ui/views/payments/editor_view_controller.cc
[modify] https://crrev.com/5807cbec8e12dc0181f62c69221751486f8176ff/chrome/browser/ui/views/payments/editor_view_controller.h
[modify] https://crrev.com/5807cbec8e12dc0181f62c69221751486f8176ff/chrome/browser/ui/views/payments/order_summary_view_controller.cc
[modify] https://crrev.com/5807cbec8e12dc0181f62c69221751486f8176ff/chrome/browser/ui/views/payments/order_summary_view_controller.h
[modify] https://crrev.com/5807cbec8e12dc0181f62c69221751486f8176ff/chrome/browser/ui/views/payments/payment_method_view_controller.cc
[modify] https://crrev.com/5807cbec8e12dc0181f62c69221751486f8176ff/chrome/browser/ui/views/payments/payment_method_view_controller.h
[modify] https://crrev.com/5807cbec8e12dc0181f62c69221751486f8176ff/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
[modify] https://crrev.com/5807cbec8e12dc0181f62c69221751486f8176ff/chrome/browser/ui/views/payments/payment_request_sheet_controller.h
[modify] https://crrev.com/5807cbec8e12dc0181f62c69221751486f8176ff/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/5807cbec8e12dc0181f62c69221751486f8176ff/chrome/browser/ui/views/payments/payment_sheet_view_controller.h
[modify] https://crrev.com/5807cbec8e12dc0181f62c69221751486f8176ff/chrome/browser/ui/views/payments/profile_list_view_controller.cc
[modify] https://crrev.com/5807cbec8e12dc0181f62c69221751486f8176ff/chrome/browser/ui/views/payments/profile_list_view_controller.h
[modify] https://crrev.com/5807cbec8e12dc0181f62c69221751486f8176ff/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/5807cbec8e12dc0181f62c69221751486f8176ff/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h
[modify] https://crrev.com/5807cbec8e12dc0181f62c69221751486f8176ff/chrome/browser/ui/views/payments/shipping_option_view_controller.cc
[modify] https://crrev.com/5807cbec8e12dc0181f62c69221751486f8176ff/chrome/browser/ui/views/payments/shipping_option_view_controller.h

Comment 3 by ma...@chromium.org, Apr 10 2017 

Fixed?

Comment 4 by anthonyvd@chromium.org, Apr 19 2017

Status: Fixed (was: Assigned)

Comment 5 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment