New issue
Advanced search Search tips

Issue 703287 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Support controller handedness preferences in VR Shell

Project Member Reported by mthiesse@chromium.org, Mar 20 2017

Issue description

We assume right hand at the moment, we should support left-handed users as well :)
 
Labels: -VR-FF VR-BBB
Labels: hotlist-initial-vr-browser
Labels: -hotlist-initial-vr-browser
Owner: mthiesse@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a75e2f6c06fdf268d20184a2a2f8f521a7229dbf

commit a75e2f6c06fdf268d20184a2a2f8f521a7229dbf
Author: mthiesse <mthiesse@chromium.org>
Date: Tue May 02 16:40:10 2017

VR: Refresh controller handedness when resuming the controller.

Thanks to Aldo's elbow model implementation, we already support handedness controls. This CL does some clean up to make sure we're refreshing it when we should.

BUG= 703287 

Review-Url: https://codereview.chromium.org/2848283003
Cr-Commit-Position: refs/heads/master@{#468678}

[modify] https://crrev.com/a75e2f6c06fdf268d20184a2a2f8f521a7229dbf/chrome/browser/android/vr_shell/elbow_model.cc
[modify] https://crrev.com/a75e2f6c06fdf268d20184a2a2f8f521a7229dbf/chrome/browser/android/vr_shell/elbow_model.h
[modify] https://crrev.com/a75e2f6c06fdf268d20184a2a2f8f521a7229dbf/chrome/browser/android/vr_shell/vr_controller.cc
[modify] https://crrev.com/a75e2f6c06fdf268d20184a2a2f8f521a7229dbf/chrome/browser/android/vr_shell/vr_controller.h

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified in Chrome Canary 61.0.3123.0

Sign in to add a comment