New issue
Advanced search Search tips

Issue 703274 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocking:
issue 703256



Sign in to add a comment

Migrate cbuildbot to run in virtualenv

Project Member Reported by akes...@chromium.org, Mar 20 2017

Issue description

scripts/cbuildbot.py:    context = ts_mon_config.SetupTsMonGlobalState('cbuildbot', indirect=True)
 
Will there be any issues with updating the venv while cbuildbot is running?
cbuildbot does some bootstrapping/re-execing. Don is the expert there, but it is something vaguely like:

cbuildbot (from bare chromite-only checkout) -> (?) cbuildbot (from repo checkout) -> cbuildbot (from sysroot with any test patches applied if relevant)
We'd want to add the virtualenv wrapper to one of those reexecutions. Probably the first one.
When cbuildbot rexecs itself, it just calls chromite/bin/cbuildbot, which would mean both invocations get the wrapper. I can check, but I think it "execs" the child, which means the parent process no longer needs it's environment.

So... letting the child wrapper update the virtualenv to match what the child needs (perhaps older package versions, for example) seems correct to me.

The new cbuildbot_launch script will run from a different checkout of chromite, so should avoid cros-polluting virtualenv environments. Right?
cbuildbot calls itself again normally using RunCommand, it doesn't look like it does a self-exec unless RunCommand does that by default.  Either way, the Python environment of any given virtualenv enabled entry point should be clean (that's the point, after all).
Owner: ayatane@chromium.org
Status: Started (was: Untriaged)

Comment 7 by autumn@chromium.org, Mar 21 2017

Labels: -current-issue
Labels: -Type-Bug Type-Feature
Status: Assigned (was: Started)
Components: Infra>Client>ChromeOS>CI
Components: -Infra>Client>ChromeOS
Status: Archived (was: Assigned)
This will be done as part of Issue 810460

Sign in to add a comment