Chrome OS R58 release branch is not updating Chrome correctly |
|||||||
Issue descriptionStarting roughly last Tuesday we stopped getting Chrome uprevs on the 58 release branch. The last successful one was https://uberchromegw.corp.google.com/i/chromeos_release/builders/samus-pre-flight-branch%20release-R58-9334.B/builds/39 I don't see anything in the change logs that is obvious, nothing special in Chromite for Chrome uprevving. The root cause looks like we are not detecting new versions of Chrome. " 21:12:10: INFO: RunCommand: cros_sdk -- ../../chromite/bin/cros_mark_chrome_as_stable '--tracking_branch=release-R58-9334.B' '--boards=samus' stable_release in /b/cbuild/shared_internal/src/scripts * Generating locale-archive: forcing # of jobs to 1 21:12:13: INFO: Stable candidate found /home/chrome-bot/trunk/src/third_party/chromiumos-overlay/chromeos-base/chromeos-chrome/chromeos-chrome-58.0.3029.19_rc-r1.ebuild 21:12:13: INFO: Previous ebuild with same version found and ebuild is redundant. 21:12:14: INFO: Found nothing to rev. " This seems to imply that it only finds 58.0.3029.19 at https://chromium.googlesource.com/chromium/src.git/+refs however I am seeing newer versions, this assumes we have the default URL here (have not traced that down yet). I guess we may need to instrument more in the code?
,
Mar 20 2017
With help from Josafat it looks like this is rooted in missing 'buildspec_platforms' from the DEPS file. https://chromium.googlesource.com/chromium/src.git/+/58.0.3029.28/DEPS has no buildspec_platforms but https://chromium.googlesource.com/chromium/src.git/+/58.0.3029.19/DEPS did. So this is probably something on the Chrome triggering side.
,
Mar 20 2017
+amineer as per our chat Here is the bug I mentioned, please feel free to forward to the right owner to evaluate if buildpec_platform was deprecated in the DEPS
,
Mar 20 2017
I'm taking a look.
,
Mar 20 2017
,
Mar 20 2017
,
Mar 20 2017
To try to unblock 58 for CrOS should we manually trigger a Chrome build on this branch with chrome os with force? It would be good if we could get this done overnight, as ARC++ is broken on the branch until we can get a Chrome rev and that might be hiding other gremlins.
,
Mar 20 2017
I'm triggering a ChromeOS build for 3029 branch now.
,
Mar 21 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/87b70312e24f0bd80db62db8835c38de8d6cf491 commit 87b70312e24f0bd80db62db8835c38de8d6cf491 Author: dimu <dimu@google.com> Date: Tue Mar 21 01:02:19 2017
,
Mar 22 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/bbd6d2ea9d67575da603bb53737a89a0b8190644 commit bbd6d2ea9d67575da603bb53737a89a0b8190644 Author: dimu <dimu@google.com> Date: Wed Mar 22 21:39:25 2017
,
Apr 19 2017
Is it still an issue? All public DEPS should have 'buildspec_platforms' entry now.
,
Apr 19 2017
Everything has been working smoothly, thanks! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by josa...@chromium.org
, Mar 20 2017