New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703254 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Expose underlying GPU driver's VENDOR/RENDERER strings everywhere

Project Member Reported by zmo@chromium.org, Mar 20 2017

Issue description

Since WebGL already exposed these strings unconditionally through WEBGL_debug_renderer extension, there is no reason for us to hide them any more. This might benefit other clients, for example, Skia.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b5537f92d5910a563811ce14208d7cb8b45b377

commit 9b5537f92d5910a563811ce14208d7cb8b45b377
Author: zmo <zmo@chromium.org>
Date: Mon Mar 20 23:01:56 2017

Expose GL_VENDOR/GL_RENDERER strings to internal clients of GPU command buffer.

BUG= 703254 
TEST=gpu_unittests
R=bsalomon@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2758173003
Cr-Commit-Position: refs/heads/master@{#458220}

[modify] https://crrev.com/9b5537f92d5910a563811ce14208d7cb8b45b377/gpu/command_buffer/service/gl_utils.cc
[modify] https://crrev.com/9b5537f92d5910a563811ce14208d7cb8b45b377/gpu/command_buffer/service/gl_utils.h
[modify] https://crrev.com/9b5537f92d5910a563811ce14208d7cb8b45b377/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/9b5537f92d5910a563811ce14208d7cb8b45b377/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
[modify] https://crrev.com/9b5537f92d5910a563811ce14208d7cb8b45b377/gpu/command_buffer/tests/gl_unittest.cc

Comment 2 by zmo@chromium.org, Mar 20 2017

Status: Fixed (was: Assigned)

Sign in to add a comment