New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 703238 link

Starred by 2 users
Status: Fixed
Owner:
█ zpeng@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 642600



Sign in to add a comment

Update checkstyle so that it Supports Java 8

Project Member Reported by agrieve@chromium.org, Mar 20 2017 
I made a test commit to kick the tires on Java 8 support:
https://codereview.chromium.org/2759963002

It fails presubmit in a way this is unfixable:
  base/android/java/src/org/chromium/base/Promise.java:96: 'throw' have incorrect indentation level 12, expected level should be 16.

But if I make this change, then it complains:
  base/android/java/src/org/chromium/base/Promise.java:96: 'block' child have incorrect indentation level 16, expected level should be 12.

I suspect we just need to update our version of checkstyle (and perhaps update our rules).
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fb89ced75c50e77bc5c6a29bb820534d16d5279

commit 6fb89ced75c50e77bc5c6a29bb820534d16d5279
Author: Alexei Svitkine <asvitkine@chromium.org>
Date: Fri Apr 07 22:25:40 2017

Revert "Update third_party/checkstyle to 7.6.1"

This reverts commit dbce02f63421f7d446d6ef317b456f6ae911f63b.

Reason for revert:
Breaking cq presubmit step

Original issue's description:
> Update third_party/checkstyle to 7.6.1
>
> This CL updates third_party/checkstyle to 7.6.1 so checkstyle would
> work with Java 8 lambda features.
>
> BUG= 703238 
>
> Review-Url: https://codereview.chromium.org/2799303003
> Cr-Commit-Position: refs/heads/master@{#462968}
> Committed: https://chromium.googlesource.com/chromium/src/+/dbce02f63421f7d446d6ef317b456f6ae911f63b

TBR=agrieve@chromium.org,nyquist@chromium.org,jbudorick@chromium.org,klobag@chromium.org,jbudorick@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 703238 

Review-Url: https://codereview.chromium.org/2807753003 .
Cr-Commit-Position: refs/heads/master@{#463021}

[modify] https://crrev.com/6fb89ced75c50e77bc5c6a29bb820534d16d5279/DEPS
[modify] https://crrev.com/6fb89ced75c50e77bc5c6a29bb820534d16d5279/third_party/.gitignore
[modify] https://crrev.com/6fb89ced75c50e77bc5c6a29bb820534d16d5279/third_party/checkstyle/OWNERS
[modify] https://crrev.com/6fb89ced75c50e77bc5c6a29bb820534d16d5279/third_party/checkstyle/README.chromium
[add] https://crrev.com/6fb89ced75c50e77bc5c6a29bb820534d16d5279/third_party/checkstyle/checkstyle-6.5-all.jar
[delete] https://crrev.com/c345ab7d5a956251b46048138972883c89337d8e/third_party/checkstyle/checkstyle-7.6.1-all.jar.sha1
[modify] https://crrev.com/6fb89ced75c50e77bc5c6a29bb820534d16d5279/tools/android/checkstyle/checkstyle.py
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccf6d26c344204648d226c7b1903179f389230c2

commit ccf6d26c344204648d226c7b1903179f389230c2
Author: zpeng <zpeng@chromium.org>
Date: Thu Apr 20 14:17:22 2017

Reland "Update third_party/checkstyle to 7.6.1"

Reverted in:
https://codereview.chromium.org/2807753003/

Reason for reland:
1. No longer uses Android-related wrapper script for downloading
checkstyle binary file.
2. chromium_presubmit bot now supports Java 8.

TBR=klobag@chromium.org
BUG= 703238 

Review-Url: https://codereview.chromium.org/2820583002
Cr-Commit-Position: refs/heads/master@{#465999}

[modify] https://crrev.com/ccf6d26c344204648d226c7b1903179f389230c2/DEPS
[modify] https://crrev.com/ccf6d26c344204648d226c7b1903179f389230c2/build/android/update_deps/update_third_party_deps.py
[modify] https://crrev.com/ccf6d26c344204648d226c7b1903179f389230c2/third_party/.gitignore
[modify] https://crrev.com/ccf6d26c344204648d226c7b1903179f389230c2/third_party/checkstyle/OWNERS
[modify] https://crrev.com/ccf6d26c344204648d226c7b1903179f389230c2/third_party/checkstyle/README.chromium
[delete] https://crrev.com/4da3e35ba0d85a1130dac12acbb699ba0afb63e6/third_party/checkstyle/checkstyle-6.5-all.jar
[add] https://crrev.com/ccf6d26c344204648d226c7b1903179f389230c2/third_party/checkstyle/checkstyle-7.6.1-all.jar.sha1
[modify] https://crrev.com/ccf6d26c344204648d226c7b1903179f389230c2/tools/android/checkstyle/checkstyle.py

Comment 4 by zpeng@chromium.org, Apr 20 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment