New issue
Advanced search Search tips

Issue 703212 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

[Downloads] Download service request queue might run options twice

Project Member Reported by dtrainor@chromium.org, Mar 20 2017

Issue description

The downloads queue might run options twice if the service gets killed during a queue flush.  Fix this by properly clearing the queue entries that have run when returning early from the flush operation.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/008b3fe04b6cefb33e44ebb30c4a2fc5881d6d40

commit 008b3fe04b6cefb33e44ebb30c4a2fc5881d6d40
Author: dtrainor <dtrainor@chromium.org>
Date: Thu Mar 30 03:26:00 2017

Don't force the download notifier to unbind

The DownloadNotificationService tells the SystemDownloadNotifier to
unbind from it when it has no notifications to show and wants to shut
itself down.  This isn't needed because the SystemDownloadNotifier will
unbind when it is a safe time for the service to die.  This patch
removes the Observer method that tells the SystemDownloadNotifier to
unbind itself.

BUG= 703212 

Review-Url: https://codereview.chromium.org/2771353002
Cr-Commit-Position: refs/heads/master@{#460641}

[modify] https://crrev.com/008b3fe04b6cefb33e44ebb30c4a2fc5881d6d40/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/008b3fe04b6cefb33e44ebb30c4a2fc5881d6d40/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java

Labels: Merge-Request-58
Status: Fixed (was: Started)
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 30 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 2 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b74cf25e32daf095f452c397353ff23aa89d09a

commit 6b74cf25e32daf095f452c397353ff23aa89d09a
Author: David Trainor <dtrainor@chromium.org>
Date: Sun Apr 02 16:49:21 2017

Don't force the download notifier to unbind

The DownloadNotificationService tells the SystemDownloadNotifier to
unbind from it when it has no notifications to show and wants to shut
itself down.  This isn't needed because the SystemDownloadNotifier will
unbind when it is a safe time for the service to die.  This patch
removes the Observer method that tells the SystemDownloadNotifier to
unbind itself.

BUG= 703212 

Review-Url: https://codereview.chromium.org/2771353002
Cr-Commit-Position: refs/heads/master@{#460641}
(cherry picked from commit 008b3fe04b6cefb33e44ebb30c4a2fc5881d6d40)

Review-Url: https://codereview.chromium.org/2795583002 .
Cr-Commit-Position: refs/branch-heads/3029@{#531}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/6b74cf25e32daf095f452c397353ff23aa89d09a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/6b74cf25e32daf095f452c397353ff23aa89d09a/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java

Sign in to add a comment