MediaCustomControlsFullscreenDetector not listening to events properly |
||||||
Issue descriptionThis happens when the <video> tag is written in the HTML file, i.e. not by adding the element to the document.
,
Mar 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9d39e2308b617bad51c86f9703828a2fbef95d8 commit d9d39e2308b617bad51c86f9703828a2fbef95d8 Author: zqzhang <zqzhang@chromium.org> Date: Mon Mar 20 19:17:08 2017 Fix the conditions when fullscreen detector listeners are registered Previously, we rely on the DOMNode[Inserted/Removed]IntoDocument events to attach/detach the detector. However this won't work if the video element is created from the parsing process. This CL fixes the issue by overriding insertedInto() and removedFrom() callbacks, which always works regardless of how the video element is inserted into the document. BUG= 703210 Review-Url: https://codereview.chromium.org/2758233003 Cr-Commit-Position: refs/heads/master@{#458147} [modify] https://crrev.com/d9d39e2308b617bad51c86f9703828a2fbef95d8/third_party/WebKit/Source/core/html/HTMLMediaElement.h [modify] https://crrev.com/d9d39e2308b617bad51c86f9703828a2fbef95d8/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp [modify] https://crrev.com/d9d39e2308b617bad51c86f9703828a2fbef95d8/third_party/WebKit/Source/core/html/HTMLVideoElement.h [modify] https://crrev.com/d9d39e2308b617bad51c86f9703828a2fbef95d8/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.cpp [modify] https://crrev.com/d9d39e2308b617bad51c86f9703828a2fbef95d8/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.h [modify] https://crrev.com/d9d39e2308b617bad51c86f9703828a2fbef95d8/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetectorTest.cpp
,
Mar 20 2017
,
Mar 21 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ac66c6ce3966669bb2f3db5bd7a454a96ff4c0c commit 8ac66c6ce3966669bb2f3db5bd7a454a96ff4c0c Author: Zhiqiang Zhang <zqzhang@google.com> Date: Tue Mar 21 21:15:39 2017 Fix the conditions when fullscreen detector listeners are registered Previously, we rely on the DOMNode[Inserted/Removed]IntoDocument events to attach/detach the detector. However this won't work if the video element is created from the parsing process. This CL fixes the issue by overriding insertedInto() and removedFrom() callbacks, which always works regardless of how the video element is inserted into the document. BUG= 703210 Review-Url: https://codereview.chromium.org/2758233003 Cr-Commit-Position: refs/heads/master@{#458147} (cherry picked from commit d9d39e2308b617bad51c86f9703828a2fbef95d8) Review-Url: https://codereview.chromium.org/2767763002 . Cr-Commit-Position: refs/branch-heads/3029@{#343} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/8ac66c6ce3966669bb2f3db5bd7a454a96ff4c0c/third_party/WebKit/Source/core/html/HTMLMediaElement.h [modify] https://crrev.com/8ac66c6ce3966669bb2f3db5bd7a454a96ff4c0c/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp [modify] https://crrev.com/8ac66c6ce3966669bb2f3db5bd7a454a96ff4c0c/third_party/WebKit/Source/core/html/HTMLVideoElement.h [modify] https://crrev.com/8ac66c6ce3966669bb2f3db5bd7a454a96ff4c0c/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.cpp [modify] https://crrev.com/8ac66c6ce3966669bb2f3db5bd7a454a96ff4c0c/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.h [modify] https://crrev.com/8ac66c6ce3966669bb2f3db5bd7a454a96ff4c0c/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetectorTest.cpp
,
Mar 21 2017
,
Mar 29 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mlamouri@chromium.org
, Mar 20 2017