New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 703188 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 598073



Sign in to add a comment

Remove experiment code for "Avoid using SharedMemory to transfer small resource"

Project Member Reported by scottmg@chromium.org, Mar 20 2017

Issue description

In https://bugs.chromium.org/p/chromium/issues/detail?id=580928#c12 we noted that the code for the experiment for "Avoid using SharedMemory to transfer small resource" is now obsolete as the experiment has run its course.

This bug can be used to remove the related code (which will make some parts of https://crbug.com/598073 easier)
 
Blocking: 598073
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ecbd1cc3eec2593a082c53367415f6d1b0a6523

commit 4ecbd1cc3eec2593a082c53367415f6d1b0a6523
Author: scottmg <scottmg@chromium.org>
Date: Wed Mar 22 22:28:46 2017

Remove inline small resource transfer experiment

This removes the code for an experiment to inline small resources into
the main IPC resource. This simplifies some c/b/loader separation,
particularly the hooks in async_resource_handler.cc.

BUG= 580928 ,  703188 

Review-Url: https://codereview.chromium.org/2762953004
Cr-Commit-Position: refs/heads/master@{#458899}

[modify] https://crrev.com/4ecbd1cc3eec2593a082c53367415f6d1b0a6523/chrome/app/generated_resources.grd
[modify] https://crrev.com/4ecbd1cc3eec2593a082c53367415f6d1b0a6523/chrome/browser/about_flags.cc
[modify] https://crrev.com/4ecbd1cc3eec2593a082c53367415f6d1b0a6523/content/browser/loader/async_resource_handler.cc
[modify] https://crrev.com/4ecbd1cc3eec2593a082c53367415f6d1b0a6523/content/browser/loader/async_resource_handler.h
[modify] https://crrev.com/4ecbd1cc3eec2593a082c53367415f6d1b0a6523/content/browser/loader/async_resource_handler_unittest.cc
[modify] https://crrev.com/4ecbd1cc3eec2593a082c53367415f6d1b0a6523/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/4ecbd1cc3eec2593a082c53367415f6d1b0a6523/content/child/resource_dispatcher.cc
[modify] https://crrev.com/4ecbd1cc3eec2593a082c53367415f6d1b0a6523/content/child/resource_dispatcher.h
[modify] https://crrev.com/4ecbd1cc3eec2593a082c53367415f6d1b0a6523/content/child/resource_dispatcher_unittest.cc
[modify] https://crrev.com/4ecbd1cc3eec2593a082c53367415f6d1b0a6523/content/common/resource_messages.h
[modify] https://crrev.com/4ecbd1cc3eec2593a082c53367415f6d1b0a6523/content/public/common/content_features.cc
[modify] https://crrev.com/4ecbd1cc3eec2593a082c53367415f6d1b0a6523/content/public/common/content_features.h
[modify] https://crrev.com/4ecbd1cc3eec2593a082c53367415f6d1b0a6523/tools/metrics/histograms/histograms.xml

Comment 3 by mmenke@chromium.org, Mar 27 2017

Status: Fixed (was: Assigned)
Think this is now fixed.

Comment 4 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 5 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Sign in to add a comment