New issue
Advanced search Search tips

Issue 703187 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Use external clock in ReadingListEntry

Project Member Reported by olivierrobin@chromium.org, Mar 20 2017

Issue description

Currently, tests need to spin the runloop to make sure clock advance.
Use an external clock so we can set the time as needed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56ce061ee96941c746bb98be90331f6cf6c4002e

commit 56ce061ee96941c746bb98be90331f6cf6c4002e
Author: olivierrobin <olivierrobin@chromium.org>
Date: Wed Mar 22 12:08:41 2017

Reading List iOS: Use external clock in ReadingListEntry.

Currently, tests need to spin the runloop to make sure clock advance.
Use an external clock so we can set the time as needed.

BUG= 703187 

Review-Url: https://codereview.chromium.org/2764533002
Cr-Commit-Position: refs/heads/master@{#458723}

[modify] https://crrev.com/56ce061ee96941c746bb98be90331f6cf6c4002e/components/reading_list/ios/BUILD.gn
[modify] https://crrev.com/56ce061ee96941c746bb98be90331f6cf6c4002e/components/reading_list/ios/reading_list_entry.cc
[modify] https://crrev.com/56ce061ee96941c746bb98be90331f6cf6c4002e/components/reading_list/ios/reading_list_entry.h
[modify] https://crrev.com/56ce061ee96941c746bb98be90331f6cf6c4002e/components/reading_list/ios/reading_list_entry_unittest.cc
[modify] https://crrev.com/56ce061ee96941c746bb98be90331f6cf6c4002e/components/reading_list/ios/reading_list_model.h
[modify] https://crrev.com/56ce061ee96941c746bb98be90331f6cf6c4002e/components/reading_list/ios/reading_list_model_impl.cc
[modify] https://crrev.com/56ce061ee96941c746bb98be90331f6cf6c4002e/components/reading_list/ios/reading_list_model_impl.h
[modify] https://crrev.com/56ce061ee96941c746bb98be90331f6cf6c4002e/components/reading_list/ios/reading_list_model_storage.h
[rename] https://crrev.com/56ce061ee96941c746bb98be90331f6cf6c4002e/components/reading_list/ios/reading_list_model_unittest.cc
[modify] https://crrev.com/56ce061ee96941c746bb98be90331f6cf6c4002e/components/reading_list/ios/reading_list_store.cc
[modify] https://crrev.com/56ce061ee96941c746bb98be90331f6cf6c4002e/components/reading_list/ios/reading_list_store.h
[rename] https://crrev.com/56ce061ee96941c746bb98be90331f6cf6c4002e/components/reading_list/ios/reading_list_store_unittest.cc
[modify] https://crrev.com/56ce061ee96941c746bb98be90331f6cf6c4002e/ios/chrome/browser/reading_list/reading_list_download_service.cc
[modify] https://crrev.com/56ce061ee96941c746bb98be90331f6cf6c4002e/ios/chrome/browser/reading_list/reading_list_model_factory.cc
[modify] https://crrev.com/56ce061ee96941c746bb98be90331f6cf6c4002e/ios/chrome/browser/reading_list/reading_list_web_state_observer_unittest.mm
[modify] https://crrev.com/56ce061ee96941c746bb98be90331f6cf6c4002e/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm
[modify] https://crrev.com/56ce061ee96941c746bb98be90331f6cf6c4002e/ios/chrome/browser/ui/reading_list/reading_list_coordinator_unittest.mm

Status: Fixed (was: Started)

Sign in to add a comment