Issue metadata
Sign in to add a comment
|
Patch all users of remote_access.CopyToDevice to deal with new default value |
||||||||||||||||||||||||
Issue descriptionhttps://chromium-review.googlesource.com/#/c/455237/ changed the default value of the mode argument from None (which in practice meant rsync if available) to scp. Not all callers of this function were patched to accomodate this. One example is: http://shortn/_V8dhhPpQQE There may be others.
,
Mar 20 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by osh...@chromium.org
, Mar 20 2017Malay and I were getting the following error. Changing the default mode to "rsync" worked as a stopgap solution. I'd expect this will happen to other folks? deploy_chrome: Unhandled exception: Traceback (most recent call last): File "/usr/local/google3/home/oshima/chrome-git/src/third_party/chromite/bin/deploy_chrome", line 168, in <module> DoMain() File "/usr/local/google3/home/oshima/chrome-git/src/third_party/chromite/bin/deploy_chrome", line 164, in DoMain commandline.ScriptWrapperMain(FindTarget) File "/usr/local/google3/home/oshima/chrome-git/src/third_party/chromite/lib/commandline.py", line 834, in ScriptWrapperMain ret = target(argv[1:]) File "/usr/local/google3/home/oshima/chrome-git/src/third_party/chromite/scripts/deploy_chrome.py", line 630, in main deploy.Perform() File "/usr/local/google3/home/oshima/chrome-git/src/third_party/chromite/scripts/deploy_chrome.py", line 339, in Perform self._Deploy() File "/usr/local/google3/home/oshima/chrome-git/src/third_party/chromite/scripts/deploy_chrome.py", line 255, in _Deploy verbose=self.options.verbose) File "/usr/local/google3/home/oshima/chrome-git/src/third_party/chromite/lib/remote_access.py", line 714, in CopyToDevice return RunCommandFuncWrapper(func, msg, src, dest, **kwargs) File "/usr/local/google3/home/oshima/chrome-git/src/third_party/chromite/lib/remote_access.py", line 166, in RunCommandFuncWrapper result = func(*args, error_code_ok=True, **kwargs) File "/usr/local/google3/home/oshima/chrome-git/src/third_party/chromite/lib/remote_access.py", line 513, in Scp return rc_func(scp_cmd, print_cmd=verbose, **kwargs) TypeError: RunCommand() got an unexpected keyword argument 'inplace'