+ajwong@,+tdresser@ FYI
Don't expect any action on your side, but I though this is something you might want to keep an eye on. CLs are about to fly under this bug.

feel free to un-cc yourself if this becomes too spammy or just too irrelevant for you, I won't get offended :)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbfd644ca2d24fc324101ea15e6198ca71c804c1

commit cbfd644ca2d24fc324101ea15e6198ca71c804c1
Author: hjd <hjd@chromium.org>
Date: Fri Mar 24 12:29:43 2017

memory-infra: Add a struct to carry memory use information

This (currently unused) struct will carry information back to the
memory coordinator service where it will eventually be collated
and make its way to UMA.

BUG=703184

Review-Url: https://codereview.chromium.org/2755343003
Cr-Commit-Position: refs/heads/master@{#459399}

[modify] https://crrev.com/cbfd644ca2d24fc324101ea15e6198ca71c804c1/base/trace_event/memory_dump_request_args.cc
[modify] https://crrev.com/cbfd644ca2d24fc324101ea15e6198ca71c804c1/base/trace_event/memory_dump_request_args.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adbce8ba658534687a82e731ef138678f116f3a2

commit adbce8ba658534687a82e731ef138678f116f3a2
Author: hjd <hjd@chromium.org>
Date: Fri Mar 24 19:08:21 2017

memory-infra: Fill the memory dump callback result (1/2)

Fill in the part of the memory dump result struct
that applies to Chrome's veiw of itself when finalizing
a memory dump. This requires a tweak to memory_allocator_dump
to keep track of the 'size' field.

BUG=703184

Review-Url: https://codereview.chromium.org/2760253005
Cr-Commit-Position: refs/heads/master@{#459506}

[modify] https://crrev.com/adbce8ba658534687a82e731ef138678f116f3a2/base/trace_event/memory_allocator_dump.cc
[modify] https://crrev.com/adbce8ba658534687a82e731ef138678f116f3a2/base/trace_event/memory_allocator_dump.h
[modify] https://crrev.com/adbce8ba658534687a82e731ef138678f116f3a2/base/trace_event/memory_allocator_dump_unittest.cc
[modify] https://crrev.com/adbce8ba658534687a82e731ef138678f116f3a2/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/adbce8ba658534687a82e731ef138678f116f3a2/base/trace_event/memory_dump_manager.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a9a8c2542a81a6410d88e75650e907611acc630

commit 9a9a8c2542a81a6410d88e75650e907611acc630
Author: primiano <primiano@chromium.org>
Date: Fri Mar 31 17:18:04 2017

memory-infra: refactoring to extract MemoryDumpProviderInfo class

Non-functional refactoring in preparation of upcoming CLs.
This simply extract the MemoryDumpProviderInfo class in its own
translation unit.

BUG=703184
TBR=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2790523004
Cr-Commit-Position: refs/heads/master@{#461156}

[modify] https://crrev.com/9a9a8c2542a81a6410d88e75650e907611acc630/base/BUILD.gn
[modify] https://crrev.com/9a9a8c2542a81a6410d88e75650e907611acc630/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/9a9a8c2542a81a6410d88e75650e907611acc630/base/trace_event/memory_dump_manager.h
[add] https://crrev.com/9a9a8c2542a81a6410d88e75650e907611acc630/base/trace_event/memory_dump_provider_info.cc
[add] https://crrev.com/9a9a8c2542a81a6410d88e75650e907611acc630/base/trace_event/memory_dump_provider_info.h
[modify] https://crrev.com/9a9a8c2542a81a6410d88e75650e907611acc630/tools/gn/bootstrap/bootstrap.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22fd5f0cf18a409dd72b96cb526a25a6cac88d24

commit 22fd5f0cf18a409dd72b96cb526a25a6cac88d24
Author: hjd <hjd@chromium.org>
Date: Fri Apr 07 14:28:37 2017

memory-infra: Fill the memory dump callback result (2/2)

Fill in the part of the memory dump result struct
that applies to OS's view of Chrome when finalizing
a memory dump.

BUG=703184

Review-Url: https://codereview.chromium.org/2766173003
Cr-Commit-Position: refs/heads/master@{#462849}

[modify] https://crrev.com/22fd5f0cf18a409dd72b96cb526a25a6cac88d24/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/22fd5f0cf18a409dd72b96cb526a25a6cac88d24/base/trace_event/process_memory_dump.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/825abe65c05d62a80e5e6aabe29c9d59c4630da3

commit 825abe65c05d62a80e5e6aabe29c9d59c4630da3
Author: hjd <hjd@chromium.org>
Date: Fri Apr 07 15:11:20 2017

Revert of memory-infra: Fill the memory dump callback result (2/2) (patchset #6 id:100001 of https://codereview.chromium.org/2766173003/ )

Reason for revert:
Causing build failure:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/54494

Original issue's description:
> memory-infra: Fill the memory dump callback result (2/2)
>
> Fill in the part of the memory dump result struct
> that applies to OS's view of Chrome when finalizing
> a memory dump.
>
> BUG=703184
>
> Review-Url: https://codereview.chromium.org/2766173003
> Cr-Commit-Position: refs/heads/master@{#462849}
> Committed: https://chromium.googlesource.com/chromium/src/+/22fd5f0cf18a409dd72b96cb526a25a6cac88d24

TBR=primiano@chromium.org,fmeawad@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=703184

Review-Url: https://codereview.chromium.org/2806553005
Cr-Commit-Position: refs/heads/master@{#462864}

[modify] https://crrev.com/825abe65c05d62a80e5e6aabe29c9d59c4630da3/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/825abe65c05d62a80e5e6aabe29c9d59c4630da3/base/trace_event/process_memory_dump.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e649e4c348909f5e528fbccebd48fdbf69df84ef

commit e649e4c348909f5e528fbccebd48fdbf69df84ef
Author: hjd <hjd@chromium.org>
Date: Mon Apr 10 12:16:56 2017

memory-infra: Reland: Fill the memory dump callback result (2/2)

Fill in the part of the memory dump result struct
that applies to OS's view of Chrome when finalizing
a memory dump.

Was landed then reverted for a flaky test which later turned out
to be unrelated.

Review: https://codereview.chromium.org/2766173003/
Revert: https://codereview.chromium.org/2806553005/

BUG=703184

Review-Url: https://codereview.chromium.org/2812573002
Cr-Commit-Position: refs/heads/master@{#463228}

[modify] https://crrev.com/e649e4c348909f5e528fbccebd48fdbf69df84ef/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/e649e4c348909f5e528fbccebd48fdbf69df84ef/base/trace_event/process_memory_dump.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd1f17f86efd1346e16628622ddde56d560d4a4b

commit bd1f17f86efd1346e16628622ddde56d560d4a4b
Author: fmeawad <fmeawad@chromium.org>
Date: Wed Apr 12 18:05:24 2017

[Memory UMA] Return a memory summary struck with the ack message

This CL updates the returned mojo message to include the MemoryDumpCallbackResult. That struct will be used to create a memory summary that can be sent through UMA and used for other purposes.

A follow up CL will add the extra_processes_dump map.

BUG=703184

Review-Url: https://codereview.chromium.org/2777093009
Cr-Commit-Position: refs/heads/master@{#464083}

[modify] https://crrev.com/bd1f17f86efd1346e16628622ddde56d560d4a4b/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/bd1f17f86efd1346e16628622ddde56d560d4a4b/base/trace_event/memory_dump_manager.h
[modify] https://crrev.com/bd1f17f86efd1346e16628622ddde56d560d4a4b/base/trace_event/memory_dump_manager_unittest.cc
[modify] https://crrev.com/bd1f17f86efd1346e16628622ddde56d560d4a4b/base/trace_event/memory_dump_request_args.cc
[modify] https://crrev.com/bd1f17f86efd1346e16628622ddde56d560d4a4b/base/trace_event/memory_dump_request_args.h
[modify] https://crrev.com/bd1f17f86efd1346e16628622ddde56d560d4a4b/content/browser/tracing/memory_tracing_browsertest.cc
[modify] https://crrev.com/bd1f17f86efd1346e16628622ddde56d560d4a4b/services/resource_coordinator/memory/coordinator/coordinator_impl.cc
[modify] https://crrev.com/bd1f17f86efd1346e16628622ddde56d560d4a4b/services/resource_coordinator/memory/coordinator/coordinator_impl.h
[modify] https://crrev.com/bd1f17f86efd1346e16628622ddde56d560d4a4b/services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc
[modify] https://crrev.com/bd1f17f86efd1346e16628622ddde56d560d4a4b/services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.cc
[modify] https://crrev.com/bd1f17f86efd1346e16628622ddde56d560d4a4b/services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h
[modify] https://crrev.com/bd1f17f86efd1346e16628622ddde56d560d4a4b/services/resource_coordinator/public/cpp/memory/memory_instrumentation.typemap
[modify] https://crrev.com/bd1f17f86efd1346e16628622ddde56d560d4a4b/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc
[modify] https://crrev.com/bd1f17f86efd1346e16628622ddde56d560d4a4b/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h
[modify] https://crrev.com/bd1f17f86efd1346e16628622ddde56d560d4a4b/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33bb7a42b9ea6c9138ac975e35b0242b9da21c07

commit 33bb7a42b9ea6c9138ac975e35b0242b9da21c07
Author: fmeawad <fmeawad@chromium.org>
Date: Thu Apr 20 15:42:03 2017

[Memory UMA] Return the extra_processes_dump map as part of the ResponseCallback

This CL is a follow up CL to http://crrev.com/277709300 where we add the missing
extra_processes_dump map from the MemoryDumpCallbackResult struct into its
corresponding mojo struct.

BUG=703184

Review-Url: https://codereview.chromium.org/2822593002
Cr-Commit-Position: refs/heads/master@{#466021}

[modify] https://crrev.com/33bb7a42b9ea6c9138ac975e35b0242b9da21c07/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/33bb7a42b9ea6c9138ac975e35b0242b9da21c07/mojo/common/BUILD.gn
[modify] https://crrev.com/33bb7a42b9ea6c9138ac975e35b0242b9da21c07/mojo/common/common_custom_types_struct_traits.h
[modify] https://crrev.com/33bb7a42b9ea6c9138ac975e35b0242b9da21c07/mojo/common/common_custom_types_unittest.cc
[add] https://crrev.com/33bb7a42b9ea6c9138ac975e35b0242b9da21c07/mojo/common/process_id.mojom
[add] https://crrev.com/33bb7a42b9ea6c9138ac975e35b0242b9da21c07/mojo/common/process_id.typemap
[modify] https://crrev.com/33bb7a42b9ea6c9138ac975e35b0242b9da21c07/mojo/common/typemaps.gni
[modify] https://crrev.com/33bb7a42b9ea6c9138ac975e35b0242b9da21c07/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc
[modify] https://crrev.com/33bb7a42b9ea6c9138ac975e35b0242b9da21c07/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h
[modify] https://crrev.com/33bb7a42b9ea6c9138ac975e35b0242b9da21c07/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0886512757808f5a6747dbf31b7fb0ada721740

commit b0886512757808f5a6747dbf31b7fb0ada721740
Author: xlai <xlai@chromium.org>
Date: Thu Apr 20 17:24:35 2017

Revert of [Memory UMA] Return the extra_processes_dump map as part of the ResponseCallback (patchset #5 id:80001 of https://codereview.chromium.org/2822593002/ )

Reason for revert:
Suspecting CL that caused compile failure in
https://build.chromium.org/p/chromium/builders/Win/builds/54274.

Need to monitor whether the Win build goes back to green after reverting.

Original issue's description:
> [Memory UMA] Return the extra_processes_dump map as part of the ResponseCallback
>
> This CL is a follow up CL to http://crrev.com/277709300 where we add the missing
> extra_processes_dump map from the MemoryDumpCallbackResult struct into its
> corresponding mojo struct.
>
> BUG=703184
>
> Review-Url: https://codereview.chromium.org/2822593002
> Cr-Commit-Position: refs/heads/master@{#466021}
> Committed: https://chromium.googlesource.com/chromium/src/+/33bb7a42b9ea6c9138ac975e35b0242b9da21c07

TBR=mkwst@chromium.org,hjd@chromium.org,primiano@chromium.org,rockot@chromium.org,fmeawad@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=703184

Review-Url: https://codereview.chromium.org/2828333002
Cr-Commit-Position: refs/heads/master@{#466047}

[modify] https://crrev.com/b0886512757808f5a6747dbf31b7fb0ada721740/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/b0886512757808f5a6747dbf31b7fb0ada721740/mojo/common/BUILD.gn
[modify] https://crrev.com/b0886512757808f5a6747dbf31b7fb0ada721740/mojo/common/common_custom_types_struct_traits.h
[modify] https://crrev.com/b0886512757808f5a6747dbf31b7fb0ada721740/mojo/common/common_custom_types_unittest.cc
[delete] https://crrev.com/a19d2ff185b04105bf66c835f8bb84b8b5fb79b2/mojo/common/process_id.mojom
[delete] https://crrev.com/a19d2ff185b04105bf66c835f8bb84b8b5fb79b2/mojo/common/process_id.typemap
[modify] https://crrev.com/b0886512757808f5a6747dbf31b7fb0ada721740/mojo/common/typemaps.gni
[modify] https://crrev.com/b0886512757808f5a6747dbf31b7fb0ada721740/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc
[modify] https://crrev.com/b0886512757808f5a6747dbf31b7fb0ada721740/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h
[modify] https://crrev.com/b0886512757808f5a6747dbf31b7fb0ada721740/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cacbef5155a1553ace1f76ca4f846f42f51b44a

commit 4cacbef5155a1553ace1f76ca4f846f42f51b44a
Author: fmeawad <fmeawad@chromium.org>
Date: Thu Apr 20 17:53:38 2017

Reland of [Memory UMA] Return the extra_processes_dump map as part of the ResponseCallback (patchset #1 id:1 of https://codereview.chromium.org/2828333002/ )

Reason for revert:
Reland as is: The bot seems to have been flaky

Original issue's description:
> Revert of [Memory UMA] Return the extra_processes_dump map as part of the ResponseCallback (patchset #5 id:80001 of https://codereview.chromium.org/2822593002/ )
>
> Reason for revert:
> Suspecting CL that caused compile failure in
> https://build.chromium.org/p/chromium/builders/Win/builds/54274.
>
> Need to monitor whether the Win build goes back to green after reverting.
>
> Original issue's description:
> > [Memory UMA] Return the extra_processes_dump map as part of the ResponseCallback
> >
> > This CL is a follow up CL to http://crrev.com/277709300 where we add the missing
> > extra_processes_dump map from the MemoryDumpCallbackResult struct into its
> > corresponding mojo struct.
> >
> > BUG=703184
> >
> > Review-Url: https://codereview.chromium.org/2822593002
> > Cr-Commit-Position: refs/heads/master@{#466021}
> > Committed: https://chromium.googlesource.com/chromium/src/+/33bb7a42b9ea6c9138ac975e35b0242b9da21c07
>
> TBR=mkwst@chromium.org,hjd@chromium.org,primiano@chromium.org,rockot@chromium.org,fmeawad@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=703184
>
> Review-Url: https://codereview.chromium.org/2828333002
> Cr-Commit-Position: refs/heads/master@{#466047}
> Committed: https://chromium.googlesource.com/chromium/src/+/b0886512757808f5a6747dbf31b7fb0ada721740

TBR=mkwst@chromium.org,hjd@chromium.org,primiano@chromium.org,rockot@chromium.org,xlai@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=703184

Review-Url: https://codereview.chromium.org/2831073003
Cr-Commit-Position: refs/heads/master@{#466061}

[modify] https://crrev.com/4cacbef5155a1553ace1f76ca4f846f42f51b44a/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/4cacbef5155a1553ace1f76ca4f846f42f51b44a/mojo/common/BUILD.gn
[modify] https://crrev.com/4cacbef5155a1553ace1f76ca4f846f42f51b44a/mojo/common/common_custom_types_struct_traits.h
[modify] https://crrev.com/4cacbef5155a1553ace1f76ca4f846f42f51b44a/mojo/common/common_custom_types_unittest.cc
[add] https://crrev.com/4cacbef5155a1553ace1f76ca4f846f42f51b44a/mojo/common/process_id.mojom
[add] https://crrev.com/4cacbef5155a1553ace1f76ca4f846f42f51b44a/mojo/common/process_id.typemap
[modify] https://crrev.com/4cacbef5155a1553ace1f76ca4f846f42f51b44a/mojo/common/typemaps.gni
[modify] https://crrev.com/4cacbef5155a1553ace1f76ca4f846f42f51b44a/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc
[modify] https://crrev.com/4cacbef5155a1553ace1f76ca4f846f42f51b44a/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h
[modify] https://crrev.com/4cacbef5155a1553ace1f76ca4f846f42f51b44a/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a4589fc42e386ba9b2ad1c153d17dd8180941f8

commit 4a4589fc42e386ba9b2ad1c153d17dd8180941f8
Author: hjd <hjd@chromium.org>
Date: Tue Apr 25 10:02:24 2017

memory-infra: Start disentangling tracing from memory-infra

Starts refactoring the tracing specific code from MemoryDumpManager
into a new class MemoryTracingObserver. This shouldn't change the
behaviour of the MemoryDumpManager.

BUG=703184

Review-Url: https://codereview.chromium.org/2820433005
Cr-Commit-Position: refs/heads/master@{#466936}

[modify] https://crrev.com/4a4589fc42e386ba9b2ad1c153d17dd8180941f8/base/BUILD.gn
[modify] https://crrev.com/4a4589fc42e386ba9b2ad1c153d17dd8180941f8/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/4a4589fc42e386ba9b2ad1c153d17dd8180941f8/base/trace_event/memory_dump_manager.h
[modify] https://crrev.com/4a4589fc42e386ba9b2ad1c153d17dd8180941f8/base/trace_event/memory_dump_manager_unittest.cc
[add] https://crrev.com/4a4589fc42e386ba9b2ad1c153d17dd8180941f8/base/trace_event/memory_tracing_observer.cc
[add] https://crrev.com/4a4589fc42e386ba9b2ad1c153d17dd8180941f8/base/trace_event/memory_tracing_observer.h
[modify] https://crrev.com/4a4589fc42e386ba9b2ad1c153d17dd8180941f8/tools/gn/bootstrap/bootstrap.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f91ad00d0d78fe00a5d1ca4fc50ace6cd63718a7

commit f91ad00d0d78fe00a5d1ca4fc50ace6cd63718a7
Author: ssid <ssid@chromium.org>
Date: Wed Apr 26 01:24:46 2017

[memory-infra] Remove MemoryDumpManagerDelegate

This CL removes the unnecessary Delegate in MemoryDumpManager and just
uses a callback to request global dumps.

BUG=703184

Review-Url: https://codereview.chromium.org/2819413002
Cr-Commit-Position: refs/heads/master@{#467197}

[modify] https://crrev.com/f91ad00d0d78fe00a5d1ca4fc50ace6cd63718a7/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/f91ad00d0d78fe00a5d1ca4fc50ace6cd63718a7/base/trace_event/memory_dump_manager.h
[modify] https://crrev.com/f91ad00d0d78fe00a5d1ca4fc50ace6cd63718a7/base/trace_event/memory_dump_manager_unittest.cc
[modify] https://crrev.com/f91ad00d0d78fe00a5d1ca4fc50ace6cd63718a7/content/child/BUILD.gn
[modify] https://crrev.com/f91ad00d0d78fe00a5d1ca4fc50ace6cd63718a7/content/child/child_thread_impl.cc
[modify] https://crrev.com/f91ad00d0d78fe00a5d1ca4fc50ace6cd63718a7/content/common/BUILD.gn
[modify] https://crrev.com/f91ad00d0d78fe00a5d1ca4fc50ace6cd63718a7/services/resource_coordinator/BUILD.gn
[modify] https://crrev.com/f91ad00d0d78fe00a5d1ca4fc50ace6cd63718a7/services/resource_coordinator/memory/coordinator/coordinator_impl.cc
[modify] https://crrev.com/f91ad00d0d78fe00a5d1ca4fc50ace6cd63718a7/services/resource_coordinator/public/cpp/BUILD.gn
[add] https://crrev.com/f91ad00d0d78fe00a5d1ca4fc50ace6cd63718a7/services/resource_coordinator/public/cpp/memory/memory_export.h
[modify] https://crrev.com/f91ad00d0d78fe00a5d1ca4fc50ace6cd63718a7/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h
[rename] https://crrev.com/f91ad00d0d78fe00a5d1ca4fc50ace6cd63718a7/services/resource_coordinator/public/cpp/memory/process_local_dump_manager_impl.cc
[rename] https://crrev.com/f91ad00d0d78fe00a5d1ca4fc50ace6cd63718a7/services/resource_coordinator/public/cpp/memory/process_local_dump_manager_impl.h
[rename] https://crrev.com/f91ad00d0d78fe00a5d1ca4fc50ace6cd63718a7/services/resource_coordinator/public/cpp/memory/process_local_dump_manager_impl_unittest.cc
[modify] https://crrev.com/f91ad00d0d78fe00a5d1ca4fc50ace6cd63718a7/services/resource_coordinator/public/interfaces/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09b8b3a25d763b86f0f935edae3a0442188872e6

commit 09b8b3a25d763b86f0f935edae3a0442188872e6
Author: hjd <hjd@chromium.org>
Date: Wed Apr 26 15:18:21 2017

memory-infra: Add SUMMARY_ONLY MemoryDumpType

Add a new MemoryDumpType: SUMMARY_ONLY which allows RequestGlobalDump
callers to specify the dump should not be added to the trace.

BUG=703184

Review-Url: https://codereview.chromium.org/2838913002
Cr-Commit-Position: refs/heads/master@{#467327}

[modify] https://crrev.com/09b8b3a25d763b86f0f935edae3a0442188872e6/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/09b8b3a25d763b86f0f935edae3a0442188872e6/base/trace_event/memory_dump_manager_unittest.cc
[modify] https://crrev.com/09b8b3a25d763b86f0f935edae3a0442188872e6/base/trace_event/memory_dump_request_args.cc
[modify] https://crrev.com/09b8b3a25d763b86f0f935edae3a0442188872e6/base/trace_event/memory_dump_request_args.h
[modify] https://crrev.com/09b8b3a25d763b86f0f935edae3a0442188872e6/base/trace_event/memory_tracing_observer.cc
[modify] https://crrev.com/09b8b3a25d763b86f0f935edae3a0442188872e6/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc
[modify] https://crrev.com/09b8b3a25d763b86f0f935edae3a0442188872e6/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09aade854b0637c1da3cb29e93b243393790d534

commit 09aade854b0637c1da3cb29e93b243393790d534
Author: hjd <hjd@chromium.org>
Date: Tue May 02 12:54:17 2017

memory-infra: Add unittest for MemoryDumpManager summary calculations

BUG=703184

Review-Url: https://codereview.chromium.org/2844273002
Cr-Commit-Position: refs/heads/master@{#468609}

[modify] https://crrev.com/09aade854b0637c1da3cb29e93b243393790d534/base/trace_event/memory_dump_manager_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b154afcbc07fcd0b31b1c59ef3c6c30c02bed13a

commit b154afcbc07fcd0b31b1c59ef3c6c30c02bed13a
Author: hjd <hjd@chromium.org>
Date: Fri May 05 18:09:28 2017

memory-infra: Move dump level check to observer and rename session state

- Rename session_state to heap_profiler_serialization_state in MemoryDumpManager.
- Move IsDumpModeAllowed check from MemoryDumpManager to MemoryTracingObserver.

This further decouples MemoryDumpManager from tracing.

BUG=703184

Review-Url: https://codereview.chromium.org/2861133002
Cr-Commit-Position: refs/heads/master@{#469721}

[modify] https://crrev.com/b154afcbc07fcd0b31b1c59ef3c6c30c02bed13a/base/BUILD.gn
[modify] https://crrev.com/b154afcbc07fcd0b31b1c59ef3c6c30c02bed13a/base/trace_event/heap_profiler_heap_dump_writer.cc
[modify] https://crrev.com/b154afcbc07fcd0b31b1c59ef3c6c30c02bed13a/base/trace_event/heap_profiler_heap_dump_writer.h
[modify] https://crrev.com/b154afcbc07fcd0b31b1c59ef3c6c30c02bed13a/base/trace_event/heap_profiler_heap_dump_writer_unittest.cc
[add] https://crrev.com/b154afcbc07fcd0b31b1c59ef3c6c30c02bed13a/base/trace_event/heap_profiler_serialization_state.cc
[rename] https://crrev.com/b154afcbc07fcd0b31b1c59ef3c6c30c02bed13a/base/trace_event/heap_profiler_serialization_state.h
[modify] https://crrev.com/b154afcbc07fcd0b31b1c59ef3c6c30c02bed13a/base/trace_event/memory_allocator_dump_unittest.cc
[modify] https://crrev.com/b154afcbc07fcd0b31b1c59ef3c6c30c02bed13a/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/b154afcbc07fcd0b31b1c59ef3c6c30c02bed13a/base/trace_event/memory_dump_manager.h
[modify] https://crrev.com/b154afcbc07fcd0b31b1c59ef3c6c30c02bed13a/base/trace_event/memory_dump_manager_unittest.cc
[delete] https://crrev.com/914d3011abd8040a608aa533781c1ce6bbc40399/base/trace_event/memory_dump_session_state.cc
[modify] https://crrev.com/b154afcbc07fcd0b31b1c59ef3c6c30c02bed13a/base/trace_event/memory_tracing_observer.cc
[modify] https://crrev.com/b154afcbc07fcd0b31b1c59ef3c6c30c02bed13a/base/trace_event/memory_tracing_observer.h
[modify] https://crrev.com/b154afcbc07fcd0b31b1c59ef3c6c30c02bed13a/base/trace_event/process_memory_dump.cc
[modify] https://crrev.com/b154afcbc07fcd0b31b1c59ef3c6c30c02bed13a/base/trace_event/process_memory_dump.h
[modify] https://crrev.com/b154afcbc07fcd0b31b1c59ef3c6c30c02bed13a/base/trace_event/process_memory_dump_unittest.cc
[modify] https://crrev.com/b154afcbc07fcd0b31b1c59ef3c6c30c02bed13a/tools/gn/bootstrap/bootstrap.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00e2bf72c7611ea4c166bb53bdcc7a7ae3e35bb6

commit 00e2bf72c7611ea4c166bb53bdcc7a7ae3e35bb6
Author: hjd <hjd@chromium.org>
Date: Wed May 10 12:30:00 2017

memory-infra: Rename Enable/Disable in MemoryDumpManager.

Enable/Disable are no longer required to use MemoryDumpManager so rename them to SetupForTracing/TeardownForTracing to more accurately match their use.

BUG=703184

Review-Url: https://codereview.chromium.org/2865243003
Cr-Commit-Position: refs/heads/master@{#470541}

[modify] https://crrev.com/00e2bf72c7611ea4c166bb53bdcc7a7ae3e35bb6/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/00e2bf72c7611ea4c166bb53bdcc7a7ae3e35bb6/base/trace_event/memory_dump_manager.h
[modify] https://crrev.com/00e2bf72c7611ea4c166bb53bdcc7a7ae3e35bb6/base/trace_event/memory_dump_manager_unittest.cc
[modify] https://crrev.com/00e2bf72c7611ea4c166bb53bdcc7a7ae3e35bb6/base/trace_event/memory_tracing_observer.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a7bd66da934d6decc3d60a8c0640a990fc0d0a8

commit 5a7bd66da934d6decc3d60a8c0640a990fc0d0a8
Author: primiano <primiano@chromium.org>
Date: Fri May 12 19:46:02 2017

memory-infra: add ProcessType and expose data in RequestGlobalDump()

This CL addresses two distinct problems:
1) Adds a ProcessType in the per-process struct returned by
ProcessMemoryDump. This will be required in the next CLs for
UMA / UKM aggregation.

2) Adds a GlobalMemoryDump return object to the RequestGlobalMemoryDump
service API. This object will contain the data that UMA/UKM need to
upload.

As a bonus this CL removes the mojo type
memory_instrumentation.mojom.MemoryDumpCallbackResult.
That callback was never meant to be exposed across a service boundary.
It is only used between base::MemoryDumpManager and the client library,
which are by design both hosted in the same process.

BUG=703184

Review-Url: https://codereview.chromium.org/2871223002
Cr-Commit-Position: refs/heads/master@{#471415}

[modify] https://crrev.com/5a7bd66da934d6decc3d60a8c0640a990fc0d0a8/content/child/child_thread_impl.cc
[modify] https://crrev.com/5a7bd66da934d6decc3d60a8c0640a990fc0d0a8/services/resource_coordinator/memory/coordinator/coordinator_impl.cc
[modify] https://crrev.com/5a7bd66da934d6decc3d60a8c0640a990fc0d0a8/services/resource_coordinator/memory/coordinator/coordinator_impl.h
[modify] https://crrev.com/5a7bd66da934d6decc3d60a8c0640a990fc0d0a8/services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc
[modify] https://crrev.com/5a7bd66da934d6decc3d60a8c0640a990fc0d0a8/services/resource_coordinator/public/cpp/memory/memory_instrumentation.typemap
[modify] https://crrev.com/5a7bd66da934d6decc3d60a8c0640a990fc0d0a8/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc
[modify] https://crrev.com/5a7bd66da934d6decc3d60a8c0640a990fc0d0a8/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h
[modify] https://crrev.com/5a7bd66da934d6decc3d60a8c0640a990fc0d0a8/services/resource_coordinator/public/cpp/memory/process_local_dump_manager_impl.cc
[modify] https://crrev.com/5a7bd66da934d6decc3d60a8c0640a990fc0d0a8/services/resource_coordinator/public/cpp/memory/process_local_dump_manager_impl.h
[modify] https://crrev.com/5a7bd66da934d6decc3d60a8c0640a990fc0d0a8/services/resource_coordinator/public/cpp/memory/process_local_dump_manager_impl_unittest.cc
[modify] https://crrev.com/5a7bd66da934d6decc3d60a8c0640a990fc0d0a8/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6e5f6832a2b96892a2562b032aefcd6acf56f56

commit a6e5f6832a2b96892a2562b032aefcd6acf56f56
Author: erikchen <erikchen@chromium.org>
Date: Fri May 12 20:39:20 2017

Emit UMAs for metrics from memory instrumentation service.

ChromeMetricsServiceClient uses MetricsMemoryDetails to fetch and emit
memory-related UMA metrics by manually computing the metrics. This CL adds a
similar class ProcessMemoryMetricsEmitter to fetch and emit metrics from the
memory instrumentation interface. For now, both classes exist and are used. In
the future, the former will be removed.

This CL separates out a memory_instrumentation capability, and then provides
access to that capability from the previous services with access [content_renderer,
content_gpu, etc.] as well as content_browser. This is needed to allow the
content_browser service to access the memory instrumentation interface.

BUG=703184

Review-Url: https://codereview.chromium.org/2876693002
Cr-Commit-Position: refs/heads/master@{#471435}

[modify] https://crrev.com/a6e5f6832a2b96892a2562b032aefcd6acf56f56/chrome/browser/BUILD.gn
[modify] https://crrev.com/a6e5f6832a2b96892a2562b032aefcd6acf56f56/chrome/browser/DEPS
[modify] https://crrev.com/a6e5f6832a2b96892a2562b032aefcd6acf56f56/chrome/browser/metrics/chrome_metrics_service_client.cc
[add] https://crrev.com/a6e5f6832a2b96892a2562b032aefcd6acf56f56/chrome/browser/metrics/process_memory_metrics_emitter.cc
[add] https://crrev.com/a6e5f6832a2b96892a2562b032aefcd6acf56f56/chrome/browser/metrics/process_memory_metrics_emitter.h
[add] https://crrev.com/a6e5f6832a2b96892a2562b032aefcd6acf56f56/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
[modify] https://crrev.com/a6e5f6832a2b96892a2562b032aefcd6acf56f56/chrome/test/BUILD.gn
[modify] https://crrev.com/a6e5f6832a2b96892a2562b032aefcd6acf56f56/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/a6e5f6832a2b96892a2562b032aefcd6acf56f56/content/public/app/mojo/content_gpu_manifest.json
[modify] https://crrev.com/a6e5f6832a2b96892a2562b032aefcd6acf56f56/content/public/app/mojo/content_renderer_manifest.json
[modify] https://crrev.com/a6e5f6832a2b96892a2562b032aefcd6acf56f56/content/public/app/mojo/content_utility_manifest.json
[modify] https://crrev.com/a6e5f6832a2b96892a2562b032aefcd6acf56f56/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df95d5dffe9aa1d9969f097baf40552fa13eea3b

commit df95d5dffe9aa1d9969f097baf40552fa13eea3b
Author: erikchen <erikchen@chromium.org>
Date: Sun May 14 16:37:43 2017

memory-infra: Assemble dump results in service

This CL is a rebase of https://codereview.chromium.org/2867213003/, a CL written
by hjd@. I fixed some issues and addressed some nits as well.

> Do two new things:
> 1) Compute private memory footprint in a platform specific way.
> 2) Match up OSMemDumps with the correct ChromeMemDump.
>
> Both of these require a bit more work, we need to get the correct
> PIDs to do 2, 1 needs to be implemented on Windows & ChromeOS,
> improved on OSX and checked on Android.

BUG=703184,  721882 
TBR=dcheng@chromium.org

Review-Url: https://codereview.chromium.org/2876733005
Cr-Commit-Position: refs/heads/master@{#471630}

[modify] https://crrev.com/df95d5dffe9aa1d9969f097baf40552fa13eea3b/services/resource_coordinator/memory/coordinator/coordinator_impl.cc
[modify] https://crrev.com/df95d5dffe9aa1d9969f097baf40552fa13eea3b/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18ea873dd28c6b2f49b529e57c55898f5df1b4d2

commit 18ea873dd28c6b2f49b529e57c55898f5df1b4d2
Author: erikchen <erikchen@chromium.org>
Date: Tue May 16 01:06:10 2017

[Memory-UMA] Implement basic working prototype.

This CL is based on fmeawad's CL at https://codereview.chromium.org/2875673003/.

This CL includes the following changes:
  * Fix histogram emissions to not be off by a factor of 2 ** 20.
  * Add several end-to-end tests for ProcessMemoryMetricsEmitter. Expand the
  scope of end-to-end tests to sanity check UMA emissions.
  * Change the location where the object that backs the memory instrumentation
  interface is created, as it now requires Mojo to be initialized.
  * The implementation of the memory instrumentation interface now requires
  ServiceManagerListener, so add that requirement to
  content_browser_manifest.json.
  * Create a ProcessMap class that maps service identifiers to pids.
  * Hook up the plumbing in CoordinatorImpl to correctly assemble dumps.

BUG=703184
TBR=rkaplow@chromium.org

Review-Url: https://codereview.chromium.org/2883693002
Cr-Commit-Position: refs/heads/master@{#471964}

[modify] https://crrev.com/18ea873dd28c6b2f49b529e57c55898f5df1b4d2/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/18ea873dd28c6b2f49b529e57c55898f5df1b4d2/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
[modify] https://crrev.com/18ea873dd28c6b2f49b529e57c55898f5df1b4d2/content/browser/browser_main_loop.cc
[modify] https://crrev.com/18ea873dd28c6b2f49b529e57c55898f5df1b4d2/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/18ea873dd28c6b2f49b529e57c55898f5df1b4d2/services/resource_coordinator/BUILD.gn
[modify] https://crrev.com/18ea873dd28c6b2f49b529e57c55898f5df1b4d2/services/resource_coordinator/memory/coordinator/coordinator_impl.cc
[modify] https://crrev.com/18ea873dd28c6b2f49b529e57c55898f5df1b4d2/services/resource_coordinator/memory/coordinator/coordinator_impl.h
[modify] https://crrev.com/18ea873dd28c6b2f49b529e57c55898f5df1b4d2/services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc
[add] https://crrev.com/18ea873dd28c6b2f49b529e57c55898f5df1b4d2/services/resource_coordinator/memory/coordinator/process_map.cc
[add] https://crrev.com/18ea873dd28c6b2f49b529e57c55898f5df1b4d2/services/resource_coordinator/memory/coordinator/process_map.h
[add] https://crrev.com/18ea873dd28c6b2f49b529e57c55898f5df1b4d2/services/resource_coordinator/memory/coordinator/process_map_unittest.cc
[modify] https://crrev.com/18ea873dd28c6b2f49b529e57c55898f5df1b4d2/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom
[modify] https://crrev.com/18ea873dd28c6b2f49b529e57c55898f5df1b4d2/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b

commit 6a9e77ef378c0c835fc9d3265addb0c0d7bd911b
Author: Ahmed Fakhry <afakhry@google.com>
Date: Tue May 16 02:23:04 2017

Revert "[Memory-UMA] Implement basic working prototype."

Manual revet due to too long file.

Reason for revert: Caused ProcessMemoryMetricsEmitterTest.FetchDuringTrace
failure on the Linux ChromiumOS Tests builder.
BUG= 722673 ,703184
TBR=rkaplow@chromium.org,avi@chrmium.org,erikchen@chromium.org,dcheng@chromium.org,primiano@chromium.org

This reverts commit 18ea873dd28c6b2f49b529e57c55898f5df1b4d2.

Review-Url: https://codereview.chromium.org/2884143002 .
Cr-Commit-Position: refs/heads/master@{#471985}

[modify] https://crrev.com/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
[modify] https://crrev.com/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b/content/browser/browser_main_loop.cc
[modify] https://crrev.com/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b/services/resource_coordinator/BUILD.gn
[modify] https://crrev.com/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b/services/resource_coordinator/memory/coordinator/coordinator_impl.cc
[modify] https://crrev.com/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b/services/resource_coordinator/memory/coordinator/coordinator_impl.h
[modify] https://crrev.com/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b/services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc
[delete] https://crrev.com/2b9536581f36776f9a9cc13462d4d7f369686734/services/resource_coordinator/memory/coordinator/process_map.cc
[delete] https://crrev.com/2b9536581f36776f9a9cc13462d4d7f369686734/services/resource_coordinator/memory/coordinator/process_map.h
[delete] https://crrev.com/2b9536581f36776f9a9cc13462d4d7f369686734/services/resource_coordinator/memory/coordinator/process_map_unittest.cc
[modify] https://crrev.com/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom
[modify] https://crrev.com/6a9e77ef378c0c835fc9d3265addb0c0d7bd911b/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fefc7cd8a1677036dca0c7ed55fc1c72f683c16d

commit fefc7cd8a1677036dca0c7ed55fc1c72f683c16d
Author: erikchen <erikchen@chromium.org>
Date: Thu May 18 04:21:34 2017

[reland 1] [Memory-UMA] Implement basic working prototype.

The first attempt to land this CL had test failures on ChromeOS for the newly
added tests. The tests have been updated to also work on ChromeOS.

> This CL is based on fmeawad's CL at https://codereview.chromium.org/2875673003/.
>
> This CL includes the following changes:
>   * Fix histogram emissions to not be off by a factor of 2 ** 20.
>   * Add several end-to-end tests for ProcessMemoryMetricsEmitter. Expand the
>   scope of end-to-end tests to sanity check UMA emissions.
>   * Change the location where the object that backs the memory instrumentation
>   interface is created, as it now requires Mojo to be initialized.
>   * The implementation of the memory instrumentation interface now requires
>   ServiceManagerListener, so add that requirement to
>   content_browser_manifest.json.
>   * Create a ProcessMap class that maps service identifiers to pids.
>   * Hook up the plumbing in CoordinatorImpl to correctly assemble dumps.
>
> BUG=703184
> TBR=rkaplow@chromium.org
>
> Review-Url: https://codereview.chromium.org/2883693002
> Cr-Commit-Position: refs/heads/master@{#471964}
> Committed: https://chromium.googlesource.com/chromium/src/+/18ea873dd28c6b2f49b529e57c55898f5df1b4d2

BUG=703184

Review-Url: https://codereview.chromium.org/2883693002
Cr-Commit-Position: refs/heads/master@{#472659}

[modify] https://crrev.com/fefc7cd8a1677036dca0c7ed55fc1c72f683c16d/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/fefc7cd8a1677036dca0c7ed55fc1c72f683c16d/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
[modify] https://crrev.com/fefc7cd8a1677036dca0c7ed55fc1c72f683c16d/content/browser/browser_main_loop.cc
[modify] https://crrev.com/fefc7cd8a1677036dca0c7ed55fc1c72f683c16d/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/fefc7cd8a1677036dca0c7ed55fc1c72f683c16d/services/resource_coordinator/BUILD.gn
[modify] https://crrev.com/fefc7cd8a1677036dca0c7ed55fc1c72f683c16d/services/resource_coordinator/memory/coordinator/coordinator_impl.cc
[modify] https://crrev.com/fefc7cd8a1677036dca0c7ed55fc1c72f683c16d/services/resource_coordinator/memory/coordinator/coordinator_impl.h
[modify] https://crrev.com/fefc7cd8a1677036dca0c7ed55fc1c72f683c16d/services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc
[add] https://crrev.com/fefc7cd8a1677036dca0c7ed55fc1c72f683c16d/services/resource_coordinator/memory/coordinator/process_map.cc
[add] https://crrev.com/fefc7cd8a1677036dca0c7ed55fc1c72f683c16d/services/resource_coordinator/memory/coordinator/process_map.h
[add] https://crrev.com/fefc7cd8a1677036dca0c7ed55fc1c72f683c16d/services/resource_coordinator/memory/coordinator/process_map_unittest.cc
[modify] https://crrev.com/fefc7cd8a1677036dca0c7ed55fc1c72f683c16d/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom
[modify] https://crrev.com/fefc7cd8a1677036dca0c7ed55fc1c72f683c16d/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c819ae3835c433bc58b0da914b10d3cbc9c0a6c

commit 1c819ae3835c433bc58b0da914b10d3cbc9c0a6c
Author: treib <treib@chromium.org>
Date: Thu May 18 15:04:27 2017

Disable ProcessMemoryMetricsEmitterTest.* on MSan

TBR=erikchen@chromium.org
BUG=703184

Review-Url: https://codereview.chromium.org/2891063002
Cr-Commit-Position: refs/heads/master@{#472811}

[modify] https://crrev.com/1c819ae3835c433bc58b0da914b10d3cbc9c0a6c/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d1e2198851b4731e2c19fa6d36fcb0329f806fd

commit 4d1e2198851b4731e2c19fa6d36fcb0329f806fd
Author: primiano <primiano@chromium.org>
Date: Sat May 20 14:15:18 2017

memory instrumentation service: minor cleanups

Minor cleanups lefts from the previous CL in preparation
of larger upcoming refactoring.

BUG=703184

Review-Url: https://codereview.chromium.org/2891113003
Cr-Commit-Position: refs/heads/master@{#473436}

[modify] https://crrev.com/4d1e2198851b4731e2c19fa6d36fcb0329f806fd/services/resource_coordinator/memory/coordinator/coordinator_impl.cc
[modify] https://crrev.com/4d1e2198851b4731e2c19fa6d36fcb0329f806fd/services/resource_coordinator/memory/coordinator/coordinator_impl.h
[modify] https://crrev.com/4d1e2198851b4731e2c19fa6d36fcb0329f806fd/services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc
[modify] https://crrev.com/4d1e2198851b4731e2c19fa6d36fcb0329f806fd/services/resource_coordinator/memory/coordinator/process_map.cc
[modify] https://crrev.com/4d1e2198851b4731e2c19fa6d36fcb0329f806fd/services/resource_coordinator/memory/coordinator/process_map.h
[modify] https://crrev.com/4d1e2198851b4731e2c19fa6d36fcb0329f806fd/services/resource_coordinator/memory/coordinator/process_map_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aca468f8904f44043315a0366c645d594f765a06

commit aca468f8904f44043315a0366c645d594f765a06
Author: primiano <primiano@chromium.org>
Date: Mon May 22 13:30:32 2017

memory-infra: rename service folder to memory_instrumentation

This is a non-functional refactoring that renamed the memory
instrumentation code within //services/resource_coordinator. Due to
projects/people reshuffling the code ended up being moved
into memory/coordinator that doesn't reflect what the code
inside does (it deals only with instrumentation). Furthermore it is extremely
confusing, as there is a "memory coordinator" project happening in chrome,
which is completely orthogonal with this.

The renames consists of:
- Move the code in //services/resource_coordinator
  from memory/coordinator/ to memory_instrumentation
- Ditto for the public library code in
  //services/resource_coordinator/public/cpp and
  //services/resource_coordinator/public/interfaces
- Rename the class in the client library that handshakes with the
  Coordinator in the service and deals with in-process dumps
  from "ProcessLocalDumpManager" to "ClientProcess"

On top of this, this CL does two minor cleanups in the memory-infra codebase:
- Using new THREAD_CHECKER macro instead of the ThreadChecker class
   (reduces size on non-debug builds).
- Sorts out the ...ForTesting() pattern in MemoryDumpManager, removing the
   need of friend-ing a class outside of its folder.

BUG=703184
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2895083004
Cr-Commit-Position: refs/heads/master@{#473568}

[modify] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/base/trace_event/memory_dump_manager.h
[modify] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/base/trace_event/memory_dump_manager_unittest.cc
[modify] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/chrome/browser/DEPS
[modify] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/chrome/browser/metrics/process_memory_metrics_emitter.h
[modify] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/content/browser/browser_main_loop.cc
[modify] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/content/browser/browser_main_loop.h
[modify] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/content/browser/gpu/browser_gpu_channel_host_factory.cc
[modify] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/content/browser/service_manager/common_browser_interfaces.cc
[modify] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/content/child/child_thread_impl.cc
[modify] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/content/common/child_process_host_impl.cc
[modify] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/BUILD.gn
[rename] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
[rename] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/memory_instrumentation/coordinator_impl.h
[rename] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/memory_instrumentation/coordinator_impl_unittest.cc
[rename] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/memory_instrumentation/process_map.cc
[rename] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/memory_instrumentation/process_map.h
[rename] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/memory_instrumentation/process_map_unittest.cc
[modify] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/public/cpp/BUILD.gn
[rename] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/public/cpp/memory_instrumentation/OWNERS
[rename] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/public/cpp/memory_instrumentation/client_process_impl.cc
[rename] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/public/cpp/memory_instrumentation/client_process_impl.h
[rename] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/public/cpp/memory_instrumentation/client_process_impl_unittest.cc
[rename] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/public/cpp/memory_instrumentation/coordinator.h
[rename] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation.typemap
[rename] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation_struct_traits.cc
[rename] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation_struct_traits.h
[modify] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/public/cpp/typemaps.gni
[modify] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/public/interfaces/BUILD.gn
[rename] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/public/interfaces/memory_instrumentation/OWNERS
[rename] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/public/interfaces/memory_instrumentation/constants.mojom
[rename] https://crrev.com/aca468f8904f44043315a0366c645d594f765a06/services/resource_coordinator/public/interfaces/memory_instrumentation/memory_instrumentation.mojom

 Issue 667804  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a8c37df1f3a7ce86b9d81882e3e959abaaee488

commit 8a8c37df1f3a7ce86b9d81882e3e959abaaee488
Author: Lalit Maganti <lalitm@chromium.org>
Date: Wed Dec 20 12:47:05 2017

memory-infra: Move global request args from mojo to C++ struct

Doing this refactoring cleans the way for a much nicer looking CL for
https://chromium-review.googlesource.com/c/chromium/src/+/830946
as it can just use QueuedRequest::Args instead of adding more fields
to the mojo struct or to QueuedRequest directly.

Bug: 703184
Change-Id: Ia5c08d9173f351484b3b6ab14e10958995ac8588
Reviewed-on: https://chromium-review.googlesource.com/830846
Commit-Queue: Lalit Maganti <lalitm@chromium.org>
Reviewed-by: Hector Dearman <hjd@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525313}
[modify] https://crrev.com/8a8c37df1f3a7ce86b9d81882e3e959abaaee488/services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
[modify] https://crrev.com/8a8c37df1f3a7ce86b9d81882e3e959abaaee488/services/resource_coordinator/memory_instrumentation/coordinator_impl.h
[modify] https://crrev.com/8a8c37df1f3a7ce86b9d81882e3e959abaaee488/services/resource_coordinator/memory_instrumentation/coordinator_impl_unittest.cc
[modify] https://crrev.com/8a8c37df1f3a7ce86b9d81882e3e959abaaee488/services/resource_coordinator/memory_instrumentation/queued_request.cc
[modify] https://crrev.com/8a8c37df1f3a7ce86b9d81882e3e959abaaee488/services/resource_coordinator/memory_instrumentation/queued_request.h
[modify] https://crrev.com/8a8c37df1f3a7ce86b9d81882e3e959abaaee488/services/resource_coordinator/memory_instrumentation/queued_request_dispatcher.cc
[modify] https://crrev.com/8a8c37df1f3a7ce86b9d81882e3e959abaaee488/services/resource_coordinator/public/cpp/memory_instrumentation/client_process_impl.cc
[modify] https://crrev.com/8a8c37df1f3a7ce86b9d81882e3e959abaaee488/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation.cc
[modify] https://crrev.com/8a8c37df1f3a7ce86b9d81882e3e959abaaee488/services/resource_coordinator/public/cpp/memory_instrumentation/tracing_integration_unittest.cc
[modify] https://crrev.com/8a8c37df1f3a7ce86b9d81882e3e959abaaee488/services/resource_coordinator/public/interfaces/memory_instrumentation/memory_instrumentation.mojom