New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 703057 link

Starred by 1 user
Status: Fixed
Owner:
█ sigbjo...@opera.com
Email to this user bounced
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

fast/events/drag-dragend-detaches.html leaks a document on shutdown

Reported by sigbjo...@opera.com, Mar 20 2017 
This test shows up a leak on shutdown, the drag state holding on to a Document for too long:

 ({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,15],"numberOfLiveSuspendableObjects":[2,3]})


( https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Trusty_Leak/3237/layout-test-results/fast/events/drag-dragend-detaches-leak-log.txt )
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6108b39ff0fa823e85bada2e56dbf89d4f9acad

commit f6108b39ff0fa823e85bada2e56dbf89d4f9acad
Author: sigbjornf <sigbjornf@opera.com>
Date: Mon Mar 20 17:50:02 2017

MouseEventManager: reset drag state upon detaching.

If an ongoing drag detaches the frame of the dragged element, have
the MouseEventManager reset the drag state while handling the detachment
from the frame. Otherwise the DragState will retain a reference to
the drag source (and its document) for too long, triggering a reported
leak on shutdown.

R=
BUG= 703057 

Review-Url: https://codereview.chromium.org/2762613002
Cr-Commit-Position: refs/heads/master@{#458116}

[modify] https://crrev.com/f6108b39ff0fa823e85bada2e56dbf89d4f9acad/third_party/WebKit/Source/core/input/MouseEventManager.cpp

Comment 2 by sigbjo...@opera.com, Mar 20 2017

Status: Fixed (was: Started)
►

Sign in to add a comment