Audit usage of 'viewBox' w.r.t validity and emptiness |
||||
Issue descriptionWhile looking at issue 702380 , a number of possible similar infelicities were noticed. * Use of hasEmptyViewBox in SVGSVGElement::localCoordinateSpaceTransform * 'viewBox' from the element vs. 'viewBox' from the fragment identifier * Forcing width/height (and x/y) to zero on semantic errors (not matching Gecko's behavior.) Tests need to be written and tears shed, but in the end we shall rise as victors. Hopefully.
,
Mar 20 2017
,
Mar 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7bd3497dd98baebe652fa5840d8b54cd466a024 commit b7bd3497dd98baebe652fa5840d8b54cd466a024 Author: fs <fs@opera.com> Date: Fri Mar 24 19:29:15 2017 Add SVGFitToViewBox::hasValidViewBox helper This encapsulates the use of the 'is valid' flag of SVGRect. This both makes for more readable code, and should make it easier to transition away from the 'is valid' flag. (Note: !isSpecified() implies !isValid().) BUG=703050 Review-Url: https://codereview.chromium.org/2774753004 Cr-Commit-Position: refs/heads/master@{#459520} [modify] https://crrev.com/b7bd3497dd98baebe652fa5840d8b54cd466a024/third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp [modify] https://crrev.com/b7bd3497dd98baebe652fa5840d8b54cd466a024/third_party/WebKit/Source/core/svg/SVGFitToViewBox.h [modify] https://crrev.com/b7bd3497dd98baebe652fa5840d8b54cd466a024/third_party/WebKit/Source/core/svg/SVGPatternElement.cpp [modify] https://crrev.com/b7bd3497dd98baebe652fa5840d8b54cd466a024/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp [modify] https://crrev.com/b7bd3497dd98baebe652fa5840d8b54cd466a024/third_party/WebKit/Source/core/svg/SVGViewSpec.h
,
Mar 28 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 28 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by f...@opera.com
, Mar 20 2017