New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 703041 link

Starred by 1 user
Status: Fixed
Owner:
tommycli@chromium.org
Closed: Mar 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Unwanted extra blank space is observed on 'Manage Passwords' subpage.

Reported by avsha...@etouch.net, Mar 20 2017 
Chrome Version : 58.0.3029.28 (Official Build) 59df43ab224ab802b5bd51e301e940ef64a899f2-refs/branch-heads/3029@{#287} 32/64 bit
OS : Windows (7,8,10), Mac (10.11.6, 10.12.1, 10.12), Linux (14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings/passwords.
2. Click on 'Main Menu' icon and click on 'About Chrome' (page navigates to 'About chrome' sub page)
3. Now click on browser's back navigation arrow button and observe.

Actual : Unwanted extra blank space is observed on 'Manage Passwords' subpage.
Expected : 'Manage Passwords' subpage should appear properly without any extra blank space. 

This is a regression issue broken in ‘M-57’, below is the Manual Regression range and will soon update other info.
Good build : 57.0.2984.0
Bad build : 57.0.2985.0
Actual_Result.mp4
1.0 MB View Download
Expected_Result.mp4
1.3 MB View Download

Comment 1 by rbasuvula@chromium.org, Mar 20 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: tommycli@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:57.0.2984.0 (Revision:443964).
Bad build:57.0.2985.0 (Revision:444244).

You are probably looking for a change made after 444216 (known good), but no later than 444217 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/8525c81d710cd9a5f92c343825094345e333afd3..52d38e7a5ae31b750d87205b072a324cf99926ef

From the CL above, assigning the issue to the concern owner

@tommycli : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:https://codereview.chromium.org/2627403003
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #59.0.3046.0
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b6d55f0ed8c8b75dbbad2204fef299f4ffa2e21

commit 9b6d55f0ed8c8b75dbbad2204fef299f4ffa2e21
Author: tommycli <tommycli@chromium.org>
Date: Fri Mar 24 21:07:40 2017

MD Settings: Fix About page exception with Advanced lazy loading

There was an Advanced-specific MainPageBehavior update in MD Settings
to support Advanced lazy loading. However, this causes an exception
when applied to the About page. This CL fixes that.

BUG= 703041 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2773813004
Cr-Commit-Position: refs/heads/master@{#459552}

[modify] https://crrev.com/9b6d55f0ed8c8b75dbbad2204fef299f4ffa2e21/chrome/browser/resources/settings/settings_page/main_page_behavior.js

Comment 3 by tbuck...@chromium.org, Mar 27 2017

Labels: Hotlist-MD-Settings-General

Comment 4 by dbeam@chromium.org, Mar 27 2017

Status: Fixed (was: Assigned)
fixed on canary
►

Sign in to add a comment