New issue
Advanced search Search tips

Issue 703036 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

factory: Prevent code duplication by using bft_fixture or not

Project Member Reported by hungte@chromium.org, Mar 20 2017

Issue description

Currently lots of factory pytests have many if-else blocks (and pyargs) that makes execution branch difference due to having BFT or not.

Those logic were made before we have the Device API architecture. We should review how BFT code works and see if we can prevent that by for example overriding DUT link and board class to something like BFTLink and BFTClass, that a test list can override few tests by creating a DUT via BFT classes.
 

Comment 1 Deleted

Comment 2 Deleted

Comment 3 by hungte@chromium.org, Jul 14 2017

Cc: -youcheng@chromium.org -pihsun@chromium.org -yllin@chromium.org -stimim@chromium.org chromeos-factory-eng@google.com

Comment 4 by hungte@chromium.org, Jul 26 2017

Owner: yllin@chromium.org
Temporarily assign yllin as owner - not a high priority item

Comment 5 by hungte@chromium.org, Sep 26 2017

Owner: chenghan@chromium.org
Status: Assigned (was: Untriaged)
Re-assign to noogler chenghan - not high priority.
Owner: hsinyi@chromium.org
Labels: Hotlist-GoodFirstBug
Owner: jamesqaq@chromium.org
Re-assign to noogler.

Sign in to add a comment